You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/31 20:43:08 UTC

[GitHub] [spark] rdblue opened a new pull request #24763: SPARK-27909: Update CTE substitution to be independent.

rdblue opened a new pull request #24763: SPARK-27909: Update CTE substitution to be independent.
URL: https://github.com/apache/spark/pull/24763
 
 
   ## What changes were proposed in this pull request?
   
   This updates CTE substitution to avoid needing to run all resolution rules on each substituted expression. Running resolution rules was previously used to avoid infinite recursion. In the updated rule, CTE plans are substituted as sub-queries from right to left. Using this scope-based order, it is not necessary to replace multiple CTEs at the same time using `resolveOperatorsDown`. Instead, `resolveOperatorsUp` is used to replace each CTE individually.
   
   ## How was this patch tested?
   
   Existing tests in `SQLQueryTestSuite`, `cte.sql`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org