You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by "Tzu-Li (Gordon) Tai" <tz...@apache.org> on 2023/10/25 21:12:34 UTC
[VOTE] Apache Flink Kafka connector version 3.0.1, RC1
Hi everyone,
Please review and vote on release candidate #1 for version 3.0.1 of the
Apache Flink Kafka Connector, as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
This release contains important changes for the following:
- Supports Flink 1.18.x series
- [FLINK-28303] EOS violation when using LATEST_OFFSETS startup mode
- [FLINK-33231] Memory leak causing OOM when there are no offsets to commit
back to Kafka
- [FLINK-28758] FlinkKafkaConsumer fails to stop with savepoint
The release candidate contains the source release as well as JAR artifacts
to be released to Maven, built against Flink 1.17.1 and 1.18.0.
The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org [2],
which are signed with the key with fingerprint
1C1E2394D3194E1944613488F320986D35C33D6A [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag v3.0.1-rc1 [5],
* website pull request listing the new release [6].
The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.
Thanks,
Gordon
[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352910
[2]
https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.1-rc1/
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1664
[5] https://github.com/apache/flink-connector-kafka/commits/v3.0.1-rc1
[6] https://github.com/apache/flink-web/pull/692
[RESULT] [VOTE] Apache Flink Kafka connector version 3.0.1, RC1
Posted by "Tzu-Li (Gordon) Tai" <tz...@apache.org>.
I'm happy to announce that we have unanimously approved this release.
There are 10 approving votes, 4 of which are binding:
* Qingsheng Ren (binding)
* Martijn Visser (binding)
* Xianxun Ye
* Mystic Lama
* Leonard Xu (binding)
* Ahmed Hamdy
* Samrat Deb
* Tzu-Li (Gordon) Tai (binding)
* Sergey Nuyanzin
* Mason Chen
There are no disapproving votes.
Thanks everyone! I'll now release the artifacts, and separately announce
once everything is ready.
Best,
Gordon
On Mon, Oct 30, 2023 at 3:35 PM Tzu-Li (Gordon) Tai <tz...@apache.org>
wrote:
> Thanks for the catch on the docs and fixing it, Xianxun and Mason!
>
> On Mon, Oct 30, 2023 at 12:36 PM Mason Chen <ma...@gmail.com>
> wrote:
>
>> I submitted PR to fix it since I was looking at the Kafka code already:
>> https://github.com/apache/flink-connector-kafka/pull/63
>>
>> On Mon, Oct 30, 2023 at 12:19 PM Mason Chen <ma...@gmail.com>
>> wrote:
>>
>> > +1 (non-binding)
>> >
>> > * Verified hashes and signatures
>> > * Verified no binaries
>> > * Verified poms point to 3.0.1
>> > * Reviewed web PR
>> > * Built from source
>> > * Verified git tag
>> >
>> > @Xianxun, good catch. The datastream docs should be automatically
>> updated
>> > via the doc shortcode. However, it seems that the sql connector doc
>> > shortcode doesn't support the new format of
>> > `{connector-release-version}-{flink-version}`.
>> >
>> > Best,
>> > Mason
>> >
>> > On Mon, Oct 30, 2023 at 9:27 AM Sergey Nuyanzin <sn...@gmail.com>
>> > wrote:
>> >
>> >> +1 (non-binding)
>> >> * Verified hashes and checksums
>> >> * Built from source
>> >> * Checked release tag
>> >> * Reviewed the web PR
>> >>
>> >> On Mon, Oct 30, 2023 at 5:13 PM Tzu-Li (Gordon) Tai <
>> tzulitai@apache.org>
>> >> wrote:
>> >>
>> >> > +1 (binding)
>> >> >
>> >> > - Hashes and checksums
>> >> > - Build succeeds against 1.18.0: mvn clean install
>> >> -Dflink.version=1.18.0
>> >> > - Verified that memory leak issue is fixed for idle topics. Tested
>> >> against
>> >> > Flink 1.18.0 cluster.
>> >> >
>> >> > Thanks,
>> >> > Gordon
>> >> >
>> >> >
>> >> > On Mon, Oct 30, 2023 at 8:20 AM Samrat Deb <de...@gmail.com>
>> >> wrote:
>> >> >
>> >> > > +1 (non-binding)
>> >> > >
>> >> > > - Verified signatures
>> >> > > - Verified Checksum
>> >> > > - Build with Java 8 /11 - build success
>> >> > > - Started MSK cluster and EMR cluster with flink, successfully ran
>> >> some
>> >> > > examples to read and write data to MSK.
>> >> > > - Checked release tag exists
>> >> > >
>> >> > >
>> >> > > Bests,
>> >> > > Samrat
>> >> > >
>> >> > > On Mon, Oct 30, 2023 at 3:47 PM Ahmed Hamdy <ha...@gmail.com>
>> >> > wrote:
>> >> > >
>> >> > > > +1 (non-binding)
>> >> > > > - Verified Singatures
>> >> > > > - Verified Checksum
>> >> > > > - Build source successfully
>> >> > > > - Checked release tag exists
>> >> > > > - Reviewed the web PR
>> >> > > > Best Regards
>> >> > > > Ahmed Hamdy
>> >> > > >
>> >> > > >
>> >> > > > On Sun, 29 Oct 2023 at 08:02, Leonard Xu <xb...@gmail.com>
>> wrote:
>> >> > > >
>> >> > > > > +1 (binding)
>> >> > > > >
>> >> > > > > - Verified signatures
>> >> > > > > - Verified hashsums
>> >> > > > > - Checked Github release tag
>> >> > > > > - Built from source code succeeded
>> >> > > > > - Checked release notes
>> >> > > > > - Reviewed the web PR
>> >> > > > >
>> >> > > > > Best,
>> >> > > > > Leonard
>> >> > > > >
>> >> > > > >
>> >> > > > > > 2023年10月29日 上午11:34，mystic lama <my...@gmail.com>
>> 写道：
>> >> > > > > >
>> >> > > > > > +1 (non-binding)
>> >> > > > > >
>> >> > > > > > - verified signatures
>> >> > > > > > - build with Java 8 and Java 11 - build success
>> >> > > > > >
>> >> > > > > > Minor observation
>> >> > > > > > - RAT check flagged that README.md is missing ASL
>> >> > > > > >
>> >> > > > > > On Fri, 27 Oct 2023 at 23:40, Xianxun Ye <
>> >> yesorno828423@gmail.com>
>> >> > > > > wrote:
>> >> > > > > >
>> >> > > > > >> +1(non-binding)
>> >> > > > > >>
>> >> > > > > >> - Started a local Flink 1.18 cluster, read and wrote with
>> Kafka
>> >> > and
>> >> > > > > Upsert
>> >> > > > > >> Kafka connector successfully to Kafka 2.2 cluster
>> >> > > > > >>
>> >> > > > > >> One minor question: should we update the dependency manual
>> of
>> >> > these
>> >> > > > two
>> >> > > > > >> documentations[1][2]?
>> >> > > > > >>
>> >> > > > > >> [1]
>> >> > > > > >>
>> >> > > > >
>> >> > > >
>> >> > >
>> >> >
>> >>
>> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/kafka/#dependencies
>> >> > > > > >> [2]
>> >> > > > > >>
>> >> > > > >
>> >> > > >
>> >> > >
>> >> >
>> >>
>> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/upsert-kafka/#dependencies
>> >> > > > > >>
>> >> > > > > >> Best regards,
>> >> > > > > >> Xianxun
>> >> > > > > >>
>> >> > > > > >>> 2023年10月26日 16:12，Martijn Visser <martijnvisser@apache.org
>> >
>> >> 写道：
>> >> > > > > >>>
>> >> > > > > >>> +1 (binding)
>> >> > > > > >>>
>> >> > > > > >>> - Validated hashes
>> >> > > > > >>> - Verified signature
>> >> > > > > >>> - Verified that no binaries exist in the source archive
>> >> > > > > >>> - Build the source with Maven via mvn clean install
>> >> > > > > >>> -Pcheck-convergence -Dflink.version=1.18.0
>> >> > > > > >>> - Verified licenses
>> >> > > > > >>> - Verified web PR
>> >> > > > > >>> - Started a cluster and the Flink SQL client, successfully
>> >> read
>> >> > and
>> >> > > > > >>> wrote with the Kafka connector to Confluent Cloud with AVRO
>> >> and
>> >> > > > Schema
>> >> > > > > >>> Registry enabled
>> >> > > > > >>>
>> >> > > > > >>> On Thu, Oct 26, 2023 at 5:09 AM Qingsheng Ren <
>> >> renqs@apache.org>
>> >> > > > > wrote:
>> >> > > > > >>>>
>> >> > > > > >>>> +1 (binding)
>> >> > > > > >>>>
>> >> > > > > >>>> - Verified signature and checksum
>> >> > > > > >>>> - Verified that no binary exists in the source archive
>> >> > > > > >>>> - Built from source with Java 8 using -Dflink.version=1.18
>> >> > > > > >>>> - Started a local Flink 1.18 cluster, submitted jobs with
>> SQL
>> >> > > client
>> >> > > > > >>>> reading from and writing (with exactly-once) to Kafka
>> 3.2.3
>> >> > > cluster
>> >> > > > > >>>> - Nothing suspicious in LICENSE and NOTICE file
>> >> > > > > >>>> - Reviewed web PR
>> >> > > > > >>>>
>> >> > > > > >>>> Thanks for the effort, Gordon!
>> >> > > > > >>>>
>> >> > > > > >>>> Best,
>> >> > > > > >>>> Qingsheng
>> >> > > > > >>>>
>> >> > > > > >>>> On Thu, Oct 26, 2023 at 5:13 AM Tzu-Li (Gordon) Tai <
>> >> > > > > >> tzulitai@apache.org>
>> >> > > > > >>>> wrote:
>> >> > > > > >>>>
>> >> > > > > >>>>> Hi everyone,
>> >> > > > > >>>>>
>> >> > > > > >>>>> Please review and vote on release candidate #1 for
>> version
>> >> > 3.0.1
>> >> > > of
>> >> > > > > the
>> >> > > > > >>>>> Apache Flink Kafka Connector, as follows:
>> >> > > > > >>>>> [ ] +1, Approve the release
>> >> > > > > >>>>> [ ] -1, Do not approve the release (please provide
>> specific
>> >> > > > comments)
>> >> > > > > >>>>>
>> >> > > > > >>>>> This release contains important changes for the
>> following:
>> >> > > > > >>>>> - Supports Flink 1.18.x series
>> >> > > > > >>>>> - [FLINK-28303] EOS violation when using LATEST_OFFSETS
>> >> startup
>> >> > > > mode
>> >> > > > > >>>>> - [FLINK-33231] Memory leak causing OOM when there are no
>> >> > offsets
>> >> > > > to
>> >> > > > > >> commit
>> >> > > > > >>>>> back to Kafka
>> >> > > > > >>>>> - [FLINK-28758] FlinkKafkaConsumer fails to stop with
>> >> savepoint
>> >> > > > > >>>>>
>> >> > > > > >>>>> The release candidate contains the source release as
>> well as
>> >> > JAR
>> >> > > > > >> artifacts
>> >> > > > > >>>>> to be released to Maven, built against Flink 1.17.1 and
>> >> 1.18.0.
>> >> > > > > >>>>>
>> >> > > > > >>>>> The complete staging area is available for your review,
>> >> which
>> >> > > > > includes:
>> >> > > > > >>>>> * JIRA release notes [1],
>> >> > > > > >>>>> * the official Apache source release to be deployed to
>> >> > > > > dist.apache.org
>> >> > > > > >>>>> [2],
>> >> > > > > >>>>> which are signed with the key with fingerprint
>> >> > > > > >>>>> 1C1E2394D3194E1944613488F320986D35C33D6A [3],
>> >> > > > > >>>>> * all artifacts to be deployed to the Maven Central
>> >> Repository
>> >> > > [4],
>> >> > > > > >>>>> * source code tag v3.0.1-rc1 [5],
>> >> > > > > >>>>> * website pull request listing the new release [6].
>> >> > > > > >>>>>
>> >> > > > > >>>>> The vote will be open for at least 72 hours. It is
>> adopted
>> >> by
>> >> > > > > majority
>> >> > > > > >>>>> approval, with at least 3 PMC affirmative votes.
>> >> > > > > >>>>>
>> >> > > > > >>>>> Thanks,
>> >> > > > > >>>>> Gordon
>> >> > > > > >>>>>
>> >> > > > > >>>>> [1]
>> >> > > > > >>>>>
>> >> > > > > >>>>>
>> >> > > > > >>
>> >> > > > >
>> >> > > >
>> >> > >
>> >> >
>> >>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352910
>> >> > > > > >>>>> [2]
>> >> > > > > >>>>>
>> >> > > > > >>>>>
>> >> > > > > >>
>> >> > > > >
>> >> > > >
>> >> > >
>> >> >
>> >>
>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.1-rc1/
>> >> > > > > >>>>> [3]
>> https://dist.apache.org/repos/dist/release/flink/KEYS
>> >> > > > > >>>>> [4]
>> >> > > > > >>
>> >> > > >
>> >> https://repository.apache.org/content/repositories/orgapacheflink-1664
>> >> > > > > >>>>> [5]
>> >> > > > >
>> >> https://github.com/apache/flink-connector-kafka/commits/v3.0.1-rc1
>> >> > > > > >>>>> [6] https://github.com/apache/flink-web/pull/692
>> >> > > > > >>>>>
>> >> > > > > >>
>> >> > > > > >>
>> >> > > > >
>> >> > > > >
>> >> > > >
>> >> > >
>> >> >
>> >>
>> >>
>> >> --
>> >> Best regards,
>> >> Sergey
>> >>
>> >
>>
>
Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1
Posted by "Tzu-Li (Gordon) Tai" <tz...@apache.org>.
Thanks for the catch on the docs and fixing it, Xianxun and Mason!
On Mon, Oct 30, 2023 at 12:36 PM Mason Chen <ma...@gmail.com> wrote:
> I submitted PR to fix it since I was looking at the Kafka code already:
> https://github.com/apache/flink-connector-kafka/pull/63
>
> On Mon, Oct 30, 2023 at 12:19 PM Mason Chen <ma...@gmail.com>
> wrote:
>
> > +1 (non-binding)
> >
> > * Verified hashes and signatures
> > * Verified no binaries
> > * Verified poms point to 3.0.1
> > * Reviewed web PR
> > * Built from source
> > * Verified git tag
> >
> > @Xianxun, good catch. The datastream docs should be automatically updated
> > via the doc shortcode. However, it seems that the sql connector doc
> > shortcode doesn't support the new format of
> > `{connector-release-version}-{flink-version}`.
> >
> > Best,
> > Mason
> >
> > On Mon, Oct 30, 2023 at 9:27 AM Sergey Nuyanzin <sn...@gmail.com>
> > wrote:
> >
> >> +1 (non-binding)
> >> * Verified hashes and checksums
> >> * Built from source
> >> * Checked release tag
> >> * Reviewed the web PR
> >>
> >> On Mon, Oct 30, 2023 at 5:13 PM Tzu-Li (Gordon) Tai <
> tzulitai@apache.org>
> >> wrote:
> >>
> >> > +1 (binding)
> >> >
> >> > - Hashes and checksums
> >> > - Build succeeds against 1.18.0: mvn clean install
> >> -Dflink.version=1.18.0
> >> > - Verified that memory leak issue is fixed for idle topics. Tested
> >> against
> >> > Flink 1.18.0 cluster.
> >> >
> >> > Thanks,
> >> > Gordon
> >> >
> >> >
> >> > On Mon, Oct 30, 2023 at 8:20 AM Samrat Deb <de...@gmail.com>
> >> wrote:
> >> >
> >> > > +1 (non-binding)
> >> > >
> >> > > - Verified signatures
> >> > > - Verified Checksum
> >> > > - Build with Java 8 /11 - build success
> >> > > - Started MSK cluster and EMR cluster with flink, successfully ran
> >> some
> >> > > examples to read and write data to MSK.
> >> > > - Checked release tag exists
> >> > >
> >> > >
> >> > > Bests,
> >> > > Samrat
> >> > >
> >> > > On Mon, Oct 30, 2023 at 3:47 PM Ahmed Hamdy <ha...@gmail.com>
> >> > wrote:
> >> > >
> >> > > > +1 (non-binding)
> >> > > > - Verified Singatures
> >> > > > - Verified Checksum
> >> > > > - Build source successfully
> >> > > > - Checked release tag exists
> >> > > > - Reviewed the web PR
> >> > > > Best Regards
> >> > > > Ahmed Hamdy
> >> > > >
> >> > > >
> >> > > > On Sun, 29 Oct 2023 at 08:02, Leonard Xu <xb...@gmail.com>
> wrote:
> >> > > >
> >> > > > > +1 (binding)
> >> > > > >
> >> > > > > - Verified signatures
> >> > > > > - Verified hashsums
> >> > > > > - Checked Github release tag
> >> > > > > - Built from source code succeeded
> >> > > > > - Checked release notes
> >> > > > > - Reviewed the web PR
> >> > > > >
> >> > > > > Best,
> >> > > > > Leonard
> >> > > > >
> >> > > > >
> >> > > > > > 2023年10月29日 上午11:34，mystic lama <my...@gmail.com> 写道：
> >> > > > > >
> >> > > > > > +1 (non-binding)
> >> > > > > >
> >> > > > > > - verified signatures
> >> > > > > > - build with Java 8 and Java 11 - build success
> >> > > > > >
> >> > > > > > Minor observation
> >> > > > > > - RAT check flagged that README.md is missing ASL
> >> > > > > >
> >> > > > > > On Fri, 27 Oct 2023 at 23:40, Xianxun Ye <
> >> yesorno828423@gmail.com>
> >> > > > > wrote:
> >> > > > > >
> >> > > > > >> +1(non-binding)
> >> > > > > >>
> >> > > > > >> - Started a local Flink 1.18 cluster, read and wrote with
> Kafka
> >> > and
> >> > > > > Upsert
> >> > > > > >> Kafka connector successfully to Kafka 2.2 cluster
> >> > > > > >>
> >> > > > > >> One minor question: should we update the dependency manual of
> >> > these
> >> > > > two
> >> > > > > >> documentations[1][2]?
> >> > > > > >>
> >> > > > > >> [1]
> >> > > > > >>
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/kafka/#dependencies
> >> > > > > >> [2]
> >> > > > > >>
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/upsert-kafka/#dependencies
> >> > > > > >>
> >> > > > > >> Best regards,
> >> > > > > >> Xianxun
> >> > > > > >>
> >> > > > > >>> 2023年10月26日 16:12，Martijn Visser <ma...@apache.org>
> >> 写道：
> >> > > > > >>>
> >> > > > > >>> +1 (binding)
> >> > > > > >>>
> >> > > > > >>> - Validated hashes
> >> > > > > >>> - Verified signature
> >> > > > > >>> - Verified that no binaries exist in the source archive
> >> > > > > >>> - Build the source with Maven via mvn clean install
> >> > > > > >>> -Pcheck-convergence -Dflink.version=1.18.0
> >> > > > > >>> - Verified licenses
> >> > > > > >>> - Verified web PR
> >> > > > > >>> - Started a cluster and the Flink SQL client, successfully
> >> read
> >> > and
> >> > > > > >>> wrote with the Kafka connector to Confluent Cloud with AVRO
> >> and
> >> > > > Schema
> >> > > > > >>> Registry enabled
> >> > > > > >>>
> >> > > > > >>> On Thu, Oct 26, 2023 at 5:09 AM Qingsheng Ren <
> >> renqs@apache.org>
> >> > > > > wrote:
> >> > > > > >>>>
> >> > > > > >>>> +1 (binding)
> >> > > > > >>>>
> >> > > > > >>>> - Verified signature and checksum
> >> > > > > >>>> - Verified that no binary exists in the source archive
> >> > > > > >>>> - Built from source with Java 8 using -Dflink.version=1.18
> >> > > > > >>>> - Started a local Flink 1.18 cluster, submitted jobs with
> SQL
> >> > > client
> >> > > > > >>>> reading from and writing (with exactly-once) to Kafka 3.2.3
> >> > > cluster
> >> > > > > >>>> - Nothing suspicious in LICENSE and NOTICE file
> >> > > > > >>>> - Reviewed web PR
> >> > > > > >>>>
> >> > > > > >>>> Thanks for the effort, Gordon!
> >> > > > > >>>>
> >> > > > > >>>> Best,
> >> > > > > >>>> Qingsheng
> >> > > > > >>>>
> >> > > > > >>>> On Thu, Oct 26, 2023 at 5:13 AM Tzu-Li (Gordon) Tai <
> >> > > > > >> tzulitai@apache.org>
> >> > > > > >>>> wrote:
> >> > > > > >>>>
> >> > > > > >>>>> Hi everyone,
> >> > > > > >>>>>
> >> > > > > >>>>> Please review and vote on release candidate #1 for version
> >> > 3.0.1
> >> > > of
> >> > > > > the
> >> > > > > >>>>> Apache Flink Kafka Connector, as follows:
> >> > > > > >>>>> [ ] +1, Approve the release
> >> > > > > >>>>> [ ] -1, Do not approve the release (please provide
> specific
> >> > > > comments)
> >> > > > > >>>>>
> >> > > > > >>>>> This release contains important changes for the following:
> >> > > > > >>>>> - Supports Flink 1.18.x series
> >> > > > > >>>>> - [FLINK-28303] EOS violation when using LATEST_OFFSETS
> >> startup
> >> > > > mode
> >> > > > > >>>>> - [FLINK-33231] Memory leak causing OOM when there are no
> >> > offsets
> >> > > > to
> >> > > > > >> commit
> >> > > > > >>>>> back to Kafka
> >> > > > > >>>>> - [FLINK-28758] FlinkKafkaConsumer fails to stop with
> >> savepoint
> >> > > > > >>>>>
> >> > > > > >>>>> The release candidate contains the source release as well
> as
> >> > JAR
> >> > > > > >> artifacts
> >> > > > > >>>>> to be released to Maven, built against Flink 1.17.1 and
> >> 1.18.0.
> >> > > > > >>>>>
> >> > > > > >>>>> The complete staging area is available for your review,
> >> which
> >> > > > > includes:
> >> > > > > >>>>> * JIRA release notes [1],
> >> > > > > >>>>> * the official Apache source release to be deployed to
> >> > > > > dist.apache.org
> >> > > > > >>>>> [2],
> >> > > > > >>>>> which are signed with the key with fingerprint
> >> > > > > >>>>> 1C1E2394D3194E1944613488F320986D35C33D6A [3],
> >> > > > > >>>>> * all artifacts to be deployed to the Maven Central
> >> Repository
> >> > > [4],
> >> > > > > >>>>> * source code tag v3.0.1-rc1 [5],
> >> > > > > >>>>> * website pull request listing the new release [6].
> >> > > > > >>>>>
> >> > > > > >>>>> The vote will be open for at least 72 hours. It is adopted
> >> by
> >> > > > > majority
> >> > > > > >>>>> approval, with at least 3 PMC affirmative votes.
> >> > > > > >>>>>
> >> > > > > >>>>> Thanks,
> >> > > > > >>>>> Gordon
> >> > > > > >>>>>
> >> > > > > >>>>> [1]
> >> > > > > >>>>>
> >> > > > > >>>>>
> >> > > > > >>
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352910
> >> > > > > >>>>> [2]
> >> > > > > >>>>>
> >> > > > > >>>>>
> >> > > > > >>
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.1-rc1/
> >> > > > > >>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> >> > > > > >>>>> [4]
> >> > > > > >>
> >> > > >
> >> https://repository.apache.org/content/repositories/orgapacheflink-1664
> >> > > > > >>>>> [5]
> >> > > > >
> >> https://github.com/apache/flink-connector-kafka/commits/v3.0.1-rc1
> >> > > > > >>>>> [6] https://github.com/apache/flink-web/pull/692
> >> > > > > >>>>>
> >> > > > > >>
> >> > > > > >>
> >> > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> >>
> >> --
> >> Best regards,
> >> Sergey
> >>
> >
>
Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1
Posted by Mason Chen <ma...@gmail.com>.
I submitted PR to fix it since I was looking at the Kafka code already:
https://github.com/apache/flink-connector-kafka/pull/63
On Mon, Oct 30, 2023 at 12:19 PM Mason Chen <ma...@gmail.com> wrote:
> +1 (non-binding)
>
> * Verified hashes and signatures
> * Verified no binaries
> * Verified poms point to 3.0.1
> * Reviewed web PR
> * Built from source
> * Verified git tag
>
> @Xianxun, good catch. The datastream docs should be automatically updated
> via the doc shortcode. However, it seems that the sql connector doc
> shortcode doesn't support the new format of
> `{connector-release-version}-{flink-version}`.
>
> Best,
> Mason
>
> On Mon, Oct 30, 2023 at 9:27 AM Sergey Nuyanzin <sn...@gmail.com>
> wrote:
>
>> +1 (non-binding)
>> * Verified hashes and checksums
>> * Built from source
>> * Checked release tag
>> * Reviewed the web PR
>>
>> On Mon, Oct 30, 2023 at 5:13 PM Tzu-Li (Gordon) Tai <tz...@apache.org>
>> wrote:
>>
>> > +1 (binding)
>> >
>> > - Hashes and checksums
>> > - Build succeeds against 1.18.0: mvn clean install
>> -Dflink.version=1.18.0
>> > - Verified that memory leak issue is fixed for idle topics. Tested
>> against
>> > Flink 1.18.0 cluster.
>> >
>> > Thanks,
>> > Gordon
>> >
>> >
>> > On Mon, Oct 30, 2023 at 8:20 AM Samrat Deb <de...@gmail.com>
>> wrote:
>> >
>> > > +1 (non-binding)
>> > >
>> > > - Verified signatures
>> > > - Verified Checksum
>> > > - Build with Java 8 /11 - build success
>> > > - Started MSK cluster and EMR cluster with flink, successfully ran
>> some
>> > > examples to read and write data to MSK.
>> > > - Checked release tag exists
>> > >
>> > >
>> > > Bests,
>> > > Samrat
>> > >
>> > > On Mon, Oct 30, 2023 at 3:47 PM Ahmed Hamdy <ha...@gmail.com>
>> > wrote:
>> > >
>> > > > +1 (non-binding)
>> > > > - Verified Singatures
>> > > > - Verified Checksum
>> > > > - Build source successfully
>> > > > - Checked release tag exists
>> > > > - Reviewed the web PR
>> > > > Best Regards
>> > > > Ahmed Hamdy
>> > > >
>> > > >
>> > > > On Sun, 29 Oct 2023 at 08:02, Leonard Xu <xb...@gmail.com> wrote:
>> > > >
>> > > > > +1 (binding)
>> > > > >
>> > > > > - Verified signatures
>> > > > > - Verified hashsums
>> > > > > - Checked Github release tag
>> > > > > - Built from source code succeeded
>> > > > > - Checked release notes
>> > > > > - Reviewed the web PR
>> > > > >
>> > > > > Best,
>> > > > > Leonard
>> > > > >
>> > > > >
>> > > > > > 2023年10月29日 上午11:34，mystic lama <my...@gmail.com> 写道：
>> > > > > >
>> > > > > > +1 (non-binding)
>> > > > > >
>> > > > > > - verified signatures
>> > > > > > - build with Java 8 and Java 11 - build success
>> > > > > >
>> > > > > > Minor observation
>> > > > > > - RAT check flagged that README.md is missing ASL
>> > > > > >
>> > > > > > On Fri, 27 Oct 2023 at 23:40, Xianxun Ye <
>> yesorno828423@gmail.com>
>> > > > > wrote:
>> > > > > >
>> > > > > >> +1(non-binding)
>> > > > > >>
>> > > > > >> - Started a local Flink 1.18 cluster, read and wrote with Kafka
>> > and
>> > > > > Upsert
>> > > > > >> Kafka connector successfully to Kafka 2.2 cluster
>> > > > > >>
>> > > > > >> One minor question: should we update the dependency manual of
>> > these
>> > > > two
>> > > > > >> documentations[1][2]?
>> > > > > >>
>> > > > > >> [1]
>> > > > > >>
>> > > > >
>> > > >
>> > >
>> >
>> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/kafka/#dependencies
>> > > > > >> [2]
>> > > > > >>
>> > > > >
>> > > >
>> > >
>> >
>> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/upsert-kafka/#dependencies
>> > > > > >>
>> > > > > >> Best regards,
>> > > > > >> Xianxun
>> > > > > >>
>> > > > > >>> 2023年10月26日 16:12，Martijn Visser <ma...@apache.org>
>> 写道：
>> > > > > >>>
>> > > > > >>> +1 (binding)
>> > > > > >>>
>> > > > > >>> - Validated hashes
>> > > > > >>> - Verified signature
>> > > > > >>> - Verified that no binaries exist in the source archive
>> > > > > >>> - Build the source with Maven via mvn clean install
>> > > > > >>> -Pcheck-convergence -Dflink.version=1.18.0
>> > > > > >>> - Verified licenses
>> > > > > >>> - Verified web PR
>> > > > > >>> - Started a cluster and the Flink SQL client, successfully
>> read
>> > and
>> > > > > >>> wrote with the Kafka connector to Confluent Cloud with AVRO
>> and
>> > > > Schema
>> > > > > >>> Registry enabled
>> > > > > >>>
>> > > > > >>> On Thu, Oct 26, 2023 at 5:09 AM Qingsheng Ren <
>> renqs@apache.org>
>> > > > > wrote:
>> > > > > >>>>
>> > > > > >>>> +1 (binding)
>> > > > > >>>>
>> > > > > >>>> - Verified signature and checksum
>> > > > > >>>> - Verified that no binary exists in the source archive
>> > > > > >>>> - Built from source with Java 8 using -Dflink.version=1.18
>> > > > > >>>> - Started a local Flink 1.18 cluster, submitted jobs with SQL
>> > > client
>> > > > > >>>> reading from and writing (with exactly-once) to Kafka 3.2.3
>> > > cluster
>> > > > > >>>> - Nothing suspicious in LICENSE and NOTICE file
>> > > > > >>>> - Reviewed web PR
>> > > > > >>>>
>> > > > > >>>> Thanks for the effort, Gordon!
>> > > > > >>>>
>> > > > > >>>> Best,
>> > > > > >>>> Qingsheng
>> > > > > >>>>
>> > > > > >>>> On Thu, Oct 26, 2023 at 5:13 AM Tzu-Li (Gordon) Tai <
>> > > > > >> tzulitai@apache.org>
>> > > > > >>>> wrote:
>> > > > > >>>>
>> > > > > >>>>> Hi everyone,
>> > > > > >>>>>
>> > > > > >>>>> Please review and vote on release candidate #1 for version
>> > 3.0.1
>> > > of
>> > > > > the
>> > > > > >>>>> Apache Flink Kafka Connector, as follows:
>> > > > > >>>>> [ ] +1, Approve the release
>> > > > > >>>>> [ ] -1, Do not approve the release (please provide specific
>> > > > comments)
>> > > > > >>>>>
>> > > > > >>>>> This release contains important changes for the following:
>> > > > > >>>>> - Supports Flink 1.18.x series
>> > > > > >>>>> - [FLINK-28303] EOS violation when using LATEST_OFFSETS
>> startup
>> > > > mode
>> > > > > >>>>> - [FLINK-33231] Memory leak causing OOM when there are no
>> > offsets
>> > > > to
>> > > > > >> commit
>> > > > > >>>>> back to Kafka
>> > > > > >>>>> - [FLINK-28758] FlinkKafkaConsumer fails to stop with
>> savepoint
>> > > > > >>>>>
>> > > > > >>>>> The release candidate contains the source release as well as
>> > JAR
>> > > > > >> artifacts
>> > > > > >>>>> to be released to Maven, built against Flink 1.17.1 and
>> 1.18.0.
>> > > > > >>>>>
>> > > > > >>>>> The complete staging area is available for your review,
>> which
>> > > > > includes:
>> > > > > >>>>> * JIRA release notes [1],
>> > > > > >>>>> * the official Apache source release to be deployed to
>> > > > > dist.apache.org
>> > > > > >>>>> [2],
>> > > > > >>>>> which are signed with the key with fingerprint
>> > > > > >>>>> 1C1E2394D3194E1944613488F320986D35C33D6A [3],
>> > > > > >>>>> * all artifacts to be deployed to the Maven Central
>> Repository
>> > > [4],
>> > > > > >>>>> * source code tag v3.0.1-rc1 [5],
>> > > > > >>>>> * website pull request listing the new release [6].
>> > > > > >>>>>
>> > > > > >>>>> The vote will be open for at least 72 hours. It is adopted
>> by
>> > > > > majority
>> > > > > >>>>> approval, with at least 3 PMC affirmative votes.
>> > > > > >>>>>
>> > > > > >>>>> Thanks,
>> > > > > >>>>> Gordon
>> > > > > >>>>>
>> > > > > >>>>> [1]
>> > > > > >>>>>
>> > > > > >>>>>
>> > > > > >>
>> > > > >
>> > > >
>> > >
>> >
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352910
>> > > > > >>>>> [2]
>> > > > > >>>>>
>> > > > > >>>>>
>> > > > > >>
>> > > > >
>> > > >
>> > >
>> >
>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.1-rc1/
>> > > > > >>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>> > > > > >>>>> [4]
>> > > > > >>
>> > > >
>> https://repository.apache.org/content/repositories/orgapacheflink-1664
>> > > > > >>>>> [5]
>> > > > >
>> https://github.com/apache/flink-connector-kafka/commits/v3.0.1-rc1
>> > > > > >>>>> [6] https://github.com/apache/flink-web/pull/692
>> > > > > >>>>>
>> > > > > >>
>> > > > > >>
>> > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
>>
>> --
>> Best regards,
>> Sergey
>>
>
Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1
Posted by Mason Chen <ma...@gmail.com>.
+1 (non-binding)
* Verified hashes and signatures
* Verified no binaries
* Verified poms point to 3.0.1
* Reviewed web PR
* Built from source
* Verified git tag
@Xianxun, good catch. The datastream docs should be automatically updated
via the doc shortcode. However, it seems that the sql connector doc
shortcode doesn't support the new format of
`{connector-release-version}-{flink-version}`.
Best,
Mason
On Mon, Oct 30, 2023 at 9:27 AM Sergey Nuyanzin <sn...@gmail.com> wrote:
> +1 (non-binding)
> * Verified hashes and checksums
> * Built from source
> * Checked release tag
> * Reviewed the web PR
>
> On Mon, Oct 30, 2023 at 5:13 PM Tzu-Li (Gordon) Tai <tz...@apache.org>
> wrote:
>
> > +1 (binding)
> >
> > - Hashes and checksums
> > - Build succeeds against 1.18.0: mvn clean install -Dflink.version=1.18.0
> > - Verified that memory leak issue is fixed for idle topics. Tested
> against
> > Flink 1.18.0 cluster.
> >
> > Thanks,
> > Gordon
> >
> >
> > On Mon, Oct 30, 2023 at 8:20 AM Samrat Deb <de...@gmail.com>
> wrote:
> >
> > > +1 (non-binding)
> > >
> > > - Verified signatures
> > > - Verified Checksum
> > > - Build with Java 8 /11 - build success
> > > - Started MSK cluster and EMR cluster with flink, successfully ran some
> > > examples to read and write data to MSK.
> > > - Checked release tag exists
> > >
> > >
> > > Bests,
> > > Samrat
> > >
> > > On Mon, Oct 30, 2023 at 3:47 PM Ahmed Hamdy <ha...@gmail.com>
> > wrote:
> > >
> > > > +1 (non-binding)
> > > > - Verified Singatures
> > > > - Verified Checksum
> > > > - Build source successfully
> > > > - Checked release tag exists
> > > > - Reviewed the web PR
> > > > Best Regards
> > > > Ahmed Hamdy
> > > >
> > > >
> > > > On Sun, 29 Oct 2023 at 08:02, Leonard Xu <xb...@gmail.com> wrote:
> > > >
> > > > > +1 (binding)
> > > > >
> > > > > - Verified signatures
> > > > > - Verified hashsums
> > > > > - Checked Github release tag
> > > > > - Built from source code succeeded
> > > > > - Checked release notes
> > > > > - Reviewed the web PR
> > > > >
> > > > > Best,
> > > > > Leonard
> > > > >
> > > > >
> > > > > > 2023年10月29日 上午11:34，mystic lama <my...@gmail.com> 写道：
> > > > > >
> > > > > > +1 (non-binding)
> > > > > >
> > > > > > - verified signatures
> > > > > > - build with Java 8 and Java 11 - build success
> > > > > >
> > > > > > Minor observation
> > > > > > - RAT check flagged that README.md is missing ASL
> > > > > >
> > > > > > On Fri, 27 Oct 2023 at 23:40, Xianxun Ye <
> yesorno828423@gmail.com>
> > > > > wrote:
> > > > > >
> > > > > >> +1(non-binding)
> > > > > >>
> > > > > >> - Started a local Flink 1.18 cluster, read and wrote with Kafka
> > and
> > > > > Upsert
> > > > > >> Kafka connector successfully to Kafka 2.2 cluster
> > > > > >>
> > > > > >> One minor question: should we update the dependency manual of
> > these
> > > > two
> > > > > >> documentations[1][2]?
> > > > > >>
> > > > > >> [1]
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/kafka/#dependencies
> > > > > >> [2]
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/upsert-kafka/#dependencies
> > > > > >>
> > > > > >> Best regards,
> > > > > >> Xianxun
> > > > > >>
> > > > > >>> 2023年10月26日 16:12，Martijn Visser <ma...@apache.org>
> 写道：
> > > > > >>>
> > > > > >>> +1 (binding)
> > > > > >>>
> > > > > >>> - Validated hashes
> > > > > >>> - Verified signature
> > > > > >>> - Verified that no binaries exist in the source archive
> > > > > >>> - Build the source with Maven via mvn clean install
> > > > > >>> -Pcheck-convergence -Dflink.version=1.18.0
> > > > > >>> - Verified licenses
> > > > > >>> - Verified web PR
> > > > > >>> - Started a cluster and the Flink SQL client, successfully read
> > and
> > > > > >>> wrote with the Kafka connector to Confluent Cloud with AVRO and
> > > > Schema
> > > > > >>> Registry enabled
> > > > > >>>
> > > > > >>> On Thu, Oct 26, 2023 at 5:09 AM Qingsheng Ren <
> renqs@apache.org>
> > > > > wrote:
> > > > > >>>>
> > > > > >>>> +1 (binding)
> > > > > >>>>
> > > > > >>>> - Verified signature and checksum
> > > > > >>>> - Verified that no binary exists in the source archive
> > > > > >>>> - Built from source with Java 8 using -Dflink.version=1.18
> > > > > >>>> - Started a local Flink 1.18 cluster, submitted jobs with SQL
> > > client
> > > > > >>>> reading from and writing (with exactly-once) to Kafka 3.2.3
> > > cluster
> > > > > >>>> - Nothing suspicious in LICENSE and NOTICE file
> > > > > >>>> - Reviewed web PR
> > > > > >>>>
> > > > > >>>> Thanks for the effort, Gordon!
> > > > > >>>>
> > > > > >>>> Best,
> > > > > >>>> Qingsheng
> > > > > >>>>
> > > > > >>>> On Thu, Oct 26, 2023 at 5:13 AM Tzu-Li (Gordon) Tai <
> > > > > >> tzulitai@apache.org>
> > > > > >>>> wrote:
> > > > > >>>>
> > > > > >>>>> Hi everyone,
> > > > > >>>>>
> > > > > >>>>> Please review and vote on release candidate #1 for version
> > 3.0.1
> > > of
> > > > > the
> > > > > >>>>> Apache Flink Kafka Connector, as follows:
> > > > > >>>>> [ ] +1, Approve the release
> > > > > >>>>> [ ] -1, Do not approve the release (please provide specific
> > > > comments)
> > > > > >>>>>
> > > > > >>>>> This release contains important changes for the following:
> > > > > >>>>> - Supports Flink 1.18.x series
> > > > > >>>>> - [FLINK-28303] EOS violation when using LATEST_OFFSETS
> startup
> > > > mode
> > > > > >>>>> - [FLINK-33231] Memory leak causing OOM when there are no
> > offsets
> > > > to
> > > > > >> commit
> > > > > >>>>> back to Kafka
> > > > > >>>>> - [FLINK-28758] FlinkKafkaConsumer fails to stop with
> savepoint
> > > > > >>>>>
> > > > > >>>>> The release candidate contains the source release as well as
> > JAR
> > > > > >> artifacts
> > > > > >>>>> to be released to Maven, built against Flink 1.17.1 and
> 1.18.0.
> > > > > >>>>>
> > > > > >>>>> The complete staging area is available for your review, which
> > > > > includes:
> > > > > >>>>> * JIRA release notes [1],
> > > > > >>>>> * the official Apache source release to be deployed to
> > > > > dist.apache.org
> > > > > >>>>> [2],
> > > > > >>>>> which are signed with the key with fingerprint
> > > > > >>>>> 1C1E2394D3194E1944613488F320986D35C33D6A [3],
> > > > > >>>>> * all artifacts to be deployed to the Maven Central
> Repository
> > > [4],
> > > > > >>>>> * source code tag v3.0.1-rc1 [5],
> > > > > >>>>> * website pull request listing the new release [6].
> > > > > >>>>>
> > > > > >>>>> The vote will be open for at least 72 hours. It is adopted by
> > > > > majority
> > > > > >>>>> approval, with at least 3 PMC affirmative votes.
> > > > > >>>>>
> > > > > >>>>> Thanks,
> > > > > >>>>> Gordon
> > > > > >>>>>
> > > > > >>>>> [1]
> > > > > >>>>>
> > > > > >>>>>
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352910
> > > > > >>>>> [2]
> > > > > >>>>>
> > > > > >>>>>
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.1-rc1/
> > > > > >>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > > >>>>> [4]
> > > > > >>
> > > >
> https://repository.apache.org/content/repositories/orgapacheflink-1664
> > > > > >>>>> [5]
> > > > > https://github.com/apache/flink-connector-kafka/commits/v3.0.1-rc1
> > > > > >>>>> [6] https://github.com/apache/flink-web/pull/692
> > > > > >>>>>
> > > > > >>
> > > > > >>
> > > > >
> > > > >
> > > >
> > >
> >
>
>
> --
> Best regards,
> Sergey
>
Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1
Posted by Sergey Nuyanzin <sn...@gmail.com>.
+1 (non-binding)
* Verified hashes and checksums
* Built from source
* Checked release tag
* Reviewed the web PR
On Mon, Oct 30, 2023 at 5:13 PM Tzu-Li (Gordon) Tai <tz...@apache.org>
wrote:
> +1 (binding)
>
> - Hashes and checksums
> - Build succeeds against 1.18.0: mvn clean install -Dflink.version=1.18.0
> - Verified that memory leak issue is fixed for idle topics. Tested against
> Flink 1.18.0 cluster.
>
> Thanks,
> Gordon
>
>
> On Mon, Oct 30, 2023 at 8:20 AM Samrat Deb <de...@gmail.com> wrote:
>
> > +1 (non-binding)
> >
> > - Verified signatures
> > - Verified Checksum
> > - Build with Java 8 /11 - build success
> > - Started MSK cluster and EMR cluster with flink, successfully ran some
> > examples to read and write data to MSK.
> > - Checked release tag exists
> >
> >
> > Bests,
> > Samrat
> >
> > On Mon, Oct 30, 2023 at 3:47 PM Ahmed Hamdy <ha...@gmail.com>
> wrote:
> >
> > > +1 (non-binding)
> > > - Verified Singatures
> > > - Verified Checksum
> > > - Build source successfully
> > > - Checked release tag exists
> > > - Reviewed the web PR
> > > Best Regards
> > > Ahmed Hamdy
> > >
> > >
> > > On Sun, 29 Oct 2023 at 08:02, Leonard Xu <xb...@gmail.com> wrote:
> > >
> > > > +1 (binding)
> > > >
> > > > - Verified signatures
> > > > - Verified hashsums
> > > > - Checked Github release tag
> > > > - Built from source code succeeded
> > > > - Checked release notes
> > > > - Reviewed the web PR
> > > >
> > > > Best,
> > > > Leonard
> > > >
> > > >
> > > > > 2023年10月29日 上午11:34，mystic lama <my...@gmail.com> 写道：
> > > > >
> > > > > +1 (non-binding)
> > > > >
> > > > > - verified signatures
> > > > > - build with Java 8 and Java 11 - build success
> > > > >
> > > > > Minor observation
> > > > > - RAT check flagged that README.md is missing ASL
> > > > >
> > > > > On Fri, 27 Oct 2023 at 23:40, Xianxun Ye <ye...@gmail.com>
> > > > wrote:
> > > > >
> > > > >> +1(non-binding)
> > > > >>
> > > > >> - Started a local Flink 1.18 cluster, read and wrote with Kafka
> and
> > > > Upsert
> > > > >> Kafka connector successfully to Kafka 2.2 cluster
> > > > >>
> > > > >> One minor question: should we update the dependency manual of
> these
> > > two
> > > > >> documentations[1][2]?
> > > > >>
> > > > >> [1]
> > > > >>
> > > >
> > >
> >
> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/kafka/#dependencies
> > > > >> [2]
> > > > >>
> > > >
> > >
> >
> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/upsert-kafka/#dependencies
> > > > >>
> > > > >> Best regards,
> > > > >> Xianxun
> > > > >>
> > > > >>> 2023年10月26日 16:12，Martijn Visser <ma...@apache.org> 写道：
> > > > >>>
> > > > >>> +1 (binding)
> > > > >>>
> > > > >>> - Validated hashes
> > > > >>> - Verified signature
> > > > >>> - Verified that no binaries exist in the source archive
> > > > >>> - Build the source with Maven via mvn clean install
> > > > >>> -Pcheck-convergence -Dflink.version=1.18.0
> > > > >>> - Verified licenses
> > > > >>> - Verified web PR
> > > > >>> - Started a cluster and the Flink SQL client, successfully read
> and
> > > > >>> wrote with the Kafka connector to Confluent Cloud with AVRO and
> > > Schema
> > > > >>> Registry enabled
> > > > >>>
> > > > >>> On Thu, Oct 26, 2023 at 5:09 AM Qingsheng Ren <re...@apache.org>
> > > > wrote:
> > > > >>>>
> > > > >>>> +1 (binding)
> > > > >>>>
> > > > >>>> - Verified signature and checksum
> > > > >>>> - Verified that no binary exists in the source archive
> > > > >>>> - Built from source with Java 8 using -Dflink.version=1.18
> > > > >>>> - Started a local Flink 1.18 cluster, submitted jobs with SQL
> > client
> > > > >>>> reading from and writing (with exactly-once) to Kafka 3.2.3
> > cluster
> > > > >>>> - Nothing suspicious in LICENSE and NOTICE file
> > > > >>>> - Reviewed web PR
> > > > >>>>
> > > > >>>> Thanks for the effort, Gordon!
> > > > >>>>
> > > > >>>> Best,
> > > > >>>> Qingsheng
> > > > >>>>
> > > > >>>> On Thu, Oct 26, 2023 at 5:13 AM Tzu-Li (Gordon) Tai <
> > > > >> tzulitai@apache.org>
> > > > >>>> wrote:
> > > > >>>>
> > > > >>>>> Hi everyone,
> > > > >>>>>
> > > > >>>>> Please review and vote on release candidate #1 for version
> 3.0.1
> > of
> > > > the
> > > > >>>>> Apache Flink Kafka Connector, as follows:
> > > > >>>>> [ ] +1, Approve the release
> > > > >>>>> [ ] -1, Do not approve the release (please provide specific
> > > comments)
> > > > >>>>>
> > > > >>>>> This release contains important changes for the following:
> > > > >>>>> - Supports Flink 1.18.x series
> > > > >>>>> - [FLINK-28303] EOS violation when using LATEST_OFFSETS startup
> > > mode
> > > > >>>>> - [FLINK-33231] Memory leak causing OOM when there are no
> offsets
> > > to
> > > > >> commit
> > > > >>>>> back to Kafka
> > > > >>>>> - [FLINK-28758] FlinkKafkaConsumer fails to stop with savepoint
> > > > >>>>>
> > > > >>>>> The release candidate contains the source release as well as
> JAR
> > > > >> artifacts
> > > > >>>>> to be released to Maven, built against Flink 1.17.1 and 1.18.0.
> > > > >>>>>
> > > > >>>>> The complete staging area is available for your review, which
> > > > includes:
> > > > >>>>> * JIRA release notes [1],
> > > > >>>>> * the official Apache source release to be deployed to
> > > > dist.apache.org
> > > > >>>>> [2],
> > > > >>>>> which are signed with the key with fingerprint
> > > > >>>>> 1C1E2394D3194E1944613488F320986D35C33D6A [3],
> > > > >>>>> * all artifacts to be deployed to the Maven Central Repository
> > [4],
> > > > >>>>> * source code tag v3.0.1-rc1 [5],
> > > > >>>>> * website pull request listing the new release [6].
> > > > >>>>>
> > > > >>>>> The vote will be open for at least 72 hours. It is adopted by
> > > > majority
> > > > >>>>> approval, with at least 3 PMC affirmative votes.
> > > > >>>>>
> > > > >>>>> Thanks,
> > > > >>>>> Gordon
> > > > >>>>>
> > > > >>>>> [1]
> > > > >>>>>
> > > > >>>>>
> > > > >>
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352910
> > > > >>>>> [2]
> > > > >>>>>
> > > > >>>>>
> > > > >>
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.1-rc1/
> > > > >>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > >>>>> [4]
> > > > >>
> > > https://repository.apache.org/content/repositories/orgapacheflink-1664
> > > > >>>>> [5]
> > > > https://github.com/apache/flink-connector-kafka/commits/v3.0.1-rc1
> > > > >>>>> [6] https://github.com/apache/flink-web/pull/692
> > > > >>>>>
> > > > >>
> > > > >>
> > > >
> > > >
> > >
> >
>
--
Best regards,
Sergey
Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1
Posted by "Tzu-Li (Gordon) Tai" <tz...@apache.org>.
+1 (binding)
- Hashes and checksums
- Build succeeds against 1.18.0: mvn clean install -Dflink.version=1.18.0
- Verified that memory leak issue is fixed for idle topics. Tested against
Flink 1.18.0 cluster.
Thanks,
Gordon
On Mon, Oct 30, 2023 at 8:20 AM Samrat Deb <de...@gmail.com> wrote:
> +1 (non-binding)
>
> - Verified signatures
> - Verified Checksum
> - Build with Java 8 /11 - build success
> - Started MSK cluster and EMR cluster with flink, successfully ran some
> examples to read and write data to MSK.
> - Checked release tag exists
>
>
> Bests,
> Samrat
>
> On Mon, Oct 30, 2023 at 3:47 PM Ahmed Hamdy <ha...@gmail.com> wrote:
>
> > +1 (non-binding)
> > - Verified Singatures
> > - Verified Checksum
> > - Build source successfully
> > - Checked release tag exists
> > - Reviewed the web PR
> > Best Regards
> > Ahmed Hamdy
> >
> >
> > On Sun, 29 Oct 2023 at 08:02, Leonard Xu <xb...@gmail.com> wrote:
> >
> > > +1 (binding)
> > >
> > > - Verified signatures
> > > - Verified hashsums
> > > - Checked Github release tag
> > > - Built from source code succeeded
> > > - Checked release notes
> > > - Reviewed the web PR
> > >
> > > Best,
> > > Leonard
> > >
> > >
> > > > 2023年10月29日 上午11:34，mystic lama <my...@gmail.com> 写道：
> > > >
> > > > +1 (non-binding)
> > > >
> > > > - verified signatures
> > > > - build with Java 8 and Java 11 - build success
> > > >
> > > > Minor observation
> > > > - RAT check flagged that README.md is missing ASL
> > > >
> > > > On Fri, 27 Oct 2023 at 23:40, Xianxun Ye <ye...@gmail.com>
> > > wrote:
> > > >
> > > >> +1(non-binding)
> > > >>
> > > >> - Started a local Flink 1.18 cluster, read and wrote with Kafka and
> > > Upsert
> > > >> Kafka connector successfully to Kafka 2.2 cluster
> > > >>
> > > >> One minor question: should we update the dependency manual of these
> > two
> > > >> documentations[1][2]?
> > > >>
> > > >> [1]
> > > >>
> > >
> >
> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/kafka/#dependencies
> > > >> [2]
> > > >>
> > >
> >
> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/upsert-kafka/#dependencies
> > > >>
> > > >> Best regards,
> > > >> Xianxun
> > > >>
> > > >>> 2023年10月26日 16:12，Martijn Visser <ma...@apache.org> 写道：
> > > >>>
> > > >>> +1 (binding)
> > > >>>
> > > >>> - Validated hashes
> > > >>> - Verified signature
> > > >>> - Verified that no binaries exist in the source archive
> > > >>> - Build the source with Maven via mvn clean install
> > > >>> -Pcheck-convergence -Dflink.version=1.18.0
> > > >>> - Verified licenses
> > > >>> - Verified web PR
> > > >>> - Started a cluster and the Flink SQL client, successfully read and
> > > >>> wrote with the Kafka connector to Confluent Cloud with AVRO and
> > Schema
> > > >>> Registry enabled
> > > >>>
> > > >>> On Thu, Oct 26, 2023 at 5:09 AM Qingsheng Ren <re...@apache.org>
> > > wrote:
> > > >>>>
> > > >>>> +1 (binding)
> > > >>>>
> > > >>>> - Verified signature and checksum
> > > >>>> - Verified that no binary exists in the source archive
> > > >>>> - Built from source with Java 8 using -Dflink.version=1.18
> > > >>>> - Started a local Flink 1.18 cluster, submitted jobs with SQL
> client
> > > >>>> reading from and writing (with exactly-once) to Kafka 3.2.3
> cluster
> > > >>>> - Nothing suspicious in LICENSE and NOTICE file
> > > >>>> - Reviewed web PR
> > > >>>>
> > > >>>> Thanks for the effort, Gordon!
> > > >>>>
> > > >>>> Best,
> > > >>>> Qingsheng
> > > >>>>
> > > >>>> On Thu, Oct 26, 2023 at 5:13 AM Tzu-Li (Gordon) Tai <
> > > >> tzulitai@apache.org>
> > > >>>> wrote:
> > > >>>>
> > > >>>>> Hi everyone,
> > > >>>>>
> > > >>>>> Please review and vote on release candidate #1 for version 3.0.1
> of
> > > the
> > > >>>>> Apache Flink Kafka Connector, as follows:
> > > >>>>> [ ] +1, Approve the release
> > > >>>>> [ ] -1, Do not approve the release (please provide specific
> > comments)
> > > >>>>>
> > > >>>>> This release contains important changes for the following:
> > > >>>>> - Supports Flink 1.18.x series
> > > >>>>> - [FLINK-28303] EOS violation when using LATEST_OFFSETS startup
> > mode
> > > >>>>> - [FLINK-33231] Memory leak causing OOM when there are no offsets
> > to
> > > >> commit
> > > >>>>> back to Kafka
> > > >>>>> - [FLINK-28758] FlinkKafkaConsumer fails to stop with savepoint
> > > >>>>>
> > > >>>>> The release candidate contains the source release as well as JAR
> > > >> artifacts
> > > >>>>> to be released to Maven, built against Flink 1.17.1 and 1.18.0.
> > > >>>>>
> > > >>>>> The complete staging area is available for your review, which
> > > includes:
> > > >>>>> * JIRA release notes [1],
> > > >>>>> * the official Apache source release to be deployed to
> > > dist.apache.org
> > > >>>>> [2],
> > > >>>>> which are signed with the key with fingerprint
> > > >>>>> 1C1E2394D3194E1944613488F320986D35C33D6A [3],
> > > >>>>> * all artifacts to be deployed to the Maven Central Repository
> [4],
> > > >>>>> * source code tag v3.0.1-rc1 [5],
> > > >>>>> * website pull request listing the new release [6].
> > > >>>>>
> > > >>>>> The vote will be open for at least 72 hours. It is adopted by
> > > majority
> > > >>>>> approval, with at least 3 PMC affirmative votes.
> > > >>>>>
> > > >>>>> Thanks,
> > > >>>>> Gordon
> > > >>>>>
> > > >>>>> [1]
> > > >>>>>
> > > >>>>>
> > > >>
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352910
> > > >>>>> [2]
> > > >>>>>
> > > >>>>>
> > > >>
> > >
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.1-rc1/
> > > >>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > >>>>> [4]
> > > >>
> > https://repository.apache.org/content/repositories/orgapacheflink-1664
> > > >>>>> [5]
> > > https://github.com/apache/flink-connector-kafka/commits/v3.0.1-rc1
> > > >>>>> [6] https://github.com/apache/flink-web/pull/692
> > > >>>>>
> > > >>
> > > >>
> > >
> > >
> >
>
Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1
Posted by Samrat Deb <de...@gmail.com>.
+1 (non-binding)
- Verified signatures
- Verified Checksum
- Build with Java 8 /11 - build success
- Started MSK cluster and EMR cluster with flink, successfully ran some
examples to read and write data to MSK.
- Checked release tag exists
Bests,
Samrat
On Mon, Oct 30, 2023 at 3:47 PM Ahmed Hamdy <ha...@gmail.com> wrote:
> +1 (non-binding)
> - Verified Singatures
> - Verified Checksum
> - Build source successfully
> - Checked release tag exists
> - Reviewed the web PR
> Best Regards
> Ahmed Hamdy
>
>
> On Sun, 29 Oct 2023 at 08:02, Leonard Xu <xb...@gmail.com> wrote:
>
> > +1 (binding)
> >
> > - Verified signatures
> > - Verified hashsums
> > - Checked Github release tag
> > - Built from source code succeeded
> > - Checked release notes
> > - Reviewed the web PR
> >
> > Best,
> > Leonard
> >
> >
> > > 2023年10月29日 上午11:34，mystic lama <my...@gmail.com> 写道：
> > >
> > > +1 (non-binding)
> > >
> > > - verified signatures
> > > - build with Java 8 and Java 11 - build success
> > >
> > > Minor observation
> > > - RAT check flagged that README.md is missing ASL
> > >
> > > On Fri, 27 Oct 2023 at 23:40, Xianxun Ye <ye...@gmail.com>
> > wrote:
> > >
> > >> +1(non-binding)
> > >>
> > >> - Started a local Flink 1.18 cluster, read and wrote with Kafka and
> > Upsert
> > >> Kafka connector successfully to Kafka 2.2 cluster
> > >>
> > >> One minor question: should we update the dependency manual of these
> two
> > >> documentations[1][2]?
> > >>
> > >> [1]
> > >>
> >
> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/kafka/#dependencies
> > >> [2]
> > >>
> >
> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/upsert-kafka/#dependencies
> > >>
> > >> Best regards,
> > >> Xianxun
> > >>
> > >>> 2023年10月26日 16:12，Martijn Visser <ma...@apache.org> 写道：
> > >>>
> > >>> +1 (binding)
> > >>>
> > >>> - Validated hashes
> > >>> - Verified signature
> > >>> - Verified that no binaries exist in the source archive
> > >>> - Build the source with Maven via mvn clean install
> > >>> -Pcheck-convergence -Dflink.version=1.18.0
> > >>> - Verified licenses
> > >>> - Verified web PR
> > >>> - Started a cluster and the Flink SQL client, successfully read and
> > >>> wrote with the Kafka connector to Confluent Cloud with AVRO and
> Schema
> > >>> Registry enabled
> > >>>
> > >>> On Thu, Oct 26, 2023 at 5:09 AM Qingsheng Ren <re...@apache.org>
> > wrote:
> > >>>>
> > >>>> +1 (binding)
> > >>>>
> > >>>> - Verified signature and checksum
> > >>>> - Verified that no binary exists in the source archive
> > >>>> - Built from source with Java 8 using -Dflink.version=1.18
> > >>>> - Started a local Flink 1.18 cluster, submitted jobs with SQL client
> > >>>> reading from and writing (with exactly-once) to Kafka 3.2.3 cluster
> > >>>> - Nothing suspicious in LICENSE and NOTICE file
> > >>>> - Reviewed web PR
> > >>>>
> > >>>> Thanks for the effort, Gordon!
> > >>>>
> > >>>> Best,
> > >>>> Qingsheng
> > >>>>
> > >>>> On Thu, Oct 26, 2023 at 5:13 AM Tzu-Li (Gordon) Tai <
> > >> tzulitai@apache.org>
> > >>>> wrote:
> > >>>>
> > >>>>> Hi everyone,
> > >>>>>
> > >>>>> Please review and vote on release candidate #1 for version 3.0.1 of
> > the
> > >>>>> Apache Flink Kafka Connector, as follows:
> > >>>>> [ ] +1, Approve the release
> > >>>>> [ ] -1, Do not approve the release (please provide specific
> comments)
> > >>>>>
> > >>>>> This release contains important changes for the following:
> > >>>>> - Supports Flink 1.18.x series
> > >>>>> - [FLINK-28303] EOS violation when using LATEST_OFFSETS startup
> mode
> > >>>>> - [FLINK-33231] Memory leak causing OOM when there are no offsets
> to
> > >> commit
> > >>>>> back to Kafka
> > >>>>> - [FLINK-28758] FlinkKafkaConsumer fails to stop with savepoint
> > >>>>>
> > >>>>> The release candidate contains the source release as well as JAR
> > >> artifacts
> > >>>>> to be released to Maven, built against Flink 1.17.1 and 1.18.0.
> > >>>>>
> > >>>>> The complete staging area is available for your review, which
> > includes:
> > >>>>> * JIRA release notes [1],
> > >>>>> * the official Apache source release to be deployed to
> > dist.apache.org
> > >>>>> [2],
> > >>>>> which are signed with the key with fingerprint
> > >>>>> 1C1E2394D3194E1944613488F320986D35C33D6A [3],
> > >>>>> * all artifacts to be deployed to the Maven Central Repository [4],
> > >>>>> * source code tag v3.0.1-rc1 [5],
> > >>>>> * website pull request listing the new release [6].
> > >>>>>
> > >>>>> The vote will be open for at least 72 hours. It is adopted by
> > majority
> > >>>>> approval, with at least 3 PMC affirmative votes.
> > >>>>>
> > >>>>> Thanks,
> > >>>>> Gordon
> > >>>>>
> > >>>>> [1]
> > >>>>>
> > >>>>>
> > >>
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352910
> > >>>>> [2]
> > >>>>>
> > >>>>>
> > >>
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.1-rc1/
> > >>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > >>>>> [4]
> > >>
> https://repository.apache.org/content/repositories/orgapacheflink-1664
> > >>>>> [5]
> > https://github.com/apache/flink-connector-kafka/commits/v3.0.1-rc1
> > >>>>> [6] https://github.com/apache/flink-web/pull/692
> > >>>>>
> > >>
> > >>
> >
> >
>
Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1
Posted by Ahmed Hamdy <ha...@gmail.com>.
+1 (non-binding)
- Verified Singatures
- Verified Checksum
- Build source successfully
- Checked release tag exists
- Reviewed the web PR
Best Regards
Ahmed Hamdy
On Sun, 29 Oct 2023 at 08:02, Leonard Xu <xb...@gmail.com> wrote:
> +1 (binding)
>
> - Verified signatures
> - Verified hashsums
> - Checked Github release tag
> - Built from source code succeeded
> - Checked release notes
> - Reviewed the web PR
>
> Best,
> Leonard
>
>
> > 2023年10月29日 上午11:34，mystic lama <my...@gmail.com> 写道：
> >
> > +1 (non-binding)
> >
> > - verified signatures
> > - build with Java 8 and Java 11 - build success
> >
> > Minor observation
> > - RAT check flagged that README.md is missing ASL
> >
> > On Fri, 27 Oct 2023 at 23:40, Xianxun Ye <ye...@gmail.com>
> wrote:
> >
> >> +1(non-binding)
> >>
> >> - Started a local Flink 1.18 cluster, read and wrote with Kafka and
> Upsert
> >> Kafka connector successfully to Kafka 2.2 cluster
> >>
> >> One minor question: should we update the dependency manual of these two
> >> documentations[1][2]?
> >>
> >> [1]
> >>
> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/kafka/#dependencies
> >> [2]
> >>
> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/upsert-kafka/#dependencies
> >>
> >> Best regards,
> >> Xianxun
> >>
> >>> 2023年10月26日 16:12，Martijn Visser <ma...@apache.org> 写道：
> >>>
> >>> +1 (binding)
> >>>
> >>> - Validated hashes
> >>> - Verified signature
> >>> - Verified that no binaries exist in the source archive
> >>> - Build the source with Maven via mvn clean install
> >>> -Pcheck-convergence -Dflink.version=1.18.0
> >>> - Verified licenses
> >>> - Verified web PR
> >>> - Started a cluster and the Flink SQL client, successfully read and
> >>> wrote with the Kafka connector to Confluent Cloud with AVRO and Schema
> >>> Registry enabled
> >>>
> >>> On Thu, Oct 26, 2023 at 5:09 AM Qingsheng Ren <re...@apache.org>
> wrote:
> >>>>
> >>>> +1 (binding)
> >>>>
> >>>> - Verified signature and checksum
> >>>> - Verified that no binary exists in the source archive
> >>>> - Built from source with Java 8 using -Dflink.version=1.18
> >>>> - Started a local Flink 1.18 cluster, submitted jobs with SQL client
> >>>> reading from and writing (with exactly-once) to Kafka 3.2.3 cluster
> >>>> - Nothing suspicious in LICENSE and NOTICE file
> >>>> - Reviewed web PR
> >>>>
> >>>> Thanks for the effort, Gordon!
> >>>>
> >>>> Best,
> >>>> Qingsheng
> >>>>
> >>>> On Thu, Oct 26, 2023 at 5:13 AM Tzu-Li (Gordon) Tai <
> >> tzulitai@apache.org>
> >>>> wrote:
> >>>>
> >>>>> Hi everyone,
> >>>>>
> >>>>> Please review and vote on release candidate #1 for version 3.0.1 of
> the
> >>>>> Apache Flink Kafka Connector, as follows:
> >>>>> [ ] +1, Approve the release
> >>>>> [ ] -1, Do not approve the release (please provide specific comments)
> >>>>>
> >>>>> This release contains important changes for the following:
> >>>>> - Supports Flink 1.18.x series
> >>>>> - [FLINK-28303] EOS violation when using LATEST_OFFSETS startup mode
> >>>>> - [FLINK-33231] Memory leak causing OOM when there are no offsets to
> >> commit
> >>>>> back to Kafka
> >>>>> - [FLINK-28758] FlinkKafkaConsumer fails to stop with savepoint
> >>>>>
> >>>>> The release candidate contains the source release as well as JAR
> >> artifacts
> >>>>> to be released to Maven, built against Flink 1.17.1 and 1.18.0.
> >>>>>
> >>>>> The complete staging area is available for your review, which
> includes:
> >>>>> * JIRA release notes [1],
> >>>>> * the official Apache source release to be deployed to
> dist.apache.org
> >>>>> [2],
> >>>>> which are signed with the key with fingerprint
> >>>>> 1C1E2394D3194E1944613488F320986D35C33D6A [3],
> >>>>> * all artifacts to be deployed to the Maven Central Repository [4],
> >>>>> * source code tag v3.0.1-rc1 [5],
> >>>>> * website pull request listing the new release [6].
> >>>>>
> >>>>> The vote will be open for at least 72 hours. It is adopted by
> majority
> >>>>> approval, with at least 3 PMC affirmative votes.
> >>>>>
> >>>>> Thanks,
> >>>>> Gordon
> >>>>>
> >>>>> [1]
> >>>>>
> >>>>>
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352910
> >>>>> [2]
> >>>>>
> >>>>>
> >>
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.1-rc1/
> >>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> >>>>> [4]
> >> https://repository.apache.org/content/repositories/orgapacheflink-1664
> >>>>> [5]
> https://github.com/apache/flink-connector-kafka/commits/v3.0.1-rc1
> >>>>> [6] https://github.com/apache/flink-web/pull/692
> >>>>>
> >>
> >>
>
>
Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1
Posted by Leonard Xu <xb...@gmail.com>.
+1 (binding)
- Verified signatures
- Verified hashsums
- Checked Github release tag
- Built from source code succeeded
- Checked release notes
- Reviewed the web PR
Best,
Leonard
> 2023年10月29日 上午11:34，mystic lama <my...@gmail.com> 写道：
>
> +1 (non-binding)
>
> - verified signatures
> - build with Java 8 and Java 11 - build success
>
> Minor observation
> - RAT check flagged that README.md is missing ASL
>
> On Fri, 27 Oct 2023 at 23:40, Xianxun Ye <ye...@gmail.com> wrote:
>
>> +1(non-binding)
>>
>> - Started a local Flink 1.18 cluster, read and wrote with Kafka and Upsert
>> Kafka connector successfully to Kafka 2.2 cluster
>>
>> One minor question: should we update the dependency manual of these two
>> documentations[1][2]?
>>
>> [1]
>> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/kafka/#dependencies
>> [2]
>> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/upsert-kafka/#dependencies
>>
>> Best regards,
>> Xianxun
>>
>>> 2023年10月26日 16:12，Martijn Visser <ma...@apache.org> 写道：
>>>
>>> +1 (binding)
>>>
>>> - Validated hashes
>>> - Verified signature
>>> - Verified that no binaries exist in the source archive
>>> - Build the source with Maven via mvn clean install
>>> -Pcheck-convergence -Dflink.version=1.18.0
>>> - Verified licenses
>>> - Verified web PR
>>> - Started a cluster and the Flink SQL client, successfully read and
>>> wrote with the Kafka connector to Confluent Cloud with AVRO and Schema
>>> Registry enabled
>>>
>>> On Thu, Oct 26, 2023 at 5:09 AM Qingsheng Ren <re...@apache.org> wrote:
>>>>
>>>> +1 (binding)
>>>>
>>>> - Verified signature and checksum
>>>> - Verified that no binary exists in the source archive
>>>> - Built from source with Java 8 using -Dflink.version=1.18
>>>> - Started a local Flink 1.18 cluster, submitted jobs with SQL client
>>>> reading from and writing (with exactly-once) to Kafka 3.2.3 cluster
>>>> - Nothing suspicious in LICENSE and NOTICE file
>>>> - Reviewed web PR
>>>>
>>>> Thanks for the effort, Gordon!
>>>>
>>>> Best,
>>>> Qingsheng
>>>>
>>>> On Thu, Oct 26, 2023 at 5:13 AM Tzu-Li (Gordon) Tai <
>> tzulitai@apache.org>
>>>> wrote:
>>>>
>>>>> Hi everyone,
>>>>>
>>>>> Please review and vote on release candidate #1 for version 3.0.1 of the
>>>>> Apache Flink Kafka Connector, as follows:
>>>>> [ ] +1, Approve the release
>>>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>>>
>>>>> This release contains important changes for the following:
>>>>> - Supports Flink 1.18.x series
>>>>> - [FLINK-28303] EOS violation when using LATEST_OFFSETS startup mode
>>>>> - [FLINK-33231] Memory leak causing OOM when there are no offsets to
>> commit
>>>>> back to Kafka
>>>>> - [FLINK-28758] FlinkKafkaConsumer fails to stop with savepoint
>>>>>
>>>>> The release candidate contains the source release as well as JAR
>> artifacts
>>>>> to be released to Maven, built against Flink 1.17.1 and 1.18.0.
>>>>>
>>>>> The complete staging area is available for your review, which includes:
>>>>> * JIRA release notes [1],
>>>>> * the official Apache source release to be deployed to dist.apache.org
>>>>> [2],
>>>>> which are signed with the key with fingerprint
>>>>> 1C1E2394D3194E1944613488F320986D35C33D6A [3],
>>>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>>>> * source code tag v3.0.1-rc1 [5],
>>>>> * website pull request listing the new release [6].
>>>>>
>>>>> The vote will be open for at least 72 hours. It is adopted by majority
>>>>> approval, with at least 3 PMC affirmative votes.
>>>>>
>>>>> Thanks,
>>>>> Gordon
>>>>>
>>>>> [1]
>>>>>
>>>>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352910
>>>>> [2]
>>>>>
>>>>>
>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.1-rc1/
>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>>>> [4]
>> https://repository.apache.org/content/repositories/orgapacheflink-1664
>>>>> [5] https://github.com/apache/flink-connector-kafka/commits/v3.0.1-rc1
>>>>> [6] https://github.com/apache/flink-web/pull/692
>>>>>
>>
>>
Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1
Posted by mystic lama <my...@gmail.com>.
+1 (non-binding)
- verified signatures
- build with Java 8 and Java 11 - build success
Minor observation
- RAT check flagged that README.md is missing ASL
On Fri, 27 Oct 2023 at 23:40, Xianxun Ye <ye...@gmail.com> wrote:
> +1(non-binding)
>
> - Started a local Flink 1.18 cluster, read and wrote with Kafka and Upsert
> Kafka connector successfully to Kafka 2.2 cluster
>
> One minor question: should we update the dependency manual of these two
> documentations[1][2]?
>
> [1]
> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/kafka/#dependencies
> [2]
> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/upsert-kafka/#dependencies
>
> Best regards,
> Xianxun
>
> > 2023年10月26日 16:12，Martijn Visser <ma...@apache.org> 写道：
> >
> > +1 (binding)
> >
> > - Validated hashes
> > - Verified signature
> > - Verified that no binaries exist in the source archive
> > - Build the source with Maven via mvn clean install
> > -Pcheck-convergence -Dflink.version=1.18.0
> > - Verified licenses
> > - Verified web PR
> > - Started a cluster and the Flink SQL client, successfully read and
> > wrote with the Kafka connector to Confluent Cloud with AVRO and Schema
> > Registry enabled
> >
> > On Thu, Oct 26, 2023 at 5:09 AM Qingsheng Ren <re...@apache.org> wrote:
> >>
> >> +1 (binding)
> >>
> >> - Verified signature and checksum
> >> - Verified that no binary exists in the source archive
> >> - Built from source with Java 8 using -Dflink.version=1.18
> >> - Started a local Flink 1.18 cluster, submitted jobs with SQL client
> >> reading from and writing (with exactly-once) to Kafka 3.2.3 cluster
> >> - Nothing suspicious in LICENSE and NOTICE file
> >> - Reviewed web PR
> >>
> >> Thanks for the effort, Gordon!
> >>
> >> Best,
> >> Qingsheng
> >>
> >> On Thu, Oct 26, 2023 at 5:13 AM Tzu-Li (Gordon) Tai <
> tzulitai@apache.org>
> >> wrote:
> >>
> >>> Hi everyone,
> >>>
> >>> Please review and vote on release candidate #1 for version 3.0.1 of the
> >>> Apache Flink Kafka Connector, as follows:
> >>> [ ] +1, Approve the release
> >>> [ ] -1, Do not approve the release (please provide specific comments)
> >>>
> >>> This release contains important changes for the following:
> >>> - Supports Flink 1.18.x series
> >>> - [FLINK-28303] EOS violation when using LATEST_OFFSETS startup mode
> >>> - [FLINK-33231] Memory leak causing OOM when there are no offsets to
> commit
> >>> back to Kafka
> >>> - [FLINK-28758] FlinkKafkaConsumer fails to stop with savepoint
> >>>
> >>> The release candidate contains the source release as well as JAR
> artifacts
> >>> to be released to Maven, built against Flink 1.17.1 and 1.18.0.
> >>>
> >>> The complete staging area is available for your review, which includes:
> >>> * JIRA release notes [1],
> >>> * the official Apache source release to be deployed to dist.apache.org
> >>> [2],
> >>> which are signed with the key with fingerprint
> >>> 1C1E2394D3194E1944613488F320986D35C33D6A [3],
> >>> * all artifacts to be deployed to the Maven Central Repository [4],
> >>> * source code tag v3.0.1-rc1 [5],
> >>> * website pull request listing the new release [6].
> >>>
> >>> The vote will be open for at least 72 hours. It is adopted by majority
> >>> approval, with at least 3 PMC affirmative votes.
> >>>
> >>> Thanks,
> >>> Gordon
> >>>
> >>> [1]
> >>>
> >>>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352910
> >>> [2]
> >>>
> >>>
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.1-rc1/
> >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> >>> [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1664
> >>> [5] https://github.com/apache/flink-connector-kafka/commits/v3.0.1-rc1
> >>> [6] https://github.com/apache/flink-web/pull/692
> >>>
>
>
Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1
Posted by Xianxun Ye <ye...@gmail.com>.
+1(non-binding)
- Started a local Flink 1.18 cluster, read and wrote with Kafka and Upsert Kafka connector successfully to Kafka 2.2 cluster
One minor question: should we update the dependency manual of these two documentations[1][2]?
[1] https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/kafka/#dependencies
[2] https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/upsert-kafka/#dependencies
Best regards,
Xianxun
> 2023年10月26日 16:12，Martijn Visser <ma...@apache.org> 写道：
>
> +1 (binding)
>
> - Validated hashes
> - Verified signature
> - Verified that no binaries exist in the source archive
> - Build the source with Maven via mvn clean install
> -Pcheck-convergence -Dflink.version=1.18.0
> - Verified licenses
> - Verified web PR
> - Started a cluster and the Flink SQL client, successfully read and
> wrote with the Kafka connector to Confluent Cloud with AVRO and Schema
> Registry enabled
>
> On Thu, Oct 26, 2023 at 5:09 AM Qingsheng Ren <re...@apache.org> wrote:
>>
>> +1 (binding)
>>
>> - Verified signature and checksum
>> - Verified that no binary exists in the source archive
>> - Built from source with Java 8 using -Dflink.version=1.18
>> - Started a local Flink 1.18 cluster, submitted jobs with SQL client
>> reading from and writing (with exactly-once) to Kafka 3.2.3 cluster
>> - Nothing suspicious in LICENSE and NOTICE file
>> - Reviewed web PR
>>
>> Thanks for the effort, Gordon!
>>
>> Best,
>> Qingsheng
>>
>> On Thu, Oct 26, 2023 at 5:13 AM Tzu-Li (Gordon) Tai <tz...@apache.org>
>> wrote:
>>
>>> Hi everyone,
>>>
>>> Please review and vote on release candidate #1 for version 3.0.1 of the
>>> Apache Flink Kafka Connector, as follows:
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>
>>> This release contains important changes for the following:
>>> - Supports Flink 1.18.x series
>>> - [FLINK-28303] EOS violation when using LATEST_OFFSETS startup mode
>>> - [FLINK-33231] Memory leak causing OOM when there are no offsets to commit
>>> back to Kafka
>>> - [FLINK-28758] FlinkKafkaConsumer fails to stop with savepoint
>>>
>>> The release candidate contains the source release as well as JAR artifacts
>>> to be released to Maven, built against Flink 1.17.1 and 1.18.0.
>>>
>>> The complete staging area is available for your review, which includes:
>>> * JIRA release notes [1],
>>> * the official Apache source release to be deployed to dist.apache.org
>>> [2],
>>> which are signed with the key with fingerprint
>>> 1C1E2394D3194E1944613488F320986D35C33D6A [3],
>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>> * source code tag v3.0.1-rc1 [5],
>>> * website pull request listing the new release [6].
>>>
>>> The vote will be open for at least 72 hours. It is adopted by majority
>>> approval, with at least 3 PMC affirmative votes.
>>>
>>> Thanks,
>>> Gordon
>>>
>>> [1]
>>>
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352910
>>> [2]
>>>
>>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.1-rc1/
>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>> [4] https://repository.apache.org/content/repositories/orgapacheflink-1664
>>> [5] https://github.com/apache/flink-connector-kafka/commits/v3.0.1-rc1
>>> [6] https://github.com/apache/flink-web/pull/692
>>>
Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1
Posted by Martijn Visser <ma...@apache.org>.
+1 (binding)
- Validated hashes
- Verified signature
- Verified that no binaries exist in the source archive
- Build the source with Maven via mvn clean install
-Pcheck-convergence -Dflink.version=1.18.0
- Verified licenses
- Verified web PR
- Started a cluster and the Flink SQL client, successfully read and
wrote with the Kafka connector to Confluent Cloud with AVRO and Schema
Registry enabled
On Thu, Oct 26, 2023 at 5:09 AM Qingsheng Ren <re...@apache.org> wrote:
>
> +1 (binding)
>
> - Verified signature and checksum
> - Verified that no binary exists in the source archive
> - Built from source with Java 8 using -Dflink.version=1.18
> - Started a local Flink 1.18 cluster, submitted jobs with SQL client
> reading from and writing (with exactly-once) to Kafka 3.2.3 cluster
> - Nothing suspicious in LICENSE and NOTICE file
> - Reviewed web PR
>
> Thanks for the effort, Gordon!
>
> Best,
> Qingsheng
>
> On Thu, Oct 26, 2023 at 5:13 AM Tzu-Li (Gordon) Tai <tz...@apache.org>
> wrote:
>
> > Hi everyone,
> >
> > Please review and vote on release candidate #1 for version 3.0.1 of the
> > Apache Flink Kafka Connector, as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > This release contains important changes for the following:
> > - Supports Flink 1.18.x series
> > - [FLINK-28303] EOS violation when using LATEST_OFFSETS startup mode
> > - [FLINK-33231] Memory leak causing OOM when there are no offsets to commit
> > back to Kafka
> > - [FLINK-28758] FlinkKafkaConsumer fails to stop with savepoint
> >
> > The release candidate contains the source release as well as JAR artifacts
> > to be released to Maven, built against Flink 1.17.1 and 1.18.0.
> >
> > The complete staging area is available for your review, which includes:
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to dist.apache.org
> > [2],
> > which are signed with the key with fingerprint
> > 1C1E2394D3194E1944613488F320986D35C33D6A [3],
> > * all artifacts to be deployed to the Maven Central Repository [4],
> > * source code tag v3.0.1-rc1 [5],
> > * website pull request listing the new release [6].
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Gordon
> >
> > [1]
> >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352910
> > [2]
> >
> > https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.1-rc1/
> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [4] https://repository.apache.org/content/repositories/orgapacheflink-1664
> > [5] https://github.com/apache/flink-connector-kafka/commits/v3.0.1-rc1
> > [6] https://github.com/apache/flink-web/pull/692
> >
Re: [VOTE] Apache Flink Kafka connector version 3.0.1, RC1
Posted by Qingsheng Ren <re...@apache.org>.
+1 (binding)
- Verified signature and checksum
- Verified that no binary exists in the source archive
- Built from source with Java 8 using -Dflink.version=1.18
- Started a local Flink 1.18 cluster, submitted jobs with SQL client
reading from and writing (with exactly-once) to Kafka 3.2.3 cluster
- Nothing suspicious in LICENSE and NOTICE file
- Reviewed web PR
Thanks for the effort, Gordon!
Best,
Qingsheng
On Thu, Oct 26, 2023 at 5:13 AM Tzu-Li (Gordon) Tai <tz...@apache.org>
wrote:
> Hi everyone,
>
> Please review and vote on release candidate #1 for version 3.0.1 of the
> Apache Flink Kafka Connector, as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> This release contains important changes for the following:
> - Supports Flink 1.18.x series
> - [FLINK-28303] EOS violation when using LATEST_OFFSETS startup mode
> - [FLINK-33231] Memory leak causing OOM when there are no offsets to commit
> back to Kafka
> - [FLINK-28758] FlinkKafkaConsumer fails to stop with savepoint
>
> The release candidate contains the source release as well as JAR artifacts
> to be released to Maven, built against Flink 1.17.1 and 1.18.0.
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2],
> which are signed with the key with fingerprint
> 1C1E2394D3194E1944613488F320986D35C33D6A [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag v3.0.1-rc1 [5],
> * website pull request listing the new release [6].
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Gordon
>
> [1]
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352910
> [2]
>
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.1-rc1/
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/orgapacheflink-1664
> [5] https://github.com/apache/flink-connector-kafka/commits/v3.0.1-rc1
> [6] https://github.com/apache/flink-web/pull/692
>