You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/10 19:29:15 UTC
[GitHub] [incubator-nuttx] raiden00pl opened a new pull request #3508: stm32: enable FOC support for STM32F1 and add FOC example for nucleo-f103rb
raiden00pl opened a new pull request #3508:
URL: https://github.com/apache/incubator-nuttx/pull/3508
## Summary
- nucleo-f103rb: refactor bringup logic for consistency with other boards
- arch/arm/src/stm32/stm32_adc.c: support adc_inj_startconv also for STM32F1
- arch/arm/src/stm32: introduce DBGMCU IP core versions
- arch/arm/src/stm32/stm32_foc.c: add modifications to support STM32F1
- nucleo-f103rb: add FOC example based on IHM07M1 expansion board (only fixed16)
## Impact
## Testing
Tested with added configuration (nucleo-f103rb/ihm07m1_b16)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl commented on a change in pull request #3508: stm32: enable FOC support for STM32F1 and add FOC example for nucleo-f103rb
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on a change in pull request #3508:
URL: https://github.com/apache/incubator-nuttx/pull/3508#discussion_r611152218
##########
File path: boards/arm/stm32/nucleo-f103rb/src/stm32_appinit.c
##########
@@ -24,27 +24,16 @@
#include <nuttx/config.h>
-#include <sys/types.h>
-#include <syslog.h>
-
#include <nuttx/board.h>
-#include <nuttx/leds/userled.h>
#include "nucleo-f103rb.h"
/****************************************************************************
* Pre-processor Definitions
****************************************************************************/
-#undef HAVE_LEDS
-#undef HAVE_DAC
-
-#if !defined(CONFIG_ARCH_LEDS) && defined(CONFIG_USERLED_LOWER)
-# define HAVE_LEDS 1
-#endif
-
-#if defined(CONFIG_DAC)
-# define HAVE_DAC 1
+#ifndef OK
Review comment:
It is a copy-paste from nucleo-f302r8. I'm not sure what story is behind it, but this is present in many boards. Probably some configuration options re-define OK for xxx_appinit.c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3508: stm32: enable FOC support for STM32F1 and add FOC example for nucleo-f103rb
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3508:
URL: https://github.com/apache/incubator-nuttx/pull/3508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3508: stm32: enable FOC support for STM32F1 and add FOC example for nucleo-f103rb
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #3508:
URL: https://github.com/apache/incubator-nuttx/pull/3508#discussion_r611091177
##########
File path: boards/arm/stm32/nucleo-f103rb/src/stm32_appinit.c
##########
@@ -24,27 +24,16 @@
#include <nuttx/config.h>
-#include <sys/types.h>
-#include <syslog.h>
-
#include <nuttx/board.h>
-#include <nuttx/leds/userled.h>
#include "nucleo-f103rb.h"
/****************************************************************************
* Pre-processor Definitions
****************************************************************************/
-#undef HAVE_LEDS
-#undef HAVE_DAC
-
-#if !defined(CONFIG_ARCH_LEDS) && defined(CONFIG_USERLED_LOWER)
-# define HAVE_LEDS 1
-#endif
-
-#if defined(CONFIG_DAC)
-# define HAVE_DAC 1
+#ifndef OK
Review comment:
why need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org