[GitHub] WillemJiang commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend

[GitBox <gi...@apache.org>]

WillemJiang commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#discussion_r182010669
 
 

 ##########
 File path: frontend/main.go
 ##########
 @@ -19,34 +19,30 @@ package main
 import (
 	"flag"
 	"fmt"
-	"github.com/apache/incubator-servicecomb-service-center/frontend/schema"
+
 	"github.com/astaxie/beego"
-	"log"
-	"net/http"
-	//"strconv"
 )
 
+type Config struct {
+	frontendAddr string
+	scAddr       string
+}
+
 func main() {
 	frontendIp := beego.AppConfig.String("frontend_host_ip")
 	frontendPort := beego.AppConfig.DefaultInt("frontend_host_port", 30103)
 
+	scIp := beego.AppConfig.DefaultString("httpadr", "127.0.0.1")
 
 Review comment:
   I don't think "httpadr" and "httpport" are good names here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services