You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2020/04/08 04:49:45 UTC
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15676
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Ported BlockBloomFilter related source files from Kudu upstream
to Impala be/src/kudu/util.
Testing:
Passed core tests.
Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
---
M be/src/kudu/util/CMakeLists.txt
M be/src/kudu/util/block_bloom_filter-test.cc
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
A be/src/kudu/util/block_bloom_filter.proto
M be/src/kudu/util/block_bloom_filter_avx2.cc
M be/src/kudu/util/hash.proto
M be/src/kudu/util/hash_util-test.cc
M be/src/kudu/util/hash_util.h
M be/src/kudu/util/random.h
M be/src/kudu/util/random_util-test.cc
M be/src/kudu/util/random_util.h
12 files changed, 732 insertions(+), 62 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/15676/1
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Ported BlockBloomFilter related source files from Kudu upstream
to Impala be/src/kudu/util. The git hash of Kudu to take these
files is 389d4f1e1c.
Testing:
Passed core tests.
Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
---
M be/src/kudu/util/CMakeLists.txt
M be/src/kudu/util/block_bloom_filter-test.cc
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
A be/src/kudu/util/block_bloom_filter.proto
M be/src/kudu/util/block_bloom_filter_avx2.cc
M be/src/kudu/util/hash.proto
M be/src/kudu/util/hash_util-test.cc
M be/src/kudu/util/hash_util.h
M be/src/kudu/util/memory/arena-test.cc
M be/src/kudu/util/memory/arena.cc
M be/src/kudu/util/memory/arena.h
12 files changed, 785 insertions(+), 101 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/15676/7
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 7
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5885/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Apr 2020 16:58:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 10:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6057/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 10
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2020 07:12:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5921/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 May 2020 00:15:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5996/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 7
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 19:45:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Ported BlockBloomFilter related source files from Kudu upstream
to Impala be/src/kudu/util.
Testing:
Passed core tests.
Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
---
M be/src/kudu/util/CMakeLists.txt
M be/src/kudu/util/block_bloom_filter-test.cc
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
A be/src/kudu/util/block_bloom_filter.proto
M be/src/kudu/util/block_bloom_filter_avx2.cc
M be/src/kudu/util/hash.proto
M be/src/kudu/util/hash_util-test.cc
M be/src/kudu/util/hash_util.h
M be/src/kudu/util/memory/arena-test.cc
M be/src/kudu/util/memory/arena.cc
M be/src/kudu/util/memory/arena.h
12 files changed, 785 insertions(+), 101 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/15676/4
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 11:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6063/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 11
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2020 17:26:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5834/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 12
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2020 20:39:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5747/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Apr 2020 05:30:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 12: Code-Review+2
Merge failed due to IMPALA-8124
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 12
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2020 17:02:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 13:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5847/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 13
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2020 17:02:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 8
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 19:46:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Ported BlockBloomFilter related source files from Kudu upstream
to Impala be/src/kudu/util. The git hash of Kudu to take these
files is 389d4f1e1c.
Testing:
Passed core tests.
Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Reviewed-on: http://gerrit.cloudera.org:8080/15676
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/kudu/util/CMakeLists.txt
M be/src/kudu/util/block_bloom_filter-test.cc
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
A be/src/kudu/util/block_bloom_filter.proto
M be/src/kudu/util/block_bloom_filter_avx2.cc
M be/src/kudu/util/hash.proto
M be/src/kudu/util/hash_util-test.cc
M be/src/kudu/util/hash_util.h
M be/src/kudu/util/memory/arena-test.cc
M be/src/kudu/util/memory/arena.cc
M be/src/kudu/util/memory/arena.h
12 files changed, 785 insertions(+), 101 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 14
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 12:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6065/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 12
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2020 19:41:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 8: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5794/
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 8
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 May 2020 01:04:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Ported BlockBloomFilter related source files from Kudu upstream
to Impala be/src/kudu/util.
Testing:
Passed core tests.
Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
---
M be/src/kudu/util/CMakeLists.txt
M be/src/kudu/util/block_bloom_filter-test.cc
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
A be/src/kudu/util/block_bloom_filter.proto
M be/src/kudu/util/block_bloom_filter_avx2.cc
M be/src/kudu/util/hash.proto
M be/src/kudu/util/hash_util-test.cc
M be/src/kudu/util/hash_util.h
M be/src/kudu/util/memory/arena-test.cc
M be/src/kudu/util/memory/arena.cc
M be/src/kudu/util/memory/arena.h
M bin/impala-config.sh
13 files changed, 787 insertions(+), 103 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/15676/3
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 3:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/5903/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Apr 2020 01:06:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Ported BlockBloomFilter related source files from Kudu upstream
to Impala be/src/kudu/util.
Testing:
Passed core tests.
Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
---
M be/src/kudu/util/CMakeLists.txt
M be/src/kudu/util/block_bloom_filter-test.cc
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
A be/src/kudu/util/block_bloom_filter.proto
M be/src/kudu/util/block_bloom_filter_avx2.cc
M be/src/kudu/util/hash.proto
M be/src/kudu/util/hash_util-test.cc
M be/src/kudu/util/hash_util.h
M be/src/kudu/util/memory/arena-test.cc
M be/src/kudu/util/memory/arena.cc
M be/src/kudu/util/memory/arena.h
12 files changed, 785 insertions(+), 101 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/15676/11
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 11
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Ported BlockBloomFilter related source files from Kudu upstream
to Impala be/src/kudu/util. The git hash of Kudu to take these
files is 389d4f1e1c.
Testing:
Passed core tests.
Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
---
M be/src/kudu/util/CMakeLists.txt
M be/src/kudu/util/block_bloom_filter-test.cc
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
A be/src/kudu/util/block_bloom_filter.proto
M be/src/kudu/util/block_bloom_filter_avx2.cc
M be/src/kudu/util/hash.proto
M be/src/kudu/util/hash_util-test.cc
M be/src/kudu/util/hash_util.h
M be/src/kudu/util/memory/arena-test.cc
M be/src/kudu/util/memory/arena.cc
M be/src/kudu/util/memory/arena.h
12 files changed, 785 insertions(+), 101 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/15676/10
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 10
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 13: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 13
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2020 17:02:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5794/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 8
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 19:46:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 8:
The Kudu bloom filter here was actually copied from Impala - https://github.com/apache/kudu/commit/e671e81ce170c4595fed497a5a518a50eb700b69#diff-7cf847a66bbf0a8a603f35c0c03129fe
Should we meld them rather than having two copies of the algorithm within the Impala code base?
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 8
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 02:55:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 7
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 19:46:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 12: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5834/
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 12
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2020 02:01:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Ported BlockBloomFilter related source files from Kudu upstream
to Impala be/src/kudu/util. The git hash of Kudu to take these
files is 389d4f1e1c.
Testing:
Passed core tests.
Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
---
M be/src/kudu/util/CMakeLists.txt
M be/src/kudu/util/block_bloom_filter-test.cc
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
A be/src/kudu/util/block_bloom_filter.proto
M be/src/kudu/util/block_bloom_filter_avx2.cc
M be/src/kudu/util/hash.proto
M be/src/kudu/util/hash_util-test.cc
M be/src/kudu/util/hash_util.h
M be/src/kudu/util/memory/arena-test.cc
M be/src/kudu/util/memory/arena.cc
M be/src/kudu/util/memory/arena.h
12 files changed, 785 insertions(+), 101 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/15676/12
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 12
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 1:
Wouldn't Impala import entire kudu-util instead of parts of it?
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Apr 2020 15:39:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
Patch Set 13: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 13
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2020 22:25:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15676 )
Change subject: IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
......................................................................
IMPALA-3741 [part 1]: Upgraded kudu/util for BloomFilter
Ported BlockBloomFilter related source files from Kudu upstream
to Impala be/src/kudu/util.
Testing:
Passed core tests.
Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
---
M be/src/kudu/util/CMakeLists.txt
M be/src/kudu/util/block_bloom_filter-test.cc
M be/src/kudu/util/block_bloom_filter.cc
M be/src/kudu/util/block_bloom_filter.h
A be/src/kudu/util/block_bloom_filter.proto
M be/src/kudu/util/block_bloom_filter_avx2.cc
M be/src/kudu/util/hash.proto
M be/src/kudu/util/hash_util-test.cc
M be/src/kudu/util/hash_util.h
M be/src/kudu/util/memory/arena-test.cc
M be/src/kudu/util/memory/arena.cc
M be/src/kudu/util/memory/arena.h
12 files changed, 785 insertions(+), 101 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/15676/2
--
To view, visit http://gerrit.cloudera.org:8080/15676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifac41ffb3e1742ffb6a969cb1c368d6d93c23357
Gerrit-Change-Number: 15676
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>