You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "XComp (via GitHub)" <gi...@apache.org> on 2023/03/23 11:44:17 UTC
[GitHub] [flink-docker] XComp opened a new pull request, #153: [FLINK-31566][docker] Removes 1.15 and adds 1.17 Dockerfiles
XComp opened a new pull request, #153:
URL: https://github.com/apache/flink-docker/pull/153
This also includes some minor documentation fixes where I removed steps that are not necessary anymore (see the commit message for the reasoning)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-docker] PatrickRen commented on a diff in pull request #153: [FLINK-31566][docker] Removes 1.15 and adds 1.17 Dockerfiles
Posted by "PatrickRen (via GitHub)" <gi...@apache.org>.
PatrickRen commented on code in PR #153:
URL: https://github.com/apache/flink-docker/pull/153#discussion_r1146445138
##########
.github/workflows/snapshot.yml:
##########
@@ -38,12 +38,12 @@ jobs:
matrix:
java_version: [8, 11]
build:
- - flink_version: 1.17-SNAPSHOT
+ - flink_version: 1.18-SNAPSHOT
branch: dev-master
+ - flink_version: 1.17-SNAPSHOT
+ branch: dev-1.17
- flink_version: 1.16-SNAPSHOT
branch: dev-1.16
- - flink_version: 1.15-SNAPSHOT
Review Comment:
According to the discussion we still need to release 1.15.5 as the final flushing version. Then I think 1.15 related contents should be kept until the final 1.15.5 is released. Otherwise we will never be able to release the 1.15.5 to the docker-library/official-images repo, as a new release requires to point to a commit on master.
IIUC the workflow handling an end-of-support version (let say 1.15 here) would be:
- We keep 1.15 related contents on master
- Once the final version 1.15.5 is ready, release the Docker image following the guide in README.md
- Remove 1.15 related contents from master after 1.15.5 is successfully published to Docker official
- Remove 1.15 related contents from [library/flink](https://github.com/docker-library/official-images/blob/master/library/flink) in official-images repo
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-docker] XComp commented on pull request #153: [FLINK-31566][docker] Removes 1.15 and adds 1.17 Dockerfiles
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #153:
URL: https://github.com/apache/flink-docker/pull/153#issuecomment-1481101176
I needed to do a force-push because I wanted to update the commit message for the commit that added the 1.17.0 Dockerimages to comply with the README.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-docker] XComp commented on a diff in pull request #153: [FLINK-31566][docker] Removes 1.15 and adds 1.17 Dockerfiles
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #153:
URL: https://github.com/apache/flink-docker/pull/153#discussion_r1146466366
##########
.github/workflows/snapshot.yml:
##########
@@ -38,12 +38,12 @@ jobs:
matrix:
java_version: [8, 11]
build:
- - flink_version: 1.17-SNAPSHOT
+ - flink_version: 1.18-SNAPSHOT
branch: dev-master
+ - flink_version: 1.17-SNAPSHOT
+ branch: dev-1.17
- flink_version: 1.16-SNAPSHOT
branch: dev-1.16
- - flink_version: 1.15-SNAPSHOT
Review Comment:
Initially, I had the concern that we would miss deleting it if the community decide that they don't want another patch release for the deprecated minor version (for the current release I mean 1.15.5). But you're right - in the worst case we delete it later on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-docker] XComp commented on pull request #153: [FLINK-31566][docker] Removes 1.15 and adds 1.17 Dockerfiles
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #153:
URL: https://github.com/apache/flink-docker/pull/153#issuecomment-1481747319
Thanks for the review, @PatrickRen and @rmetzger . I squashed the changes into meaningful chunks (and left 1.15 data in for now). @rmetzger will pick up the work on FLINK-31566 after the changes are merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-docker] XComp commented on pull request #153: [FLINK-31566][docker] Removes 1.15 and adds 1.17 Dockerfiles
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #153:
URL: https://github.com/apache/flink-docker/pull/153#issuecomment-1481129348
And another force push was necessary because I realized that we had the GHA workflows not covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-docker] XComp commented on a diff in pull request #153: [FLINK-31566][docker] Removes 1.15 and adds 1.17 Dockerfiles
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #153:
URL: https://github.com/apache/flink-docker/pull/153#discussion_r1146142726
##########
.github/workflows/snapshot.yml:
##########
@@ -38,12 +38,12 @@ jobs:
matrix:
java_version: [8, 11]
build:
- - flink_version: 1.17-SNAPSHOT
+ - flink_version: 1.18-SNAPSHOT
branch: dev-master
+ - flink_version: 1.17-SNAPSHOT
+ branch: dev-1.17
- flink_version: 1.16-SNAPSHOT
branch: dev-1.16
- - flink_version: 1.15-SNAPSHOT
Review Comment:
tbh. here I'm not 100% sure considering [the discussion](https://lists.apache.org/thread/szq23kr3rlkm80rw7k9n95js5vqpsnbv) we had about having a final patch version release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-docker] XComp merged pull request #153: [FLINK-31566][docker] Removes 1.15 and adds 1.17 Dockerfiles
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp merged PR #153:
URL: https://github.com/apache/flink-docker/pull/153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org