You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/05 03:45:46 UTC

[GitHub] hequn8128 commented on issue #6987: [FLINK-8897] [table] Fix rowtime materialization issues for filters and joins

hequn8128 commented on issue #6987: [FLINK-8897] [table] Fix rowtime materialization issues for filters and joins
URL: https://github.com/apache/flink/pull/6987#issuecomment-435747112
 
 
   Hi, @twalthr  A neat fix! LGTM.
    
   And thanks for adding the logic that throw an exception in `DataStreamJoinRule` when the rule doesn't match which I think makes the exceptions more friendly to users. How about add similar logic to `DataStreamWindowJoinRule`, i.e, throw an exception when window bound has been defined while contains rowtime field in the output. 
   
   Best, Hequn
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services