You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/09 05:23:15 UTC

[GitHub] [pulsar-client-go] masterclock opened a new issue #506: topic parse error should be checked

masterclock opened a new issue #506:
URL: https://github.com/apache/pulsar-client-go/issues/506


   #### Expected behavior
   `ParseTopicName()` parses topic and its return error should be check, 
   but currently the `err` is just omitted by assigning to _.
   this causes runtime panic.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] wolfstudy commented on issue #506: topic parse error should be checked

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on issue #506:
URL: https://github.com/apache/pulsar-client-go/issues/506#issuecomment-827281148


   @masterclock agree with you, It seems that we can't ignore this error here. It is a better way to handle this error. Are you interested in it? Welcome to send pull request to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] EAHITechnology commented on issue #506: topic parse error should be checked

Posted by GitBox <gi...@apache.org>.
EAHITechnology commented on issue #506:
URL: https://github.com/apache/pulsar-client-go/issues/506#issuecomment-840427245


   > #### Expected behavior
   > `ParseTopicName()` parses topic and its return error should be check,
   > but currently the `err` is just omitted by assigning to _.
   > this causes runtime panic.
   
   Can you point out the context


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org