You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/10 20:40:48 UTC
[GitHub] [camel] anthonywu-toast opened a new pull request, #8147: CAMEL-18376: camel-pulsar; add redelivery backoff for ack timeout, nack
anthonywu-toast opened a new pull request, #8147:
URL: https://github.com/apache/camel/pull/8147
This PR adds in the ability to add a [RedeliveryBackoff](https://github.com/apache/pulsar/blob/master/pulsar-client-api/src/main/java/org/apache/pulsar/client/api/RedeliveryBackoff.java) for both the [ack timeout](https://pulsar.apache.org/docs/concepts-messaging/#acknowledgement-timeout) and[ negative acknowledgement](https://pulsar.apache.org/docs/concepts-messaging/#negative-acknowledgement) cases (details linked). Modifications to existing tests and the addition of a new test should ensure that the backoff works as expected.
Checklist:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #8147: CAMEL-18376: camel-pulsar: add redelivery backoff for ack timeout, nack
Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #8147:
URL: https://github.com/apache/camel/pull/8147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8147: CAMEL-18376: camel-pulsar: add redelivery backoff for ack timeout, nack
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8147:
URL: https://github.com/apache/camel/pull/8147#issuecomment-1211994959
:x: Finished component verification: **1 component(s) test failed** out of 5 component(s) tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #8147: CAMEL-18376: camel-pulsar: add redelivery backoff for ack timeout, nack
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #8147:
URL: https://github.com/apache/camel/pull/8147#issuecomment-1213022296
> @orpiske mind if I get logs for the last failed run?
[test-logs.zip](https://github.com/apache/camel/files/9315983/test-logs.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #8147: CAMEL-18376: camel-pulsar: add redelivery backoff for ack timeout, nack
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #8147:
URL: https://github.com/apache/camel/pull/8147#issuecomment-1211676543
Attaching the logs:
[build.log(2).zip](https://github.com/apache/camel/files/9307160/build.log.2.zip)
[test-logs(9).zip](https://github.com/apache/camel/files/9307161/test-logs.9.zip)
[checkstyle.log(4).zip](https://github.com/apache/camel/files/9307162/checkstyle.log.4.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8147: CAMEL-18376: camel-pulsar: add redelivery backoff for ack timeout, nack
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8147:
URL: https://github.com/apache/camel/pull/8147#issuecomment-1212415399
:x: Finished component verification: **1 component(s) test failed** out of 5 component(s) tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #8147: CAMEL-18376: camel-pulsar: add redelivery backoff for ack timeout, nack
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #8147:
URL: https://github.com/apache/camel/pull/8147#issuecomment-1212010636
> If there's another test failure, do you mind attaching the logs (or showing me where I can find them), @orpiske? My local machine seems to have trouble running these Docker-based tests.
Access to the test logs is restricted by the organization, but I can upload them here as needed.
[test-logs(1).zip](https://github.com/apache/camel/files/9309145/test-logs.1.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] anthonywu-toast commented on pull request #8147: CAMEL-18376: camel-pulsar: add redelivery backoff for ack timeout, nack
Posted by GitBox <gi...@apache.org>.
anthonywu-toast commented on PR #8147:
URL: https://github.com/apache/camel/pull/8147#issuecomment-1212939098
@orpiske mind if I get logs for the last failed run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8147: CAMEL-18376: camel-pulsar: add redelivery backoff for ack timeout, nack
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8147:
URL: https://github.com/apache/camel/pull/8147#issuecomment-1213963737
:heavy_check_mark: Finished component verification: 0 component(s) test failed out of **5 component(s) tested**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8147: CAMEL-18376: camel-pulsar: add redelivery backoff for ack timeout, nack
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8147:
URL: https://github.com/apache/camel/pull/8147#issuecomment-1213227243
:x: Finished component verification: **1 component(s) test failed** out of 5 component(s) tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8147: CAMEL-18376: camel-pulsar: add redelivery backoff for ack timeout, nack
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8147:
URL: https://github.com/apache/camel/pull/8147#issuecomment-1211827864
:x: Finished component verification: **1 component(s) test failed** out of 5 component(s) tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8147: CAMEL-18376: camel-pulsar; add redelivery backoff for ack timeout, nack
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8147:
URL: https://github.com/apache/camel/pull/8147#issuecomment-1211247520
:warning: This PR changes Camel components and will be tested automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] anthonywu-toast commented on pull request #8147: CAMEL-18376: camel-pulsar: add redelivery backoff for ack timeout, nack
Posted by GitBox <gi...@apache.org>.
anthonywu-toast commented on PR #8147:
URL: https://github.com/apache/camel/pull/8147#issuecomment-1211672351
Will take a peek at job failures and fix shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] anthonywu-toast commented on pull request #8147: CAMEL-18376: camel-pulsar: add redelivery backoff for ack timeout, nack
Posted by GitBox <gi...@apache.org>.
anthonywu-toast commented on PR #8147:
URL: https://github.com/apache/camel/pull/8147#issuecomment-1213487659
Thanks for sending the files; I managed to commandeer a coworker's laptop running on x86_64 to avoid the local issues I was seeing (since I'm on an M1 it revolves around https://github.com/apache/pulsar/issues/12944). I left configuring container startup/timeouts, etc. out of the loop for now. Tests pass locally so hopefully this should be the last commit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8147: CAMEL-18376: camel-pulsar: add redelivery backoff for ack timeout, nack
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8147:
URL: https://github.com/apache/camel/pull/8147#issuecomment-1214008543
Yeah it works now, thanks for contributing to Camel. You are welcome to keep improving ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] anthonywu-toast commented on pull request #8147: CAMEL-18376: camel-pulsar: add redelivery backoff for ack timeout, nack
Posted by GitBox <gi...@apache.org>.
anthonywu-toast commented on PR #8147:
URL: https://github.com/apache/camel/pull/8147#issuecomment-1211922899
If there's another test failure, do you mind attaching the logs (or showing me where I can find them), @orpiske? My local machine seems to have trouble running these Docker-based tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8147: CAMEL-18376: camel-pulsar: add redelivery backoff for ack timeout, nack
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8147:
URL: https://github.com/apache/camel/pull/8147#issuecomment-1211568339
:x: Finished component verification: **1 component(s) test failed** out of 1 component(s) tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8147: CAMEL-18376: camel-pulsar: add redelivery backoff for ack timeout, nack
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8147:
URL: https://github.com/apache/camel/pull/8147#issuecomment-1212751933
:x: Finished component verification: **1 component(s) test failed** out of 5 component(s) tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org