[GitHub] lucene-solr pull request #402: SOLR-12477 - Return server error(500) for Alr...

[vthacker <gi...@git.apache.org>]

Github user vthacker commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/402#discussion_r205929654
  
    --- Diff: solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java ---
    @@ -208,14 +208,17 @@ public void handleRequest(SolrQueryRequest req, SolrQueryResponse rsp) {
             }
           }
         } catch (Exception e) {
    +      boolean hasTragicException = false;
    --- End diff --
    
    Here is what I was thinking of after this statement. What do you think?
    
            if (isTragic) {
              if (e instanceof SolrException) {
                assert ((SolrException) e).code() == 500; //Tragic exceptions should always throw a server error
              } else {
                //wrap it in a solr exception
                e = new SolrException(SolrException.ErrorCode.SERVER_ERROR, e);
              }
            }


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org