You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/14 16:06:20 UTC

[GitHub] [beam] lazylynx commented on a change in pull request #11656: [BEAM-9942] reduce groovy code duplication in python test-suites

lazylynx commented on a change in pull request #11656:
URL: https://github.com/apache/beam/pull/11656#discussion_r425254756



##########
File path: sdks/python/test-suites/portable/py2/build.gradle
##########
@@ -113,28 +98,6 @@ task crossLanguagePortableWordCount {
   }
 }
 
-task postCommitPy2IT {
-  dependsOn 'installGcpTest'
-  dependsOn 'setupVirtualenv'
-  dependsOn ':runners:flink:1.10:job-server:shadowJar'
-
-  doLast {
-    def tests = [
-        "apache_beam.io.gcp.bigquery_read_it_test",
-    ]
-    def testOpts = ["--tests=${tests.join(',')}"]
-    def cmdArgs = mapToArgString([
-        "test_opts": testOpts,
-        "suite": "postCommitIT-flink-py2",
-        "pipeline_opts": "--runner=FlinkRunner --project=apache-beam-testing --environment_type=LOOPBACK --temp_location=gs://temp-storage-for-end-to-end-tests/temp-it",
-    ])
-    exec {
-      executable 'sh'
-      args '-c', ". ${envdir}/bin/activate && ${runScriptsDir}/run_integration_test.sh $cmdArgs"
-    }
-  }
-}
-
 task crossLanguageTests {

Review comment:
       Exactly. 
   BEAM-9980 aims to do that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org