[jira] [Commented] (PHOENIX-5554) Synchronize @Parameters, @BeforeClass and @AfterClass methods

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962945#comment-16962945 ] 

Hadoop QA commented on PHOENIX-5554:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12984345/PHOENIX-5554.master.v1.patch
  against master branch at commit 1299dbc46687d5867a3dacaa8680ad69876f9088.
  ATTACHMENT ID: 12984345

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 72 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.schema.stats.TxStatsCollectorIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3081//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3081//console

This message is automatically generated.

> Synchronize @Parameters, @BeforeClass and @AfterClass methods
> -------------------------------------------------------------
>
>                 Key: PHOENIX-5554
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5554
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: István Tóth
>            Assignee: István Tóth
>            Priority: Major
>         Attachments: PHOENIX-5554.master.v1.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> According to the failsafe docs, all methods that are annotated with @Parameters, @BeforeClass and @AfterClass should be synchronized.
> This is not just a theoretical problem, it causes random test failures, like 
> [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3078//testReport/org.apache.phoenix.end2end/DescOrderKeysIT/org_apache_phoenix_end2end_DescOrderKeysIT/] 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)