Re: httpd-1.3 patchlets

[Sander Temme <sa...@temme.net>]

That's wrowe, Mads and...

Thanks,

S.

On Jul 20, 2005, at 8:40 AM, William A. Rowe, Jr. wrote:

> +1 on both patches; I can see how libhttpd.so gets stripped today.
>
> I'd commit if there were a couple more +1's.
>
> Bill
>
> At 08:16 AM 7/20/2005, Sander Temme wrote:
>
>> Two very small patches against 1.3.
>>
>> First one, make ab default to the highest SSL version available:
>>
>> Index: src/support/ab.c
>> ===================================================================
>> --- src/support/ab.c    (revision 125243)
>> +++ src/support/ab.c    (working copy)
>> @@ -1655,7 +1655,7 @@
>>
>> #ifdef USE_SSL
>>     SSL_library_init();
>> -    if (!(ctx = SSL_CTX_new(SSLv2_client_method()))) {
>> +    if (!(ctx = SSL_CTX_new(SSLv23_client_method()))) {
>>        fprintf(stderr, "Could not init SSL CTX: ");
>>        ERR_print_errors_fp(stderr);
>>        exit(1);
>>
>> Secondly, a patch that keeps --without-execstrip from stripping the
>> httpd binary:
>>
>> Index: configure
>> ===================================================================
>> --- configure   (revision 219524)
>> +++ configure   (working copy)
>> @@ -927,6 +927,8 @@
>>             ;;
>>         --without-execstrip)
>>             iflags_program=`echo "$iflags_program" | sed -e 's/-s//'`
>> +            iflags_core=`echo "$iflags_core" | sed -e 's/-S//' -e  
>> 's/ \"-S\"//'`
>> +            iflags_dso=`echo "$iflags_dso" | sed -e 's/-S//' -e  
>> 's/ \"-S\"//'`
>>             ;;
>>         --suexec-caller=*)
>>             suexec_caller="$apc_optarg"
>>
>> There is a special case for Darwin in configure that makes the httpd
>> binary get stripped even if --without-execstrip is specified. This
>> stops that from happening, so --without-execstrip leaves all binaries
>> unstripped. I think this adheres to the principle of least  
>> astonishment.
>>
>> Let me know if you can fudge that in. (:
>>
>> Thanks,
>>
>> S.
>>
>> -- 
>> sander@temme.net              http://www.temme.net/sander/
>> PGP FP: 51B4 8727 466A 0BC3 69F4  B7B8 B2BE BC40 1529 24AF
>>
>
>
>
>


-- 
sander@temme.net              http://www.temme.net/sander/
PGP FP: 51B4 8727 466A 0BC3 69F4  B7B8 B2BE BC40 1529 24AF