You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/30 18:09:44 UTC

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #18816: Add Large Dim Checks for linalg Operators

Zha0q1 commented on a change in pull request #18816:
URL: https://github.com/apache/incubator-mxnet/pull/18816#discussion_r463180088



##########
File path: tests/nightly/test_large_array.py
##########
@@ -1350,6 +1351,50 @@ def run_trsm(inp):
     check_batch_trsm()
 
 
+def test_linalg_large_dim():
+    def check_gemm():
+        A = nd.ones(shape=(1, INT32_MAX + 1, 1))

Review comment:
       Yeah that would make sense. I have moved the tests to test_large_vector.py, which I kept the original name to avoid naming discrepancy with master. Also comments were added to the tests




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org