You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by al...@apache.org on 2025/09/23 04:59:45 UTC
(kudu) branch master updated: [style] updates to prepare for cpplint upgrade
This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push:
new ed9ebd6ad [style] updates to prepare for cpplint upgrade
ed9ebd6ad is described below
commit ed9ebd6ad41bedc519b29a050e2243970018b409
Author: Alexey Serbin <al...@apache.org>
AuthorDate: Mon Sep 22 17:22:22 2025 -0700
[style] updates to prepare for cpplint upgrade
There are no functional modifications in this changelist.
Change-Id: I9349ee15f7de5dc173871fa0279705f849aad50d
Reviewed-on: http://gerrit.cloudera.org:8080/23453
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
src/kudu/cfile/block_handle.h | 1 +
src/kudu/cfile/bshuf_block.h | 1 +
src/kudu/cfile/cfile-test-base.h | 1 +
src/kudu/cfile/plain_bitmap_block.h | 1 +
src/kudu/cfile/plain_block.h | 1 +
src/kudu/cfile/rle_block.h | 1 +
src/kudu/client/schema-internal.h | 1 +
src/kudu/client/shared_ptr.h | 2 +-
src/kudu/common/columnblock-test-util.h | 2 ++
src/kudu/common/row.h | 1 +
src/kudu/consensus/ref_counted_replicate.h | 2 ++
src/kudu/fs/fs-test-util.h | 1 +
src/kudu/rpc/retriable_rpc.h | 1 +
src/kudu/rpc/rpc-test-base.h | 1 +
src/kudu/tablet/tablet-test-base.h | 1 +
src/kudu/tablet/tablet_mem_trackers.h | 1 +
src/kudu/tablet/txn_metadata.h | 1 +
src/kudu/tablet/txn_participant-test-util.h | 2 ++
src/kudu/thrift/client.h | 1 +
src/kudu/tserver/tablet_copy-test-base.h | 2 ++
src/kudu/util/bloom_filter.cc | 2 +-
src/kudu/util/cow_object.h | 1 +
src/kudu/util/file_cache-test-util.h | 3 ++-
src/kudu/util/interval_tree-inl.h | 1 +
src/kudu/util/memory/memory.h | 1 +
src/kudu/util/stopwatch.h | 10 +++++++---
26 files changed, 37 insertions(+), 6 deletions(-)
diff --git a/src/kudu/cfile/block_handle.h b/src/kudu/cfile/block_handle.h
index bcdaf543e..6e0e2f892 100644
--- a/src/kudu/cfile/block_handle.h
+++ b/src/kudu/cfile/block_handle.h
@@ -17,6 +17,7 @@
#pragma once
#include <memory>
+#include <utility>
#include <boost/variant/get.hpp>
#include <boost/variant/variant.hpp>
diff --git a/src/kudu/cfile/bshuf_block.h b/src/kudu/cfile/bshuf_block.h
index 8036fca64..a4e8450e1 100644
--- a/src/kudu/cfile/bshuf_block.h
+++ b/src/kudu/cfile/bshuf_block.h
@@ -28,6 +28,7 @@
#include <cstring>
#include <cstdint>
#include <ostream>
+#include <utility>
#include <vector>
#include <glog/logging.h>
diff --git a/src/kudu/cfile/cfile-test-base.h b/src/kudu/cfile/cfile-test-base.h
index 20f981bbf..2f4b41d4a 100644
--- a/src/kudu/cfile/cfile-test-base.h
+++ b/src/kudu/cfile/cfile-test-base.h
@@ -21,6 +21,7 @@
#include <functional>
#include <memory>
#include <string>
+#include <utility>
#include <vector>
#include <glog/logging.h>
diff --git a/src/kudu/cfile/plain_bitmap_block.h b/src/kudu/cfile/plain_bitmap_block.h
index 6701b105f..561c852d7 100644
--- a/src/kudu/cfile/plain_bitmap_block.h
+++ b/src/kudu/cfile/plain_bitmap_block.h
@@ -18,6 +18,7 @@
#include <algorithm>
#include <string>
+#include <utility>
#include <vector>
#include "kudu/cfile/block_encodings.h"
diff --git a/src/kudu/cfile/plain_block.h b/src/kudu/cfile/plain_block.h
index 41b2979a8..b8a5e0fff 100644
--- a/src/kudu/cfile/plain_block.h
+++ b/src/kudu/cfile/plain_block.h
@@ -18,6 +18,7 @@
#include <algorithm>
#include <string>
+#include <utility>
#include <vector>
#include "kudu/cfile/block_encodings.h"
diff --git a/src/kudu/cfile/rle_block.h b/src/kudu/cfile/rle_block.h
index 1ebd33f93..8930abcaa 100644
--- a/src/kudu/cfile/rle_block.h
+++ b/src/kudu/cfile/rle_block.h
@@ -18,6 +18,7 @@
#include <algorithm>
#include <string>
+#include <utility>
#include <vector>
#include "kudu/gutil/port.h"
diff --git a/src/kudu/client/schema-internal.h b/src/kudu/client/schema-internal.h
index 2018cecd2..abd972e0e 100644
--- a/src/kudu/client/schema-internal.h
+++ b/src/kudu/client/schema-internal.h
@@ -18,6 +18,7 @@
#include <optional>
#include <string>
+#include <utility>
#include "kudu/client/schema.h"
#include "kudu/client/value.h"
diff --git a/src/kudu/client/shared_ptr.h b/src/kudu/client/shared_ptr.h
index 13feb827e..c554cea1a 100644
--- a/src/kudu/client/shared_ptr.h
+++ b/src/kudu/client/shared_ptr.h
@@ -68,7 +68,7 @@ namespace sp {
}
#else
-#include <tr1/memory>
+#include <tr1/memory> // NOLINT(build/c++tr1)
namespace kudu {
namespace client {
diff --git a/src/kudu/common/columnblock-test-util.h b/src/kudu/common/columnblock-test-util.h
index bd8e7a104..d67a6bff4 100644
--- a/src/kudu/common/columnblock-test-util.h
+++ b/src/kudu/common/columnblock-test-util.h
@@ -16,6 +16,8 @@
// under the License.
#pragma once
+#include <memory>
+
#include "kudu/gutil/macros.h"
#include "kudu/common/columnblock.h"
diff --git a/src/kudu/common/row.h b/src/kudu/common/row.h
index ef904dd50..ae94f2d6d 100644
--- a/src/kudu/common/row.h
+++ b/src/kudu/common/row.h
@@ -21,6 +21,7 @@
#include <string>
#include <utility>
#include <vector>
+#include <unordered_map>
#include <glog/logging.h>
diff --git a/src/kudu/consensus/ref_counted_replicate.h b/src/kudu/consensus/ref_counted_replicate.h
index b2fa8447c..2c8cc03ad 100644
--- a/src/kudu/consensus/ref_counted_replicate.h
+++ b/src/kudu/consensus/ref_counted_replicate.h
@@ -16,6 +16,8 @@
// under the License.
#pragma once
+#include <memory>
+
#include "kudu/consensus/consensus.pb.h"
#include "kudu/gutil/ref_counted.h"
diff --git a/src/kudu/fs/fs-test-util.h b/src/kudu/fs/fs-test-util.h
index 58c2cd90b..f73c613bd 100644
--- a/src/kudu/fs/fs-test-util.h
+++ b/src/kudu/fs/fs-test-util.h
@@ -20,6 +20,7 @@
#include <memory>
#include <numeric>
+#include <utility>
#include <vector>
#include "kudu/fs/block_manager.h"
diff --git a/src/kudu/rpc/retriable_rpc.h b/src/kudu/rpc/retriable_rpc.h
index a51259782..c32dfc585 100644
--- a/src/kudu/rpc/retriable_rpc.h
+++ b/src/kudu/rpc/retriable_rpc.h
@@ -19,6 +19,7 @@
#include <functional>
#include <memory>
#include <string>
+#include <utility>
#include "kudu/gutil/ref_counted.h"
#include "kudu/gutil/strings/substitute.h"
diff --git a/src/kudu/rpc/rpc-test-base.h b/src/kudu/rpc/rpc-test-base.h
index 28478b82b..d651cddaf 100644
--- a/src/kudu/rpc/rpc-test-base.h
+++ b/src/kudu/rpc/rpc-test-base.h
@@ -21,6 +21,7 @@
#include <memory>
#include <string>
#include <thread>
+#include <utility>
#include <vector>
#include "kudu/gutil/walltime.h"
diff --git a/src/kudu/tablet/tablet-test-base.h b/src/kudu/tablet/tablet-test-base.h
index 55b7cbaac..71c457014 100644
--- a/src/kudu/tablet/tablet-test-base.h
+++ b/src/kudu/tablet/tablet-test-base.h
@@ -22,6 +22,7 @@
#include <optional>
#include <string>
#include <unordered_set>
+#include <utility>
#include <vector>
#include <glog/logging.h>
diff --git a/src/kudu/tablet/tablet_mem_trackers.h b/src/kudu/tablet/tablet_mem_trackers.h
index 405b4cb91..039ccfe89 100644
--- a/src/kudu/tablet/tablet_mem_trackers.h
+++ b/src/kudu/tablet/tablet_mem_trackers.h
@@ -18,6 +18,7 @@
#include <memory>
#include <string>
+#include <utility>
#include "kudu/gutil/strings/substitute.h"
#include "kudu/util/mem_tracker.h"
diff --git a/src/kudu/tablet/txn_metadata.h b/src/kudu/tablet/txn_metadata.h
index f0e6a6ca4..174ad0a17 100644
--- a/src/kudu/tablet/txn_metadata.h
+++ b/src/kudu/tablet/txn_metadata.h
@@ -17,6 +17,7 @@
#pragma once
#include <optional>
+#include <utility>
#include <glog/logging.h>
diff --git a/src/kudu/tablet/txn_participant-test-util.h b/src/kudu/tablet/txn_participant-test-util.h
index 7d85fee87..e5220b2c3 100644
--- a/src/kudu/tablet/txn_participant-test-util.h
+++ b/src/kudu/tablet/txn_participant-test-util.h
@@ -16,6 +16,8 @@
// under the License.
#pragma once
+#include <memory>
+#include <utility>
#include <vector>
#include "kudu/tablet/tablet_replica.h"
diff --git a/src/kudu/thrift/client.h b/src/kudu/thrift/client.h
index 76a554bac..5c492bd0c 100644
--- a/src/kudu/thrift/client.h
+++ b/src/kudu/thrift/client.h
@@ -24,6 +24,7 @@
#include <functional>
#include <memory>
#include <string>
+#include <utility>
#include <vector>
#include <glog/logging.h>
diff --git a/src/kudu/tserver/tablet_copy-test-base.h b/src/kudu/tserver/tablet_copy-test-base.h
index 60534bd3f..d2a62cb6f 100644
--- a/src/kudu/tserver/tablet_copy-test-base.h
+++ b/src/kudu/tserver/tablet_copy-test-base.h
@@ -19,7 +19,9 @@
#include "kudu/tserver/tablet_server-test-base.h"
+#include <memory>
#include <string>
+#include <utility>
#include <vector>
#include "kudu/consensus/log_anchor_registry.h"
diff --git a/src/kudu/util/bloom_filter.cc b/src/kudu/util/bloom_filter.cc
index b1a2055c5..e5bf97925 100644
--- a/src/kudu/util/bloom_filter.cc
+++ b/src/kudu/util/bloom_filter.cc
@@ -52,7 +52,7 @@ BloomFilterSizing BloomFilterSizing::BySizeAndFPRate(size_t n_bytes, double fp_r
double expected_elems = -static_cast<double>(n_bits) * kNaturalLog2 * kNaturalLog2 /
log(fp_rate);
DCHECK_GT(expected_elems, 1);
- return BloomFilterSizing(n_bytes, (size_t)ceil(expected_elems));
+ return BloomFilterSizing(n_bytes, static_cast<size_t>(ceil(expected_elems)));
}
diff --git a/src/kudu/util/cow_object.h b/src/kudu/util/cow_object.h
index c03721c3d..7213099af 100644
--- a/src/kudu/util/cow_object.h
+++ b/src/kudu/util/cow_object.h
@@ -20,6 +20,7 @@
#include <map>
#include <memory>
#include <ostream>
+#include <utility>
#include <glog/logging.h>
diff --git a/src/kudu/util/file_cache-test-util.h b/src/kudu/util/file_cache-test-util.h
index 09acb6855..49e1ff5d2 100644
--- a/src/kudu/util/file_cache-test-util.h
+++ b/src/kudu/util/file_cache-test-util.h
@@ -17,10 +17,11 @@
#pragma once
+#include <string>
#include <thread>
+#include <utility>
#include <glog/logging.h>
-#include <string>
#include "kudu/gutil/strings/substitute.h"
#include "kudu/util/countdown_latch.h"
diff --git a/src/kudu/util/interval_tree-inl.h b/src/kudu/util/interval_tree-inl.h
index a4fa1e5f8..138d7f277 100644
--- a/src/kudu/util/interval_tree-inl.h
+++ b/src/kudu/util/interval_tree-inl.h
@@ -18,6 +18,7 @@
#define KUDU_UTIL_INTERVAL_TREE_INL_H
#include <algorithm>
+#include <utility>
#include <vector>
#include "kudu/util/interval_tree.h"
diff --git a/src/kudu/util/memory/memory.h b/src/kudu/util/memory/memory.h
index 527c01305..28374624d 100644
--- a/src/kudu/util/memory/memory.h
+++ b/src/kudu/util/memory/memory.h
@@ -36,6 +36,7 @@
#include <limits>
#include <memory>
#include <ostream>
+#include <utility>
#include <vector>
#include <glog/logging.h>
diff --git a/src/kudu/util/stopwatch.h b/src/kudu/util/stopwatch.h
index 83dcc5330..e91df044c 100644
--- a/src/kudu/util/stopwatch.h
+++ b/src/kudu/util/stopwatch.h
@@ -17,17 +17,21 @@
#ifndef KUDU_UTIL_STOPWATCH_H
#define KUDU_UTIL_STOPWATCH_H
-#include <glog/logging.h>
+#include <ctime>
+#include <string>
+#include <utility>
+
#include <sys/resource.h>
#include <sys/time.h>
-#include <time.h>
-#include <string>
+
#if defined(__APPLE__)
#include <mach/clock.h>
#include <mach/mach.h>
#include <mach/thread_info.h>
#endif // defined(__APPLE__)
+#include <glog/logging.h>
+
#include "kudu/gutil/macros.h"
#include "kudu/gutil/stringprintf.h"
#include "kudu/gutil/walltime.h"