[jira] Closed: (TAP5-945) Unnecessary and severe lock contention in PerthreadManagerImpl

["Howard M. Lewis Ship (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TAP5-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-945.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.2.0.0

The synchronization logic is only present for JDK 1.5 now; for JDK 1.6 or above, no extra synchronization occurs.

> Unnecessary and severe lock contention in PerthreadManagerImpl
> --------------------------------------------------------------
>
>                 Key: TAP5-945
>                 URL: https://issues.apache.org/jira/browse/TAP5-945
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.1.0.5
>            Reporter: Olle Hallin
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.2.0.0
>
>
> When load testing our new high-volume site before soft launch, we found that we have severe lock contention in org.apache.tapestry5.ioc.internal.services.PerthreadManagerImpl.
> It synchronizes on "this" before invoking ThreadLocal.get() and ThreadLocal.remove(), which I believe is unnecessary. 
> During our tests, approximately  35% of all Tomcat threads were waiting for this lock in any of 10 thread dumps taken 15 seconds apart.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.