You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/02/01 13:16:04 UTC
[GitHub] jt2594838 commented on a change in pull request #32: fix sonar
issues
jt2594838 commented on a change in pull request #32: fix sonar issues
URL: https://github.com/apache/incubator-iotdb/pull/32#discussion_r253045209
##########
File path: iotdb/src/main/java/org/apache/iotdb/db/engine/filenode/FileNodeProcessor.java
##########
@@ -429,10 +428,13 @@ public void fileNodeRecovery() throws FileNodeProcessorException {
.put(FileNodeConstants.FILENODE_PROCESSOR_FLUSH_ACTION, flushFileNodeProcessorAction);
String baseDir = directories
.getTsFileFolder(newFileNodes.get(newFileNodes.size() - 1).getBaseDirIndex());
- LOGGER.info(
- "The filenode processor {} will recovery the bufferwrite processor, "
- + "the bufferwrite file is {}",
- getProcessorName(), fileNames[fileNames.length - 1]);
+ if (LOGGER.isInfoEnabled()) {
Review comment:
This is because the log here involves value evaluation. Adding an if can avoid unnecessary value evaluation, which is not needed everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services