You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/07/03 14:56:22 UTC

[GitHub] flink pull request #4248: [FLINK-7069] [metrics] Granular exception catching...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4248

    [FLINK-7069] [metrics] Granular exception catching in MetricRegistry

    This PR makes the exception catching in the MetricRegistry more granular when adding or removing metrics.
    
    A reporter that throws an exception prevented other reporters, the MetricQueryService and the ViewUpdater from being notified about added or removed metrics.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7069

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4248.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4248
    
----
commit 580bdaffdabfedd859e30ee7f37cf3f7983074f9
Author: zentol <ch...@apache.org>
Date:   2017-07-03T14:49:01Z

    [FLINK-7069] [metrics] Granular exception catching in MetricRegistry

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4248: [FLINK-7069] [metrics] Granular exception catching in Met...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4248
  
    merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4248: [FLINK-7069] [metrics] Granular exception catching in Met...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/4248
  
    The changes look good! 👍 
    
    What about a test, though? 😅 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4248: [FLINK-7069] [metrics] Granular exception catching...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4248


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4248: [FLINK-7069] [metrics] Granular exception catching in Met...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4248
  
    @aljoscha added a test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4248: [FLINK-7069] [metrics] Granular exception catching in Met...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4248
  
    sure, i can add a test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4248: [FLINK-7069] [metrics] Granular exception catching in Met...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/4248
  
    Perfect, this LGTM now!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---