You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@struts.apache.org by GitBox <gi...@apache.org> on 2022/02/12 21:06:23 UTC

[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #528: Potential expression cache enhancement for 2.6 series

JCgH4164838Gh792C124B5 commented on pull request #528:
URL: https://github.com/apache/struts/pull/528#issuecomment-1037479805


   Hi @lukaszlenart .
   
   Thanks for the feedback and suggestions.
   
   Moving the existing cache layer into dedicated interfaces/classes is probably cleaner in the long run, as you pointed out.  I can attempt to do that in a revision to the PR, it just might take me a little while.
   
   Because the cache instance(s) are final and part of the intializer block, the instances get set before the configuration flags can be applied (when the framework injects the flag values a little later).  A dedicated cache implementation could probably help address that (or at least hide some of the details), in a cleaner way than what I have done so far.
   
   I will try a refactor and see how it works out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org