You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "roger-mike (via GitHub)" <gi...@apache.org> on 2023/02/13 14:26:34 UTC

[GitHub] [beam] roger-mike opened a new pull request, #24034: GA Issues Manager Workflow

roger-mike opened a new pull request, #24034:
URL: https://github.com/apache/beam/pull/24034

   This workflow adds the following behavior:
   - Checks the last K successful runs for each workflow in the repo
   - Creates an issue for each of the unstable workflows
   - Closes the current issues for each of the stable workflows
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on pull request #24034: GA Issues Manager Workflow

Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24034:
URL: https://github.com/apache/beam/pull/24034#issuecomment-1335756520

   @Abacn could you take this one to completion from the reviewer side?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] closed pull request #24034: GA Issues Manager Workflow

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #24034: GA Issues Manager Workflow
URL: https://github.com/apache/beam/pull/24034


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #24034: GA Issues Manager Workflow

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24034:
URL: https://github.com/apache/beam/pull/24034#issuecomment-1307512890

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @Abacn for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on a diff in pull request #24034: GA Issues Manager Workflow

Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #24034:
URL: https://github.com/apache/beam/pull/24034#discussion_r1018458276


##########
.github/workflows/workflows-issues-manager.yml:
##########
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Workflows Issues Manager
+
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '0 */12 * * *'
+  push:
+    branches: ['feat/issues-manager']

Review Comment:
   what does this branch for?



##########
scripts/ci/workflows-issues-manager/constants.js:
##########
@@ -0,0 +1,17 @@
+const DEFAULT_K = 5;
+
+const MIN_RUNS = {

Review Comment:
   I understood this are workflow identifier and the unstable threshold parameter. A more detailed comment string will help to understand.



##########
scripts/ci/workflows-issues-manager/index.js:
##########
@@ -0,0 +1,130 @@
+const { ISSUES_MANAGER_TAG } = require("./constants.js");
+const { getRepoWorkflows, getRunsForWorkflow } = require("./workflows.js");
+const { getRepoIssues, closeIssue, createIssue} = require("./issues");
+
+
+const checkConclusions = (conclusions) => {
+  return ({ conclusion }) => {
+    return conclusions.includes(conclusion);
+  };
+};
+
+const filterRuns = (runs, conclusions) => {
+  return runs.filter((run) => conclusions.includes(run.conclusion));
+};
+
+const splitWorkflows = async ({ github, context }, workflows) => {
+  let lastKRuns = [];
+  let unstable = [];
+  let stable = [];
+  let permared = [];
+
+  //TODO: make it parallel
+  for (const workflow of workflows) {
+    const { workflow_runs } = await getRunsForWorkflow({ github, context }, workflow);
+    let filteredRuns = filterRuns(workflow_runs, ["success", "failure", "timed_out"]);
+
+    const output = filteredRuns.map(
+      ({ id, name, conclusion, event, head_branch }) => `${id} | ${name} | ${conclusion} | ${event} |${head_branch}`
+    );
+    console.log("FILTERED WORKFLOW RUNS", output);
+
+    lastKRuns.push({
+      workflow,
+      filteredRuns,
+    });
+  }
+
+  const isSuccessful = checkConclusions(["success"]);
+  const isFailure = checkConclusions(["failure", "timed_out"]);
+
+  //TODO: Handle case when filteredRuns is empty
+
+  lastKRuns = lastKRuns.filter(({ filteredRuns }) => filteredRuns.length > 0);
+
+  unstable = lastKRuns.filter(({ filteredRuns }) => filteredRuns.some(isFailure) && !filteredRuns.every(isFailure));

Review Comment:
   Looks like unstable means the there is at least one flake in last K runs. Wondering if this could flood open issues; or keep closing and open issues. I do not have a mind about the preferred strategy but we could rollout this gradually (first monitor a subset of workflows or so) to see if it works well.



##########
.github/workflows/workflows-issues-manager.yml:
##########
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Workflows Issues Manager
+
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '0 */12 * * *'
+  push:
+    branches: ['feat/issues-manager']
+
+jobs:
+  workflows_validation:
+    name: Workflows Issues Manager
+    permissions:
+      contents: write
+      pull-requests: write
+      checks: read
+      issues: read
+      statuses: read
+    # Don't run on forks
+#    if: github.repository == 'apache/beam'

Review Comment:
   (a mark and remove the comment before merge)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] roger-mike commented on pull request #24034: GA Issues Manager Workflow

Posted by GitBox <gi...@apache.org>.
roger-mike commented on PR #24034:
URL: https://github.com/apache/beam/pull/24034#issuecomment-1337848685

   > LGTM
   > 
   > just remember to replace fields marked in the comments before actual migration happens and merge.
   
   Thanks @Abacn / @damccorm. Sorry, which fields do you mean? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] roger-mike commented on a diff in pull request #24034: GA Issues Manager Workflow

Posted by GitBox <gi...@apache.org>.
roger-mike commented on code in PR #24034:
URL: https://github.com/apache/beam/pull/24034#discussion_r1020420869


##########
scripts/ci/workflows-issues-manager/issues.js:
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+const { ISSUES_MANAGER_TAG } = require("./constants.js");
+
+const getRepoIssues = async ({ github, context }) => {
+  let issues = [];
+
+  //TODO: Use a label or an id to get more specific issues
+  for await (const response of github.paginate.iterator(github.rest.issues.listForRepo, {
+    owner: context.repo.owner,
+    repo: context.repo.repo,
+    per_page: 100,
+  })) {
+    issues = issues.concat(response.data);
+  }
+
+  return issues;
+};

Review Comment:
   @Abacn could you create a label called `issues-manager`? The issues created by this workflow will have that label. Could be better if we get the issues already filtered from the API instead of getting the ~4K issues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on a diff in pull request #24034: GA Issues Manager Workflow

Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #24034:
URL: https://github.com/apache/beam/pull/24034#discussion_r1020514974


##########
scripts/ci/workflows-issues-manager/issues.js:
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+const { ISSUES_MANAGER_TAG } = require("./constants.js");
+
+const getRepoIssues = async ({ github, context }) => {
+  let issues = [];
+
+  //TODO: Use a label or an id to get more specific issues
+  for await (const response of github.paginate.iterator(github.rest.issues.listForRepo, {
+    owner: context.repo.owner,
+    repo: context.repo.repo,
+    per_page: 100,
+  })) {
+    issues = issues.concat(response.data);
+  }
+
+  return issues;
+};

Review Comment:
   created: https://github.com/apache/beam/labels/issues-manager



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] roger-mike commented on a diff in pull request #24034: GA Issues Manager Workflow

Posted by GitBox <gi...@apache.org>.
roger-mike commented on code in PR #24034:
URL: https://github.com/apache/beam/pull/24034#discussion_r1019574742


##########
.github/workflows/workflows-issues-manager.yml:
##########
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Workflows Issues Manager
+
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '0 */12 * * *'
+  push:
+    branches: ['feat/issues-manager']

Review Comment:
   Just to test in my fork when pushing. It's going to be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] roger-mike commented on a diff in pull request #24034: GA Issues Manager Workflow

Posted by GitBox <gi...@apache.org>.
roger-mike commented on code in PR #24034:
URL: https://github.com/apache/beam/pull/24034#discussion_r1019575696


##########
scripts/ci/workflows-issues-manager/constants.js:
##########
@@ -0,0 +1,17 @@
+const DEFAULT_K = 5;
+
+const MIN_RUNS = {

Review Comment:
   Done ๐Ÿ‘ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm closed pull request #24034: GA Issues Manager Workflow

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed pull request #24034: GA Issues Manager Workflow
URL: https://github.com/apache/beam/pull/24034


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] roger-mike commented on a diff in pull request #24034: GA Issues Manager Workflow

Posted by GitBox <gi...@apache.org>.
roger-mike commented on code in PR #24034:
URL: https://github.com/apache/beam/pull/24034#discussion_r1019587564


##########
scripts/ci/workflows-issues-manager/index.js:
##########
@@ -0,0 +1,130 @@
+const { ISSUES_MANAGER_TAG } = require("./constants.js");
+const { getRepoWorkflows, getRunsForWorkflow } = require("./workflows.js");
+const { getRepoIssues, closeIssue, createIssue} = require("./issues");
+
+
+const checkConclusions = (conclusions) => {
+  return ({ conclusion }) => {
+    return conclusions.includes(conclusion);
+  };
+};
+
+const filterRuns = (runs, conclusions) => {
+  return runs.filter((run) => conclusions.includes(run.conclusion));
+};
+
+const splitWorkflows = async ({ github, context }, workflows) => {
+  let lastKRuns = [];
+  let unstable = [];
+  let stable = [];
+  let permared = [];
+
+  //TODO: make it parallel
+  for (const workflow of workflows) {
+    const { workflow_runs } = await getRunsForWorkflow({ github, context }, workflow);
+    let filteredRuns = filterRuns(workflow_runs, ["success", "failure", "timed_out"]);
+
+    const output = filteredRuns.map(
+      ({ id, name, conclusion, event, head_branch }) => `${id} | ${name} | ${conclusion} | ${event} |${head_branch}`
+    );
+    console.log("FILTERED WORKFLOW RUNS", output);
+
+    lastKRuns.push({
+      workflow,
+      filteredRuns,
+    });
+  }
+
+  const isSuccessful = checkConclusions(["success"]);
+  const isFailure = checkConclusions(["failure", "timed_out"]);
+
+  //TODO: Handle case when filteredRuns is empty
+
+  lastKRuns = lastKRuns.filter(({ filteredRuns }) => filteredRuns.length > 0);
+
+  unstable = lastKRuns.filter(({ filteredRuns }) => filteredRuns.some(isFailure) && !filteredRuns.every(isFailure));

Review Comment:
   In the `createIssuesForWorkflows ` function we check if the workflow has an issue associated with it. The `createIssuesForWorkflows` is only called for unstable and permared workflows. So, if any of them already has an open issue it won't be created again. About the rollout, which subset of workflow do you think we can select?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #24034: GA Issues Manager Workflow

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24034:
URL: https://github.com/apache/beam/pull/24034#issuecomment-1326369407

   Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @damccorm for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #24034: GA Issues Manager Workflow

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24034:
URL: https://github.com/apache/beam/pull/24034#issuecomment-1426758481

   This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #24034: GA Issues Manager Workflow

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24034:
URL: https://github.com/apache/beam/pull/24034#issuecomment-1335760962

   Stopping reviewer notifications for this pull request: requested by reviewer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] damccorm commented on pull request #24034: GA Issues Manager Workflow

Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24034:
URL: https://github.com/apache/beam/pull/24034#issuecomment-1335756772

   stop reviewer notifications


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #24034: GA Issues Manager Workflow

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24034:
URL: https://github.com/apache/beam/pull/24034#issuecomment-1416742874

   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think thatโ€™s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #24034: GA Issues Manager Workflow

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24034:
URL: https://github.com/apache/beam/pull/24034#issuecomment-1323571010

   Reminder, please take a look at this pr: @Abacn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] roger-mike commented on pull request #24034: GA Issues Manager Workflow

Posted by GitBox <gi...@apache.org>.
roger-mike commented on PR #24034:
URL: https://github.com/apache/beam/pull/24034#issuecomment-1330944808

   assign to next reviewer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on pull request #24034: GA Issues Manager Workflow

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24034:
URL: https://github.com/apache/beam/pull/24034#issuecomment-1337870562

   > > LGTM
   > > just remember to replace fields marked in the comments before actual migration happens and merge.
   > 
   > Thanks @Abacn / @damccorm. Sorry, which fields do you mean?
   
   I meant https://github.com/apache/beam/pull/24034#discussion_r1018458276 and https://github.com/apache/beam/pull/24034#discussion_r1018458790 I see they have been already changed. No further action needed, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] roger-mike commented on a diff in pull request #24034: GA Issues Manager Workflow

Posted by GitBox <gi...@apache.org>.
roger-mike commented on code in PR #24034:
URL: https://github.com/apache/beam/pull/24034#discussion_r1019575065


##########
.github/workflows/workflows-issues-manager.yml:
##########
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Workflows Issues Manager
+
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '0 */12 * * *'
+  push:
+    branches: ['feat/issues-manager']
+
+jobs:
+  workflows_validation:
+    name: Workflows Issues Manager
+    permissions:
+      contents: write
+      pull-requests: write
+      checks: read
+      issues: read
+      statuses: read
+    # Don't run on forks
+#    if: github.repository == 'apache/beam'

Review Comment:
   Noted ๐Ÿ‘ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] roger-mike commented on pull request #24034: GA Issues Manager Workflow

Posted by GitBox <gi...@apache.org>.
roger-mike commented on PR #24034:
URL: https://github.com/apache/beam/pull/24034#issuecomment-1310867809

   @Abacn This is an example of its execution. In this case, it failed because I can't create issues in my fork, but we can expect it works in the apache/beam repo.
   https://github.com/roger-mike/beam/actions/runs/3439667094/jobs/5737225261


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org