You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/06 00:59:52 UTC

[GitHub] [arrow-rs] HaoYang670 opened a new issue, #1658: Make `OffsetSizeTrait::IS_LARGE` as a const value

HaoYang670 opened a new issue, #1658:
URL: https://github.com/apache/arrow-rs/issues/1658

   Hmm, why don't we just make a `const` `is_large` in `OffsetSizeTrait` simply?
   
   ```rust
   pub trait OffsetSizeTrait {
     const IS_LARGE: bool;
   }
   impl OffsetSizeTrait for i32 {
       const IS_LARGE: bool = false;
   }
   
   impl OffsetSizeTrait for i64 {
       const IS_LARGE: bool = true
   }
   ```
   
   _Originally posted by @viirya in https://github.com/apache/arrow-rs/pull/1645#pullrequestreview-962535018_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] viirya closed issue #1658: Make `OffsetSizeTrait::IS_LARGE` as a const value

Posted by GitBox <gi...@apache.org>.

viirya closed issue #1658: Make `OffsetSizeTrait::IS_LARGE` as a const value
URL: https://github.com/apache/arrow-rs/issues/1658


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org