You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by pa...@apache.org on 2023/03/26 02:56:21 UTC
[shardingsphere] branch master updated: Update code conduct (#24829)
This is an automated email from the ASF dual-hosted git repository.
panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new c039d255a0b Update code conduct (#24829)
c039d255a0b is described below
commit c039d255a0bb266a00f41f823373b786ca3130db
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Sun Mar 26 10:56:15 2023 +0800
Update code conduct (#24829)
---
docs/community/content/involved/conduct/code.cn.md | 2 +-
docs/community/content/involved/conduct/code.en.md | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/community/content/involved/conduct/code.cn.md b/docs/community/content/involved/conduct/code.cn.md
index 39e3b269726..f1c8df5ef66 100644
--- a/docs/community/content/involved/conduct/code.cn.md
+++ b/docs/community/content/involved/conduct/code.cn.md
@@ -79,7 +79,7 @@ chapter = true
- 除去简单的 `getter /setter` 方法,以及声明 SPI 的静态代码,如:`getType / getOrder`,单元测试需全覆盖。
- 每个测试用例需精确断言,尽量不使用 `not`、`containsString` 断言。
- 准备环境的代码和测试代码分离。
- - 只有 Mockito,junit `Assert`,hamcrest `CoreMatchers` 和 `MatcherAssert` 相关可以使用 static import。
+ - 只有 Mockito,junit `Assertions`,hamcrest `CoreMatchers` 和 `MatcherAssert` 相关可以使用 static import。
- 数据断言规范应遵循:
- 布尔类型断言应使用 `assertTrue` 和 `assertFalse`;
- 空值断言应使用 `assertNull` 和 `assertNotNull`;
diff --git a/docs/community/content/involved/conduct/code.en.md b/docs/community/content/involved/conduct/code.en.md
index 351c7108721..b6311d542a9 100644
--- a/docs/community/content/involved/conduct/code.en.md
+++ b/docs/community/content/involved/conduct/code.en.md
@@ -77,7 +77,7 @@ The following code of conduct is based on full compliance with [ASF CODE OF COND
- Test cases should be fully covered expect simply `getter /setter` methods, and declared static codes of SPI, such as: `getType / getOrder`.
- Every test case need precised assertion, try not to use `not`, `containsString` to make assertions.
- Environment preparation codes should be separate from test codes.
- - Only those that relate to `Mockito`, junit `Assert`, hamcrest `CoreMatchers` and `MatcherAssert` can use static import.
+ - Only those that relate to `Mockito`, junit `Assertions`, hamcrest `CoreMatchers` and `MatcherAssert` can use static import.
- Usage of assertion methods: for boolean type asserts, `assertTrue` and `assertFalse` should be used, `assertNull` and `assertNotNull` should be used to assert whether the assertion is null, and `assertThat` should be used for other scenarios.
- Usage of assertion methods:
- Use `assertTrue` and `assertFalse` for boolean value;