You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Benoit Sigoure (JIRA)" <ji...@apache.org> on 2011/08/21 04:37:27 UTC
[jira] [Created] (HBASE-4237) Directly remove the call being
handled from the map of outstanding RPCs
Directly remove the call being handled from the map of outstanding RPCs
-----------------------------------------------------------------------
Key: HBASE-4237
URL: https://issues.apache.org/jira/browse/HBASE-4237
Project: HBase
Issue Type: Improvement
Components: ipc
Affects Versions: 0.90.4
Reporter: Benoit Sigoure
Assignee: Benoit Sigoure
Priority: Minor
The client has to maintain a map of RPC ID to `Call' object for this RPC, for every outstanding RPC. When receiving a response, the client was getting the `Call' out of the map (one O(log n) operation) and then removing it from the map (another O(log n) operation). There is no benefit in not removing it directly from the map.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4237) Directly remove the call being
handled from the map of outstanding RPCs
Posted by "Benoit Sigoure (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088299#comment-13088299 ]
Benoit Sigoure commented on HBASE-4237:
---------------------------------------
Patch @ https://github.com/tsuna/hbase/commit/1f602391ee4cd3d11eaf3067208caeadf214b3a8
> Directly remove the call being handled from the map of outstanding RPCs
> -----------------------------------------------------------------------
>
> Key: HBASE-4237
> URL: https://issues.apache.org/jira/browse/HBASE-4237
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.90.4
> Reporter: Benoit Sigoure
> Assignee: Benoit Sigoure
> Priority: Minor
>
> The client has to maintain a map of RPC ID to `Call' object for this RPC, for every outstanding RPC. When receiving a response, the client was getting the `Call' out of the map (one O(log n) operation) and then removing it from the map (another O(log n) operation). There is no benefit in not removing it directly from the map.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4237) Directly remove the call being
handled from the map of outstanding RPCs
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089005#comment-13089005 ]
Ted Yu commented on HBASE-4237:
-------------------------------
Integrated to TRUNK.
Thanks for the patch Benoit.
> Directly remove the call being handled from the map of outstanding RPCs
> -----------------------------------------------------------------------
>
> Key: HBASE-4237
> URL: https://issues.apache.org/jira/browse/HBASE-4237
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.90.4
> Reporter: Benoit Sigoure
> Assignee: Benoit Sigoure
> Priority: Minor
>
> The client has to maintain a map of RPC ID to `Call' object for this RPC, for every outstanding RPC. When receiving a response, the client was getting the `Call' out of the map (one O(log n) operation) and then removing it from the map (another O(log n) operation). There is no benefit in not removing it directly from the map.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4237) Directly remove the call being
handled from the map of outstanding RPCs
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088304#comment-13088304 ]
Ted Yu commented on HBASE-4237:
-------------------------------
+1 on patch.
> Directly remove the call being handled from the map of outstanding RPCs
> -----------------------------------------------------------------------
>
> Key: HBASE-4237
> URL: https://issues.apache.org/jira/browse/HBASE-4237
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.90.4
> Reporter: Benoit Sigoure
> Assignee: Benoit Sigoure
> Priority: Minor
>
> The client has to maintain a map of RPC ID to `Call' object for this RPC, for every outstanding RPC. When receiving a response, the client was getting the `Call' out of the map (one O(log n) operation) and then removing it from the map (another O(log n) operation). There is no benefit in not removing it directly from the map.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4237) Directly remove the call being
handled from the map of outstanding RPCs
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089194#comment-13089194 ]
Hudson commented on HBASE-4237:
-------------------------------
Integrated in HBase-TRUNK #2130 (See [https://builds.apache.org/job/HBase-TRUNK/2130/])
HBASE-4237 Directly remove the call being handled from the map of outstanding RPCs
(Benoit Sigoure)
tedyu :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
> Directly remove the call being handled from the map of outstanding RPCs
> -----------------------------------------------------------------------
>
> Key: HBASE-4237
> URL: https://issues.apache.org/jira/browse/HBASE-4237
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.90.4
> Reporter: Benoit Sigoure
> Assignee: Benoit Sigoure
> Priority: Minor
>
> The client has to maintain a map of RPC ID to `Call' object for this RPC, for every outstanding RPC. When receiving a response, the client was getting the `Call' out of the map (one O(log n) operation) and then removing it from the map (another O(log n) operation). There is no benefit in not removing it directly from the map.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4237) Directly remove the call being
handled from the map of outstanding RPCs
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu resolved HBASE-4237.
---------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
> Directly remove the call being handled from the map of outstanding RPCs
> -----------------------------------------------------------------------
>
> Key: HBASE-4237
> URL: https://issues.apache.org/jira/browse/HBASE-4237
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.90.4
> Reporter: Benoit Sigoure
> Assignee: Benoit Sigoure
> Priority: Minor
>
> The client has to maintain a map of RPC ID to `Call' object for this RPC, for every outstanding RPC. When receiving a response, the client was getting the `Call' out of the map (one O(log n) operation) and then removing it from the map (another O(log n) operation). There is no benefit in not removing it directly from the map.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira