You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Mladen Turk <mt...@apache.org> on 2008/05/19 06:32:34 UTC
Backporting r657500
Any problems I backport the
http://svn.apache.org/viewvc?rev=657500&view=rev
to 1.2 and 1.3 ?
Regards
--
^(TM)
Re: Backporting r657500
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Mladen Turk wrote:
> "The pool cleanup of apr_shm_create (apr_shm_destroy)
> also removes the named resource"
> Now this is not true for win32, because the created
> file never gets deleted afterwards, so IMHO this
> should be fixed by actually deleting the mapping file
> in shm_cleanup (distinguishing create/attach of course)
+1!
Re: Backporting r657500
Posted by Mladen Turk <mt...@apache.org>.
William A. Rowe, Jr. wrote:
> Mladen Turk wrote:
>> Any problems I backport the
>> http://svn.apache.org/viewvc?rev=657500&view=rev
>> to 1.2 and 1.3 ?
>
> I'm only worried about misuse; could you add a doxygen note that removing
> the shm while in-use is absolutely not portable?
>
Think that docs clearly state that its not portable.
However I'm more worried about the following statement:
"The pool cleanup of apr_shm_create (apr_shm_destroy)
also removes the named resource"
Now this is not true for win32, because the created
file never gets deleted afterwards, so IMHO this
should be fixed by actually deleting the mapping file
in shm_cleanup (distinguishing create/attach of course)
Regards
--
^(TM)
Re: Backporting r657500
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Mladen Turk wrote:
> Any problems I backport the
> http://svn.apache.org/viewvc?rev=657500&view=rev
> to 1.2 and 1.3 ?
I'm only worried about misuse; could you add a doxygen note that removing
the shm while in-use is absolutely not portable?
Otherwise no issues with adding an implementation - please do! (Actually
backporting to 1.3 should be sufficient, it seems the list believes we are
done with the 1.2 branch).
Bill