You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by cs...@apache.org on 2018/08/21 16:02:21 UTC
svn commit: r1838564 - in
/felix/trunk/systemready/src/main/java/org/apache/felix/systemready:
CheckStatus.java impl/servlet/StatusWriterJson.java
Author: cschneider
Date: Tue Aug 21 16:02:20 2018
New Revision: 1838564
URL: http://svn.apache.org/viewvc?rev=1838564&view=rev
Log:
Make classes immutable and more private
Modified:
felix/trunk/systemready/src/main/java/org/apache/felix/systemready/CheckStatus.java
felix/trunk/systemready/src/main/java/org/apache/felix/systemready/impl/servlet/StatusWriterJson.java
Modified: felix/trunk/systemready/src/main/java/org/apache/felix/systemready/CheckStatus.java
URL: http://svn.apache.org/viewvc/felix/trunk/systemready/src/main/java/org/apache/felix/systemready/CheckStatus.java?rev=1838564&r1=1838563&r2=1838564&view=diff
==============================================================================
--- felix/trunk/systemready/src/main/java/org/apache/felix/systemready/CheckStatus.java (original)
+++ felix/trunk/systemready/src/main/java/org/apache/felix/systemready/CheckStatus.java Tue Aug 21 16:02:20 2018
@@ -22,13 +22,12 @@ import static java.util.stream.Collector
import java.util.stream.Stream;
-public class CheckStatus {
- // Be aware that the order of the enum declarations matters for the Comparator
- public enum State { RED, YELLOW, GREEN;
- /**
- * returns {{GREEN}} for {{true}} and {{YELLOW}} for {{false}}
- */
- public static State fromBoolean(boolean ready) {
+public final class CheckStatus {
+ public enum State {
+ // Be aware that the order of the enum declarations matters for the Comparator
+ RED, YELLOW, GREEN;
+
+ public static State fromBoolean(boolean ready) {
return (ready) ? State.GREEN : State.YELLOW;
}
@@ -37,13 +36,13 @@ public class CheckStatus {
}
}
- private String checkName;
+ private final String checkName;
- private StateType type;
+ private final StateType type;
- private State state;
+ private final State state;
- private String details;
+ private final String details;
public CheckStatus(String checkName, StateType type, State state, String details) {
this.checkName = checkName;
Modified: felix/trunk/systemready/src/main/java/org/apache/felix/systemready/impl/servlet/StatusWriterJson.java
URL: http://svn.apache.org/viewvc/felix/trunk/systemready/src/main/java/org/apache/felix/systemready/impl/servlet/StatusWriterJson.java?rev=1838564&r1=1838563&r2=1838564&view=diff
==============================================================================
--- felix/trunk/systemready/src/main/java/org/apache/felix/systemready/impl/servlet/StatusWriterJson.java (original)
+++ felix/trunk/systemready/src/main/java/org/apache/felix/systemready/impl/servlet/StatusWriterJson.java Tue Aug 21 16:02:20 2018
@@ -24,7 +24,7 @@ import java.util.stream.Collectors;
import org.apache.felix.systemready.CheckStatus;
import org.apache.felix.systemready.SystemStatus;
-public class StatusWriterJson {
+class StatusWriterJson {
private PrintWriter writer;