You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Simon Willnauer (Created) (JIRA)" <ji...@apache.org> on 2011/11/24 20:30:40 UTC
[jira] [Created] (LUCENE-3592) Make BytesRef#startsWith &
BytesRef#endsWith static
Make BytesRef#startsWith & BytesRef#endsWith static
---------------------------------------------------
Key: LUCENE-3592
URL: https://issues.apache.org/jira/browse/LUCENE-3592
Project: Lucene - Java
Issue Type: Sub-task
Affects Versions: 4.0
Reporter: Simon Willnauer
Priority: Minor
Fix For: 4.0
BytesRef#startsWith & endsWith should be static those are really utilities.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3592) Make BytesRef#startsWith &
BytesRef#endsWith static
Posted by "Simon Willnauer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer updated LUCENE-3592:
------------------------------------
Attachment: LUCENE-3592.patch
next iteration cutting over bytesDifference(byte[], int, int, byte[], int, int) to bytesDifference(BytesRef, BytesRef), I think this is ready
> Make BytesRef#startsWith & BytesRef#endsWith static
> ---------------------------------------------------
>
> Key: LUCENE-3592
> URL: https://issues.apache.org/jira/browse/LUCENE-3592
> Project: Lucene - Java
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3592.patch, LUCENE-3592.patch, LUCENE-3592.patch
>
>
> BytesRef#startsWith & endsWith should be static those are really utilities.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3592) Make BytesRef#startsWith &
BytesRef#endsWith static
Posted by "Simon Willnauer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer updated LUCENE-3592:
------------------------------------
Attachment: LUCENE-3592.patch
moving startsWith & endsWith to StringHelper
> Make BytesRef#startsWith & BytesRef#endsWith static
> ---------------------------------------------------
>
> Key: LUCENE-3592
> URL: https://issues.apache.org/jira/browse/LUCENE-3592
> Project: Lucene - Java
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3592.patch, LUCENE-3592.patch
>
>
> BytesRef#startsWith & endsWith should be static those are really utilities.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3592) Make BytesRef#startsWith &
BytesRef#endsWith static
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157500#comment-13157500 ]
Robert Muir commented on LUCENE-3592:
-------------------------------------
maybe these should go in StringHelper? This is where things like bytesDifference() already are.
> Make BytesRef#startsWith & BytesRef#endsWith static
> ---------------------------------------------------
>
> Key: LUCENE-3592
> URL: https://issues.apache.org/jira/browse/LUCENE-3592
> Project: Lucene - Java
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3592.patch
>
>
> BytesRef#startsWith & endsWith should be static those are really utilities.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3592) Make BytesRef#startsWith &
BytesRef#endsWith static
Posted by "Simon Willnauer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157589#comment-13157589 ]
Simon Willnauer commented on LUCENE-3592:
-----------------------------------------
yeah that is maybe a better place... I think eventually we want to rename StringHelper into BytesRefHelper or something else. Since really all those methods should accept BytesRef instead bytes[]. I will attach a new patch moving it to StringHelper, keeping the name for now.
> Make BytesRef#startsWith & BytesRef#endsWith static
> ---------------------------------------------------
>
> Key: LUCENE-3592
> URL: https://issues.apache.org/jira/browse/LUCENE-3592
> Project: Lucene - Java
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3592.patch, LUCENE-3592.patch
>
>
> BytesRef#startsWith & endsWith should be static those are really utilities.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3592) Make BytesRef#startsWith &
BytesRef#endsWith static
Posted by "Simon Willnauer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158018#comment-13158018 ]
Simon Willnauer commented on LUCENE-3592:
-----------------------------------------
I plan to commit this tomorrow...
> Make BytesRef#startsWith & BytesRef#endsWith static
> ---------------------------------------------------
>
> Key: LUCENE-3592
> URL: https://issues.apache.org/jira/browse/LUCENE-3592
> Project: Lucene - Java
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3592.patch, LUCENE-3592.patch, LUCENE-3592.patch
>
>
> BytesRef#startsWith & endsWith should be static those are really utilities.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (LUCENE-3592) Make BytesRef#startsWith &
BytesRef#endsWith static
Posted by "Simon Willnauer (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer reassigned LUCENE-3592:
---------------------------------------
Assignee: Simon Willnauer
> Make BytesRef#startsWith & BytesRef#endsWith static
> ---------------------------------------------------
>
> Key: LUCENE-3592
> URL: https://issues.apache.org/jira/browse/LUCENE-3592
> Project: Lucene - Java
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
>
> BytesRef#startsWith & endsWith should be static those are really utilities.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3592) Make BytesRef#startsWith &
BytesRef#endsWith static
Posted by "Simon Willnauer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157496#comment-13157496 ]
Simon Willnauer commented on LUCENE-3592:
-----------------------------------------
I will commit this later today if nobody objects
> Make BytesRef#startsWith & BytesRef#endsWith static
> ---------------------------------------------------
>
> Key: LUCENE-3592
> URL: https://issues.apache.org/jira/browse/LUCENE-3592
> Project: Lucene - Java
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3592.patch
>
>
> BytesRef#startsWith & endsWith should be static those are really utilities.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3592) Make BytesRef#startsWith &
BytesRef#endsWith static
Posted by "Simon Willnauer (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer resolved LUCENE-3592.
-------------------------------------
Resolution: Fixed
committed to trunk in revision 1207564
> Make BytesRef#startsWith & BytesRef#endsWith static
> ---------------------------------------------------
>
> Key: LUCENE-3592
> URL: https://issues.apache.org/jira/browse/LUCENE-3592
> Project: Lucene - Java
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3592.patch, LUCENE-3592.patch, LUCENE-3592.patch
>
>
> BytesRef#startsWith & endsWith should be static those are really utilities.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3592) Make BytesRef#startsWith &
BytesRef#endsWith static
Posted by "Simon Willnauer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer updated LUCENE-3592:
------------------------------------
Attachment: LUCENE-3592.patch
here is a patch converting all uses of startsWith & endsWith + javadocs
> Make BytesRef#startsWith & BytesRef#endsWith static
> ---------------------------------------------------
>
> Key: LUCENE-3592
> URL: https://issues.apache.org/jira/browse/LUCENE-3592
> Project: Lucene - Java
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3592.patch
>
>
> BytesRef#startsWith & endsWith should be static those are really utilities.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org