Re: [PR] fix: Preserve user error classification from data servers (druid)

["BackendArchitectX (via GitHub)" <gi...@apache.org>]

BackendArchitectX commented on code in PR #20633:
URL: https://github.com/apache/druid/pull/20633#discussion_r4330823302


##########
processing/src/test/java/org/apache/druid/query/groupby/GroupByQueryRunnerFailureTest.java:
##########
@@ -340,6 +342,53 @@
     Assertions.assertEquals("Query [test] timed out", ex.getMessage());
   }
 
+  @Test
+  @org.junit.jupiter.api.Timeout(value = 60_000L, unit = java.util.concurrent.TimeUnit.MILLISECONDS)
+  public void testInvalidInputExceptionOnQueryable_multiThreaded()
+  {
+    final GroupByQuery query = GroupByQuery
+        .builder()
+        .setDataSource(QueryRunnerTestHelper.DATA_SOURCE)
+        .setQuerySegmentSpec(QueryRunnerTestHelper.FIRST_TO_THIRD)
+        .setDimensions(new DefaultDimensionSpec("quality", "alias"))
+        .setAggregatorSpecs(new LongSumAggregatorFactory("rows", "rows"))
+        .setGranularity(Granularities.ALL)
+        .queryId("test-invalid-input")
+        .build();
+
+    GroupByQueryRunnerFactory factory = makeQueryRunnerFactory(
+        GroupByQueryRunnerTest.DEFAULT_MAPPER,
+        new GroupByQueryConfig()
+        {
+          @Override
+          public boolean isSingleThreaded()
+          {
+            return false;
+          }
+        }
+    );
+
+    DruidException expected = InvalidInput.exception(
+        "Projection[p] specified, but does not satisfy query"
+    );
+
+    QueryRunner<ResultRow> failingRunner = (queryPlus, responseContext) -> {
+      throw expected;
+    };
+
+    QueryRunner<ResultRow> mergeRunners = factory.mergeRunners(
+        Execs.directExecutor(),
+        List.of(runner, failingRunner)
+    );

Review Comment:
   @FrankChen021 The deprecated overload has been replaced with the `QueryProcessingPool` overload in commit `9a0db488a5`.
   
   The fix is pushed, but the latest CodeQL workflow is awaiting approval to run. Could you please approve the pending workflow when convenient so the updated code can be validated?
   
   Thank you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org