[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4072: [TE] detection - handle day light savings time in moving windows

[GitBox <gi...@apache.org>]

jihaozh commented on a change in pull request #4072: [TE] detection - handle day light savings time in moving windows
URL: https://github.com/apache/incubator-pinot/pull/4072#discussion_r272287501
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrapper/AnomalyDetectorWrapper.java
 ##########
 @@ -151,7 +152,7 @@ public DetectionPipelineResult run() throws Exception {
     // 1. get the last time stamp for the time series.
     // 2. to calculate current values and  baseline values for the anomalies detected
     // 3. anomaly detection current and baseline time series value
-    if( this.cachingPeriodLookback > 0) {
+    if (this.cachingPeriodLookback >= 0) {
 
 Review comment:
   Not necessarily. If it's 0, i.e. the cache look back is 0, which means it only caches current time series. If it's negative, then it means the cache is turned off.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org