You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Xiaomeng Zhang (Code Review)" <ge...@cloudera.org> on 2020/03/30 22:44:29 UTC

[Impala-ASF-CR] IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly 

Xiaomeng Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15607


Change subject: IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly
......................................................................

IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly

In secure env with high concurrency, queries that call builtin function
randomly fails with function unknown error. For example,
"AnalysisException: trim() unknown".
Adding more info in exception message to help debugging when it happens
again.

Change-Id: I30d6eb697695da8d2521acb76d8310ec8f1bbda9
---
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/15607/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30d6eb697695da8d2521acb76d8310ec8f1bbda9
Gerrit-Change-Number: 15607
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>

[Impala-ASF-CR] IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15607 )

Change subject: IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly
......................................................................


Patch Set 3: Code-Review+2

LGTM, thanks


-- 
To view, visit http://gerrit.cloudera.org:8080/15607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30d6eb697695da8d2521acb76d8310ec8f1bbda9
Gerrit-Change-Number: 15607
Gerrit-PatchSet: 3
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Apr 2020 15:26:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15607 )

Change subject: IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5659/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30d6eb697695da8d2521acb76d8310ec8f1bbda9
Gerrit-Change-Number: 15607
Gerrit-PatchSet: 3
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Mar 2020 17:15:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15607 )

Change subject: IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly
......................................................................

IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly

In secure env with high concurrency, queries that call builtin function
randomly fail when trying to find the function. For example,
"AnalysisException: trim() unknown".
Adding more info in exception message to help debugging when it happens
again.

Change-Id: I30d6eb697695da8d2521acb76d8310ec8f1bbda9
Reviewed-on: http://gerrit.cloudera.org:8080/15607
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I30d6eb697695da8d2521acb76d8310ec8f1bbda9
Gerrit-Change-Number: 15607
Gerrit-PatchSet: 5
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15607 )

Change subject: IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30d6eb697695da8d2521acb76d8310ec8f1bbda9
Gerrit-Change-Number: 15607
Gerrit-PatchSet: 4
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Apr 2020 19:15:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15607 )

Change subject: IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5598/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30d6eb697695da8d2521acb76d8310ec8f1bbda9
Gerrit-Change-Number: 15607
Gerrit-PatchSet: 4
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Apr 2020 19:15:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15607 )

Change subject: IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly
......................................................................


Patch Set 2:

(2 comments)

I have a couple of small linguistic suggestions, otherwise this looks good.

http://gerrit.cloudera.org:8080/#/c/15607/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15607/2//COMMIT_MSG@10
PS2, Line 10: randomly fails with function unknown error. For example,
Nit: randomly fail when trying to find the function. For example,"


http://gerrit.cloudera.org:8080/#/c/15607/2/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
File fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java:

http://gerrit.cloudera.org:8080/#/c/15607/2/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@494
PS2, Line 494:           + ". Currently this db has function number " + db.numFunctions());
Slighly clearer:  
". Currently this db has " + db.numFunctions() + " functions.");



-- 
To view, visit http://gerrit.cloudera.org:8080/15607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30d6eb697695da8d2521acb76d8310ec8f1bbda9
Gerrit-Change-Number: 15607
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Mar 2020 00:57:40 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15607 )

Change subject: IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/5651/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30d6eb697695da8d2521acb76d8310ec8f1bbda9
Gerrit-Change-Number: 15607
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Mar 2020 23:25:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15607 )

Change subject: IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30d6eb697695da8d2521acb76d8310ec8f1bbda9
Gerrit-Change-Number: 15607
Gerrit-PatchSet: 4
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Apr 2020 23:41:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly

Posted by "Xiaomeng Zhang (Code Review)" <ge...@cloudera.org>.
Xiaomeng Zhang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15607 )

Change subject: IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly
......................................................................

IMPALA-9483 Add logs for debugging builtin functions throw unknown exception randomly

In secure env with high concurrency, queries that call builtin function
randomly fail when trying to find the function. For example,
"AnalysisException: trim() unknown".
Adding more info in exception message to help debugging when it happens
again.

Change-Id: I30d6eb697695da8d2521acb76d8310ec8f1bbda9
---
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/15607/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15607
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30d6eb697695da8d2521acb76d8310ec8f1bbda9
Gerrit-Change-Number: 15607
Gerrit-PatchSet: 3
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>