You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "XuNeo (via GitHub)" <gi...@apache.org> on 2024/07/09 03:24:05 UTC
[PR] arch/arm64: allow to use custom up_idle [nuttx]
XuNeo opened a new pull request, #12648:
URL: https://github.com/apache/nuttx/pull/12648
## Summary
Remove not used `arm64_cpu_idle.S`.
Respect `CONFIG_ARCH_IDLE_CUSTOM`
## Impact
No.
## Testing
qemu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm64: allow to use custom up_idle [nuttx]
Posted by "XuNeo (via GitHub)" <gi...@apache.org>.
XuNeo commented on code in PR #12648:
URL: https://github.com/apache/nuttx/pull/12648#discussion_r1669797313
##########
arch/arm64/src/common/CMakeLists.txt:
##########
@@ -47,6 +46,10 @@ list(APPEND SRCS arm64_syscall.c)
# Use common heap allocation for now (may need to be customized later)
list(APPEND SRCS arm64_allocateheap.c)
+if(not CONFIG_ARCH_IDLE_CUSTOM)
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm64: allow to use custom up_idle [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #12648:
URL: https://github.com/apache/nuttx/pull/12648#discussion_r1669722519
##########
arch/arm64/src/common/CMakeLists.txt:
##########
@@ -47,6 +46,10 @@ list(APPEND SRCS arm64_syscall.c)
# Use common heap allocation for now (may need to be customized later)
list(APPEND SRCS arm64_allocateheap.c)
+if(not CONFIG_ARCH_IDLE_CUSTOM)
Review Comment:
Have you tested your commits internally? Please run all tests in vela before submitting to community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm64: allow to use custom up_idle [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao merged PR #12648:
URL: https://github.com/apache/nuttx/pull/12648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org