You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org> on 2026/10/06 08:51:30 UTC

[Impala-ASF-CR] IMPALA-15488: Fix integer TRUNC and ROUND calls in Calcite planner

Hello Steve Carlin, Michael Smith,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/25026

to review the following change.


Change subject: IMPALA-15488: Fix integer TRUNC and ROUND calls in Calcite planner
......................................................................

IMPALA-15488: Fix integer TRUNC and ROUND calls in Calcite planner

Use DOUBLE for one-argument integer calls. For explicit scale, cast the integer operand to its minimum-resolution DECIMAL and clamp the result scale. Preserve existing FLOAT/DOUBLE and DECIMAL behavior.

Validation: 24 focused FE tests and 80 Original/Calcite HS2 checks with codegen off/on (DECIMAL V2).

Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Assisted-by: GPT-6 (Codex)
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAdjustScaleFunction.java
A java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteIntegerScaleTest.java
3 files changed, 111 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/25026/1
-- 
To view, visit http://gerrit.cloudera.org:8080/25026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Gerrit-Change-Number: 25026
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>

[Impala-ASF-CR] IMPALA-15488: Fix Calcite integer scale calls

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/25026 )

Change subject: IMPALA-15488: Fix Calcite integer scale calls
......................................................................


Patch Set 5: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/25026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Gerrit-Change-Number: 25026
Gerrit-PatchSet: 5
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Oct 2026 18:57:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15488: Fix Calcite integer scale calls

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/25026 )

Change subject: IMPALA-15488: Fix Calcite integer scale calls
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/25026/4/tests/query_test/test_calcite_planner.py
File tests/query_test/test_calcite_planner.py:

http://gerrit.cloudera.org:8080/#/c/25026/4/tests/query_test/test_calcite_planner.py@84
PS4, Line 84:   def test_integer_scale_functions(self, vector, unique_database):
This seems a bit out of sync with how we are testing everything else.

We can probably just put the "calcite-integer-scale" file into test_exprs.py

This will get tested by the original planner with the normal precommit runs.  We do have a special run for Calcite...this is not run pre-commit, yet, but we do monitor it post-commit.  As the Calcite planner matures, it eventually will be run pre-commit.

So I think just making this a normal test would be just fine and if you test it manually pre-commit, we should be good.



-- 
To view, visit http://gerrit.cloudera.org:8080/25026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Gerrit-Change-Number: 25026
Gerrit-PatchSet: 4
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Oct 2026 14:09:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15488: Fix Calcite integer scale calls

Posted by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org>.
Hello Steve Carlin, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/25026

to look at the new patch set (#4).

Change subject: IMPALA-15488: Fix Calcite integer scale calls
......................................................................

IMPALA-15488: Fix Calcite integer scale calls

Use DOUBLE for one-argument integer calls. For explicit scale, cast
integer operands to their minimum-resolution DECIMAL and clamp the
result scale. Preserve existing FLOAT/DOUBLE and DECIMAL behavior.

Add one shared QueryTest file for Original and Calcite across integer
types and scales, including NULLs, zero and negative values. Reuse its
queries to compare full HS2 result schemas with fallback disabled.

Testing: focused pytest passed with both planners. The shared test
fails on the parent during integer scale planning.
Full upstream precommit remains unverified.

Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAdjustScaleFunction.java
A java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteIntegerScaleTest.java
A testdata/workloads/functional-query/queries/QueryTest/calcite-integer-scale.test
M tests/query_test/test_calcite_planner.py
5 files changed, 316 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/25026/4
-- 
To view, visit http://gerrit.cloudera.org:8080/25026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Gerrit-Change-Number: 25026
Gerrit-PatchSet: 4
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>

[Impala-ASF-CR] IMPALA-15488: Fix Calcite integer scale calls

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25026 )

Change subject: IMPALA-15488: Fix Calcite integer scale calls
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24446/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/25026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Gerrit-Change-Number: 25026
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Oct 2026 08:55:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15488: Fix Calcite integer scale calls

Posted by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org>.
Hello Steve Carlin, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/25026

to look at the new patch set (#2).

Change subject: IMPALA-15488: Fix Calcite integer scale calls
......................................................................

IMPALA-15488: Fix Calcite integer scale calls

Use DOUBLE for one-argument integer calls. For explicit scale, cast
integer operands to their minimum-resolution DECIMAL and clamp the
result scale. Preserve existing FLOAT/DOUBLE and DECIMAL behavior.

Add one shared QueryTest file for Original and Calcite across integer
types and scales, including NULLs, zero and negative values. Reuse its
queries to compare full HS2 result schemas with fallback disabled.

Testing: focused pytest passed with both planners. The shared test
fails on the parent during integer scale planning.
Full upstream precommit remains unverified.

Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAdjustScaleFunction.java
A java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteIntegerScaleTest.java
A testdata/workloads/functional-query/queries/QueryTest/calcite-integer-scale.test
M tests/query_test/test_calcite_planner.py
5 files changed, 316 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/25026/2
-- 
To view, visit http://gerrit.cloudera.org:8080/25026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Gerrit-Change-Number: 25026
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>

[Impala-ASF-CR] IMPALA-15488: Fix Calcite integer scale calls

Posted by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org>.
Aleksandr Efimov has posted comments on this change. ( https://gerrit.cloudera.org/25026 )

Change subject: IMPALA-15488: Fix Calcite integer scale calls
......................................................................


Patch Set 5:

Gentle ping.


-- 
To view, visit https://gerrit.cloudera.org/25026
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Gerrit-Change-Number: 25026
Gerrit-PatchSet: 5
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Nov 2026 08:59:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15488: Fix Calcite integer scale calls

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25026 )

Change subject: IMPALA-15488: Fix Calcite integer scale calls
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24506/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/25026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Gerrit-Change-Number: 25026
Gerrit-PatchSet: 4
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Oct 2026 16:03:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15488: Fix Calcite integer scale calls

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25026 )

Change subject: IMPALA-15488: Fix Calcite integer scale calls
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24729/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/25026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Gerrit-Change-Number: 25026
Gerrit-PatchSet: 5
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Oct 2026 18:42:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15488: Fix Calcite integer scale calls

Posted by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org>.
Hello Steve Carlin, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/25026

to look at the new patch set (#3).

Change subject: IMPALA-15488: Fix Calcite integer scale calls
......................................................................

IMPALA-15488: Fix Calcite integer scale calls

Use DOUBLE for one-argument integer calls. For explicit scale, cast
integer operands to their minimum-resolution DECIMAL and clamp the
result scale. Preserve existing FLOAT/DOUBLE and DECIMAL behavior.

Add one shared QueryTest file for Original and Calcite across integer
types and scales, including NULLs, zero and negative values. Reuse its
queries to compare full HS2 result schemas with fallback disabled.

Testing: focused pytest passed with both planners. The shared test
fails on the parent during integer scale planning.
Full upstream precommit remains unverified.

Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Assisted-by: GPT-6 (Codex)
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAdjustScaleFunction.java
A java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteIntegerScaleTest.java
A testdata/workloads/functional-query/queries/QueryTest/calcite-integer-scale.test
M tests/query_test/test_calcite_planner.py
5 files changed, 316 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/25026/3
-- 
To view, visit http://gerrit.cloudera.org:8080/25026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Gerrit-Change-Number: 25026
Gerrit-PatchSet: 3
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>

[Impala-ASF-CR] IMPALA-15488: Fix integer TRUNC and ROUND calls in Calcite planner

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25026 )

Change subject: IMPALA-15488: Fix integer TRUNC and ROUND calls in Calcite planner
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24344/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/25026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Gerrit-Change-Number: 25026
Gerrit-PatchSet: 1
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Oct 2026 09:17:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15488: Fix Calcite integer scale calls

Posted by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org>.
Hello Steve Carlin, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/25026

to look at the new patch set (#5).

Change subject: IMPALA-15488: Fix Calcite integer scale calls
......................................................................

IMPALA-15488: Fix Calcite integer scale calls

Use DOUBLE for one-argument integer calls. For explicit scale, cast
integer operands to their minimum-resolution DECIMAL and clamp the
result scale. Preserve existing FLOAT/DOUBLE and DECIMAL behavior.

Add SQL regression cases to the shared expression suite. Keep exact
result metadata parity checks in CalciteIntegerScaleTest.

Testing: QueryTest parsing, four integer metadata tests, and eight
DECIMAL metadata tests with both planners.

Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAdjustScaleFunction.java
A java/calcite-planner/src/test/java/org/apache/impala/calcite/service/CalciteIntegerScaleTest.java
A testdata/workloads/functional-query/queries/QueryTest/integer-scale.test
M tests/query_test/test_exprs.py
5 files changed, 264 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/25026/5
-- 
To view, visit http://gerrit.cloudera.org:8080/25026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Gerrit-Change-Number: 25026
Gerrit-PatchSet: 5
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>

[Impala-ASF-CR] IMPALA-15488: Fix Calcite integer scale calls

Posted by "Aleksandr Efimov (Code Review)" <ge...@cloudera.org>.
Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/25026 )

Change subject: IMPALA-15488: Fix Calcite integer scale calls
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/25026/4/tests/query_test/test_calcite_planner.py
File tests/query_test/test_calcite_planner.py:

http://gerrit.cloudera.org:8080/#/c/25026/4/tests/query_test/test_calcite_planner.py@84
PS4, Line 84:   def test_integer_scale_functions(self, vector, unique_database):
> This seems a bit out of sync with how we are testing everything else.
Moved the SQL tests to TestExprs in PS5. Both planners passed with fallback disabled.



-- 
To view, visit http://gerrit.cloudera.org:8080/25026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d66850c7de4c04bacbac9f1470e313abdc3ea3c
Gerrit-Change-Number: 25026
Gerrit-PatchSet: 4
Gerrit-Owner: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Aleksandr Efimov <dz...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Oct 2026 18:18:13 +0000
Gerrit-HasComments: Yes