You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by "Riggs333 (via GitHub)" <gi...@apache.org> on 2024/11/21 21:29:34 UTC
[PR] Java features should be preferred to Guava [cxf]
Riggs333 opened a new pull request, #2160:
URL: https://github.com/apache/cxf/pull/2160
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CXF-9085: Java features should be preferred to Guava [cxf]
Posted by "Riggs333 (via GitHub)" <gi...@apache.org>.
Riggs333 commented on PR #2160:
URL: https://github.com/apache/cxf/pull/2160#issuecomment-2494022541
I'm very sorry, @ffang, for my stupid mistake. 🤦🏻
I just pushed some changes, those were suggested by applying the OpenRewrite recipe:
https://docs.openrewrite.org/recipes/java/migrate/guava/noguavacreatetempdir
(The root of my mistake was this: The `mvn install` run on my local Linux machine with a fresh git checkout of the `main` branch was not running some tests successfully. Therefore I tried using the Github online codespaces IDE. With that I didn't see the compile error. I was very naive. 😓)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Java features should be preferred to Guava [cxf]
Posted by "Riggs333 (via GitHub)" <gi...@apache.org>.
Riggs333 commented on PR #2160:
URL: https://github.com/apache/cxf/pull/2160#issuecomment-2492491329
Hi @ffang,
thank you for your quick response! 🙏🏻
I just created https://issues.apache.org/jira/browse/CXF-9085.
Please feel free to adjust it to whatever it needs to be. (I'm not sure about what to fill in the fields for components, labels, etc.)
Thomas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CXF-9085: Java features should be preferred to Guava [cxf]
Posted by "ffang (via GitHub)" <gi...@apache.org>.
ffang commented on PR #2160:
URL: https://github.com/apache/cxf/pull/2160#issuecomment-2493827953
Hi @Riggs333 ,
We can't compile with your PR.
Seems java.nio.file.Files.createTempDirectory method requires a parameter list while com.google.common.io.Files.createTempDir method doesn't. Do you mind revising your PR accordingly?
Thanks!
Freeman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CXF-9085: Java features should be preferred to Guava [cxf]
Posted by "ffang (via GitHub)" <gi...@apache.org>.
ffang merged PR #2160:
URL: https://github.com/apache/cxf/pull/2160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Java features should be preferred to Guava [cxf]
Posted by "ffang (via GitHub)" <gi...@apache.org>.
ffang commented on PR #2160:
URL: https://github.com/apache/cxf/pull/2160#issuecomment-2492460587
Hi @Riggs333 ,
Thanks for contribution!
Could you please create a jira ticket for this issue?
Freeman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CXF-9085: Java features should be preferred to Guava [cxf]
Posted by "ffang (via GitHub)" <gi...@apache.org>.
ffang commented on PR #2160:
URL: https://github.com/apache/cxf/pull/2160#issuecomment-2494050246
No worries @Riggs333 , the PR looks good to me now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org