[GitHub] [incubator-kvrocks] tisonkun opened a new pull request, #830: refactor: unit/auth to gocase

[GitBox <gi...@apache.org>]

tisonkun opened a new pull request, #830:
URL: https://github.com/apache/incubator-kvrocks/pull/830

   This closes #829.
   
   This refers to #753. It contains changes for `src/redis_connection.cc`.
   
   `go-redis` writes:
   
   ```go
   func (c *baseClient) initConn(ctx context.Context, cn *pool.Conn) error {
   	// ...
   	if err := conn.Hello(ctx, 3, username, password, "").Err(); err == nil {
   		auth = true
   	} else if !strings.HasPrefix(err.Error(), "ERR unknown command") {
   		return err
   	}
   	// ...
   }
   ```
   
   But in `src/redis_connection.cc` we firstly check AUTH and later check unknown command so the `else if` branch hitted and return wrong `err`. I try to resolve it in Kvrocks scope but unsure what's the Redis manner.
   
   cc @git-hulk @vmihailenco


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] tisonkun merged pull request #830: refactor: unit/auth to gocase

[GitBox <gi...@apache.org>]

tisonkun merged PR #830:
URL: https://github.com/apache/incubator-kvrocks/pull/830


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org