[GitHub] [sling-org-apache-sling-jcr-resource] rombert commented on a change in pull request #8: [SLING-9417] Versioning support for nt:file as child of versioned node

[GitBox <gi...@apache.org>]

rombert commented on a change in pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/8#discussion_r420786797



##########
File path: src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java
##########
@@ -182,7 +183,10 @@ private InputStream getInputStream() {
             try {
                 // find the content node: for nt:file it is jcr:content
                 // otherwise it is the node of this resource
-                Node content = node.isNodeType(NT_FILE)
+                Node content = (node.isNodeType(NT_FILE) ||
+                                (node.isNodeType(JcrConstants.NT_FROZENNODE) &&
+                                 node.hasProperty(JcrConstants.JCR_FROZENPRIMARYTYPE) &&

Review comment:
       I think this is not necessary. `jcr:frozenPrimaryType` is mandatory and autocreated for `nt:frozenNode` https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.13.4.1%20nt:frozenNode




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org