[jira] [Resolved] (WICKET-6539) Scope fix for DataTable toolbars

["Sven Meier (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sven Meier resolved WICKET-6539.
--------------------------------
       Resolution: Fixed
         Assignee: Sven Meier
    Fix Version/s: 9.0.0

Accessors return a WebMarkupContainer now, so people can still add Behaviors or do whatever.

> Scope fix for DataTable toolbars
> --------------------------------
>
>                 Key: WICKET-6539
>                 URL: https://issues.apache.org/jira/browse/WICKET-6539
>             Project: Wicket
>          Issue Type: Wish
>          Components: wicket-extensions
>    Affects Versions: 8.0.0-M8
>            Reporter: Vít Rozkovec
>            Assignee: Sven Meier
>            Priority: Minor
>             Fix For: 9.0.0
>
>
> {{I've come across one inconsistency in the DataTable class:}}
> {{    /**}}
>  {{     * @return the container with the toolbars at the top}}
>  {{     */}}
>  {{    public final ToolbarsContainer getTopToolbars()}}
>  {{    {}}
>  {{        return topToolbars;}}
> {{    /**}}
>  {{     * @return the container with the toolbars at the bottom}}
>  {{     */}}
>  {{    public final ToolbarsContainer getBottomToolbars()}}
>  {{    {}}
>  {{        return bottomToolbars;}}
> ToolbarsContainer is defined as private, so those methods cannot be used anyway. I suggest either changing the visibility of ToolbarsContainer or removing those methods.
> {{ToolbarsContainer is defined as private, so those methods cannot be used anyway. I suggest either changing the visibility of ToolbarsContainer or removing those methods. I've searched for references and there are not any, though I came across one usecase where I needed to refresh toolbars after ajax update.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)