You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/02 12:30:10 UTC

[GitHub] [flink] JingsongLi opened a new pull request #11620: [FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X

JingsongLi opened a new pull request #11620: [FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X
URL: https://github.com/apache/flink/pull/11620
 
 
   
   ## What is the purpose of the change
   
   The sql-connector-hive modules added in FLINK-16455 use wildcards imports to exclude all transitive dependencies from hive.
   
   This is a maven 3.2.1+ feature. This may imply that Flink cannot be properly built anymore with maven 3.1 .
   
   ## Brief change log
   
   Just remove the exclusions.
   The shade-plugin will remove all transitive dependencies since promoteTransitiveDependencies is false.
   
   All declared dependencies are included in the artifactSet.
   
   ## Verifying this change
   
   This change is a trivial rework without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on issue #11620: [FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11620: [FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X
URL: https://github.com/apache/flink/pull/11620#issuecomment-608210790
 
 
   Merged #11620 to master.
   Thanks @lirui-apache for the review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11620: [FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11620: [FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X
URL: https://github.com/apache/flink/pull/11620#issuecomment-607827552
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4183021b37ce92be15170f2f4a666c3d28ce54b3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4183021b37ce92be15170f2f4a666c3d28ce54b3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4183021b37ce92be15170f2f4a666c3d28ce54b3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11620: [FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11620: [FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X
URL: https://github.com/apache/flink/pull/11620#issuecomment-607827552
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4183021b37ce92be15170f2f4a666c3d28ce54b3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6993",
       "triggerID" : "4183021b37ce92be15170f2f4a666c3d28ce54b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4183021b37ce92be15170f2f4a666c3d28ce54b3",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157808095",
       "triggerID" : "4183021b37ce92be15170f2f4a666c3d28ce54b3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4183021b37ce92be15170f2f4a666c3d28ce54b3 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157808095) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6993) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi merged pull request #11620: [FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X

Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #11620: [FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X
URL: https://github.com/apache/flink/pull/11620
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11620: [FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11620: [FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X
URL: https://github.com/apache/flink/pull/11620#issuecomment-607817969
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 4183021b37ce92be15170f2f4a666c3d28ce54b3 (Thu Apr 02 12:33:26 UTC 2020)
   
   **Warnings:**
    * **4 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11620: [FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11620: [FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X
URL: https://github.com/apache/flink/pull/11620#issuecomment-607827552
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4183021b37ce92be15170f2f4a666c3d28ce54b3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6993",
       "triggerID" : "4183021b37ce92be15170f2f4a666c3d28ce54b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4183021b37ce92be15170f2f4a666c3d28ce54b3",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157808095",
       "triggerID" : "4183021b37ce92be15170f2f4a666c3d28ce54b3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4183021b37ce92be15170f2f4a666c3d28ce54b3 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157808095) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6993) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11620: [FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11620: [FLINK-16885][hive] Remove wilcard excludes that don't work on maven 3.1.X
URL: https://github.com/apache/flink/pull/11620#issuecomment-607827552
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4183021b37ce92be15170f2f4a666c3d28ce54b3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6993",
       "triggerID" : "4183021b37ce92be15170f2f4a666c3d28ce54b3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4183021b37ce92be15170f2f4a666c3d28ce54b3",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157808095",
       "triggerID" : "4183021b37ce92be15170f2f4a666c3d28ce54b3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4183021b37ce92be15170f2f4a666c3d28ce54b3 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/157808095) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6993) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services