[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8280: [superset] Core SQLAlchemy query refactor

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #8280: [superset] Core SQLAlchemy query refactor
URL: https://github.com/apache/incubator-superset/pull/8280#discussion_r327282032
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -678,7 +678,7 @@ def store(self):
     def get_value(self, key_id):
         kv = None
         try:
-            kv = db.session.query(models.KeyValue).filter_by(id=key_id).one()
+            kv = db.session.query(models.KeyValue).get(key_id)
 
 Review comment:
   note to self, get does not raise an exception

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org