[jira] Reopened: (SHINDIG-654) Injecting feature javascript into head breaks caja

["Jasvir Nagra (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jasvir Nagra reopened SHINDIG-654:
----------------------------------


Attached patch to fully resolve the issue

> Injecting feature javascript into head breaks caja
> --------------------------------------------------
>
>                 Key: SHINDIG-654
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-654
>             Project: Shindig
>          Issue Type: Bug
>          Components: Features (Javascript), Gadget Rendering Server (Java)
>            Reporter: Jasvir Nagra
>            Assignee: Kevin Brown
>         Attachments: complete-valija-patch.txt, valija-upgrade-patch.txt
>
>
> The enableCaja function is currently implemented in container.js and called by opensocial-current/feature.xml.  The RenderingContentRewriter.injectFeatureLibraries(gadget, content) now adds javascript from feature.xml to the container <head> rather than the <body> as before.  As a result, when enableCaja is run, attachDocumentStub fails because document.body is null.
> The fix (discussed offline) is move caja specific code out of opensocial to CajaContentRewriter and to create the appropriate named <div> there directly in html.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.