[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #812: [core]Add streaming read from option (#778)

["JingsongLi (via GitHub)" <gi...@apache.org>]

JingsongLi commented on code in PR #812:
URL: https://github.com/apache/incubator-paimon/pull/812#discussion_r1156898337


##########
paimon-core/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -559,6 +559,23 @@ public class CoreOptions implements Serializable {
                     .withDescription(
                             "Full compaction will be constantly triggered after delta commits.");
 
+    public static final ConfigOption<StreamReadType> STREAMING_READ_FROM =
+            key("streaming-read-from")
+                    .enumType(StreamReadType.class)
+                    .defaultValue(StreamReadType.FILE_STORE)

Review Comment:
   default AUTO?
   log system configured: choose log-system.
   not configured: choose file file.



##########
paimon-core/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -1045,6 +1066,45 @@ public static FileFormatType fromValue(String value) {
         }
     }
 
+    /** Specifies the type for streaming read. */
+    public enum StreamReadType implements DescribedEnum {
+        LOG_STORE("log-store", "Read from log store such as kafka."),

Review Comment:
   `log-system` and `file`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org