You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/09 06:05:27 UTC

[GitHub] [airflow] milton0825 commented on a change in pull request #6311: [AIRFLOW-5615] Reduce duplicated logic around job heartbeating

milton0825 commented on a change in pull request #6311: [AIRFLOW-5615] Reduce duplicated logic around job heartbeating
URL: https://github.com/apache/airflow/pull/6311#discussion_r405974634
 
 

 ##########
 File path: airflow/jobs/base_job.py
 ##########
 @@ -147,7 +147,7 @@ def heartbeat_callback(self, session=None):
         Callback that is called during heartbeat. This method should be overwritten.
         """
 
-    def heartbeat(self):
+    def heartbeat(self, only_if_necessary=False):
 
 Review comment:
   Not sure why we need the `only_if_necessary` flag. Is it just for testing purpose?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services