You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/03/28 20:26:03 UTC

[GitHub] [arrow-datafusion] alamb commented on pull request #5686: remove duplicate the logic b/w DataFrame API and SQL planning

alamb commented on PR #5686:
URL: https://github.com/apache/arrow-datafusion/pull/5686#issuecomment-1487548446

   > Because when I started to remove the duplicate logic between the DataFrame API and SQL planning, I found that count_wildcard_rule did not cover all scenarios, such as union, window, etc.
   
   This makes sense -- thank you for the explanation @jiangzhx 
   
   Can you please add DataFrame tests the relevant behavior (mostly so that we don't break it in the future by accident)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org