You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/09 11:30:18 UTC
[GitHub] [pulsar] wenbingshen opened a new pull request #14625: fix partitionsAutoUpdateFuture never complete
wenbingshen opened a new pull request #14625:
URL: https://github.com/apache/pulsar/pull/14625
Fixes #14642
Master Issue: #14642
### Modifications
`partitionsAutoUpdateFuture` should `completeExceptionally` when get partition information due to network connection failure.
Need to update docs?
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wenbingshen commented on pull request #14625: fix partitionsAutoUpdateFuture never complete
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #14625:
URL: https://github.com/apache/pulsar/pull/14625#issuecomment-1065096305
> @wenbingshen - sorry, I had an old branch checked out locally and it didn't have the fix. I see now that master (and all active Pulsar branches) are good. Thanks for looking at `MultiTopicsConsumerImpl`.
@michaeljmarshall Yes, the current active Pulsar branches are good. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wenbingshen commented on pull request #14625: fix partitionsAutoUpdateFuture never complete
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #14625:
URL: https://github.com/apache/pulsar/pull/14625#issuecomment-1069190539
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wenbingshen commented on pull request #14625: fix partitionsAutoUpdateFuture never complete
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #14625:
URL: https://github.com/apache/pulsar/pull/14625#issuecomment-1063600198
> Good catch!
>
> I know it's hard, but would you like to try to find a way to add a test case? I shared some details about Pulsar tests in [#14602 (comment)](https://github.com/apache/pulsar/pull/14602#discussion_r822363841) .
Thanks for your review. Of course. I could try to add a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wenbingshen commented on pull request #14625: fix partitionsAutoUpdateFuture never complete
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #14625:
URL: https://github.com/apache/pulsar/pull/14625#issuecomment-1062827376
@lhotari @eolivelli @michaeljmarshall Could you help take a look? Thanks very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wenbingshen commented on pull request #14625: fix partitionsAutoUpdateFuture never complete
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #14625:
URL: https://github.com/apache/pulsar/pull/14625#issuecomment-1069721498
@codelipenghui The consumer test is always failing, so I removed the test that checks the results of the consumer automatic detection partition, since this PR has not fixed any consumer-related code, if we want to verify the status of the consumer, we can submit another PR to verify, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wenbingshen commented on pull request #14625: fix partitionsAutoUpdateFuture never complete
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #14625:
URL: https://github.com/apache/pulsar/pull/14625#issuecomment-1063988926
> LGTM.
>
> @wenbingshen - it looks like the same issue is present in this method: `MultiTopicsConsumerImpl#subscribeIncreasedTopicPartitions`. Would you like to fix that one too?
@michaeljmarshall Thanks for your review :). I looked at `MultiTopicsConsumerImpl#subscribeIncreasedTopicPartitions` implementation. I think it doesn't have this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wenbingshen commented on pull request #14625: fix partitionsAutoUpdateFuture never complete
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #14625:
URL: https://github.com/apache/pulsar/pull/14625#issuecomment-1070380681
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wenbingshen commented on pull request #14625: fix partitionsAutoUpdateFuture never complete
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #14625:
URL: https://github.com/apache/pulsar/pull/14625#issuecomment-1064100216
@lhotari @michaeljmarshall @codelipenghui I have added a test to check producer and consumer's partitionsAutoUpdateFuture's result. PTAL. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #14625: fix partitionsAutoUpdateFuture never complete
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #14625:
URL: https://github.com/apache/pulsar/pull/14625#issuecomment-1064782033
@wenbingshen - sorry, I had an old branch checked out locally and it didn't have the fix. I see now that master (and all active Pulsar branches) are good. Thanks for looking at `MultiTopicsConsumerImpl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14625: fix partitionsAutoUpdateFuture never complete
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14625:
URL: https://github.com/apache/pulsar/pull/14625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14625: fix partitionsAutoUpdateFuture never complete
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14625:
URL: https://github.com/apache/pulsar/pull/14625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wenbingshen edited a comment on pull request #14625: fix partitionsAutoUpdateFuture never complete
Posted by GitBox <gi...@apache.org>.
wenbingshen edited a comment on pull request #14625:
URL: https://github.com/apache/pulsar/pull/14625#issuecomment-1063600198
> Good catch!
>
> I know it's hard, but would you like to try to find a way to add a test case? I shared some details about Pulsar tests in [#14602 (comment)](https://github.com/apache/pulsar/pull/14602#discussion_r822363841) .
@lhotari Thanks for your review. Of course. I could try to add a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14625: fix partitionsAutoUpdateFuture never complete
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14625:
URL: https://github.com/apache/pulsar/pull/14625#issuecomment-1062871662
Good catch!
I know it's hard, but would you like to try to find a way to add a test case? I shared some details about Pulsar tests in https://github.com/apache/pulsar/pull/14602#discussion_r822363841 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wenbingshen commented on pull request #14625: fix partitionsAutoUpdateFuture never complete
Posted by GitBox <gi...@apache.org>.
wenbingshen commented on pull request #14625:
URL: https://github.com/apache/pulsar/pull/14625#issuecomment-1070464637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org