[GitHub] [calcite] Technay commented on a change in pull request #1544: [CALCITE-3415] Supports REGEXP_SUBSTR function

[GitBox <gi...@apache.org>]

Technay commented on a change in pull request #1544: [CALCITE-3415] Supports REGEXP_SUBSTR function
URL: https://github.com/apache/calcite/pull/1544#discussion_r341207444
 
 

 ##########
 File path: babel/src/test/resources/sql/redshift.iq
 ##########
 @@ -1843,9 +1843,9 @@ SELECT "REGEXP_REPLACE"('DonecFri@semperpretiumneque.com', '@.*\\.(org|gov|com)$
 
 # REGEXP_SUBSTR ( source_string, pattern [, position [, occurrence
 # [, parameters ] ] ] )
-select regexp_substr('Suspendisse.tristique@nonnisiAenean.edu','@[^.]*');
-SELECT "REGEXP_SUBSTR"('Suspendisse.tristique@nonnisiAenean.edu', '@[^.]*')
-!explain-validated-on calcite
+#select regexp_substr('Suspendisse.tristique@nonnisiAenean.edu','@[^.]*');
+#SELECT REGEXP_SUBSTR('Suspendisse.tristique@nonnisiAenean.edu', '@[^.]*')
+#!explain-validated-on calcite
 
 
 Review comment:
   As @amaliujia said, my change is breaking this test case. I haven't worked on calcite-babel or redshift.iq particularly, so I'm not sure about the format of test cases. From what I observed and understood, the expected translated query was "REGEXP_SUBSTR" with double quotes until it wasn't handled. After I added it into the standard, the double quotes were removed and the test case assertion failed.
   Please let me know a proper fix for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services