[GitHub] [incubator-doris] caiconghui commented on a change in pull request #5439: [Bug] Fix some problem with downloading and building thirdparty

[GitBox <gi...@apache.org>]

caiconghui commented on a change in pull request #5439:
URL: https://github.com/apache/incubator-doris/pull/5439#discussion_r587004087



##########
File path: thirdparty/build-thirdparty.sh
##########
@@ -472,6 +472,7 @@ build_brpc() {
     LDFLAGS="-L${TP_LIB_DIR} -static-libstdc++ -static-libgcc" \
     ${CMAKE_CMD} -G "${GENERATOR}" -v -DBUILD_SHARED_LIBS=0 -DCMAKE_INSTALL_PREFIX=$TP_INSTALL_DIR \
     -DBRPC_WITH_GLOG=ON -DWITH_GLOG=ON -DCMAKE_INCLUDE_PATH="$TP_INSTALL_DIR/include" \
+    -DCMAKE_LIBRARY_PATH="$TP_INSTALL_DIR/lib64" \

Review comment:
       I build thirdparty in ubuntu, and I find that if i don't set CMAKE_LIBRARY_PATH，it would be failed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org