[GitHub] [arrow] kou commented on a diff in pull request #35449: GH-35448: [C++] Fix detection of %z in strptime format

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #35449:
URL: https://github.com/apache/arrow/pull/35449#discussion_r1186472408


##########
cpp/src/arrow/compute/kernels/scalar_string_test.cc:
##########
@@ -1900,6 +1900,12 @@ TYPED_TEST(TestStringKernels, StrptimeZoneOffset) {
   StrptimeOptions options("%m/%d/%Y %z", TimeUnit::MICRO, /*error_is_null=*/true);
   this->CheckUnary("strptime", input1, timestamp(TimeUnit::MICRO, "UTC"), output1,
                    &options);

Review Comment:
   Could you append `1` to `options` (`options1`) for consistency?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org