You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "D.J. Heap" <dj...@gmail.com> on 2006/06/24 18:36:38 UTC
[PATCH] Build on Win32 without BDB
Any objections or comments (more pythonic style, etc) to this patch?
Log:
Allow BDB support to be optional on Win32.
* win-tests.py
Don't run bdb tests if we're testing fsfs.
* build/generator/gen_win.py
(get_install_targets): Drop bdb targets if we don't have bdb.
(get_win_defines): Set define to link fs_base if we have bdb.
(get_win_libs): Don't assume we have a path to bdb.
(_find_bdb): Don't assume they have bdb if it wasn't found.
* subversion/svn_private_config.hw
Don't always link fs_base.
Re: [PATCH] Build on Win32 without BDB
Posted by Branko Čibej <br...@xbc.nu>.
D.J. Heap wrote:
> On 6/26/06, Branko Čibej <br...@xbc.nu> wrote:
>> D.J. Heap wrote:
>> > Any objections or comments (more pythonic style, etc) to this patch?
>> >
>> > Log:
>> > Allow BDB support to be optional on Win32.
>> All right, but why limit that to the BDB back-end? If you do this, do it
>> for all FS back-ends.
>>
>> -- Brane
>
>
> Mostly because I don't use BDB and it's been asked for by others
> several times as well...and that's how the unix build works, isn't it?
> Or is any backend optional in the unix build?
Theoretically, it is. The loader implementation is symmetrical (as are
the #defines, as you saw). If course, in practice, fsfs doesn't bring
any external dependencies ...
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Build on Win32 without BDB
Posted by "D.J. Heap" <dj...@gmail.com>.
On 6/26/06, Branko Čibej <br...@xbc.nu> wrote:
> D.J. Heap wrote:
> > Any objections or comments (more pythonic style, etc) to this patch?
> >
> > Log:
> > Allow BDB support to be optional on Win32.
> All right, but why limit that to the BDB back-end? If you do this, do it
> for all FS back-ends.
>
> -- Brane
Mostly because I don't use BDB and it's been asked for by others
several times as well...and that's how the unix build works, isn't it?
Or is any backend optional in the unix build?
DJ
Re: [PATCH] Build on Win32 without BDB
Posted by Branko Čibej <br...@xbc.nu>.
D.J. Heap wrote:
> Any objections or comments (more pythonic style, etc) to this patch?
>
> Log:
> Allow BDB support to be optional on Win32.
All right, but why limit that to the BDB back-end? If you do this, do it
for all FS back-ends.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org