[jira] [Commented] (SAMZA-213) MessageChooser should be updated even when backing off consumers

["Anh Thu Vu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956633#comment-13956633 ] 

Anh Thu Vu commented on SAMZA-213:
----------------------------------

move the code to update MessageChooser from refresh.call() to a new helper method (updateMessageChooser()) and call it in SystemConsumers.choose()

> MessageChooser should be updated even when backing off consumers
> ----------------------------------------------------------------
>
>                 Key: SAMZA-213
>                 URL: https://issues.apache.org/jira/browse/SAMZA-213
>             Project: Samza
>          Issue Type: Bug
>          Components: container
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Chris Riccomini
>              Labels: patch
>             Fix For: 0.7.0
>
>         Attachments: patch-SAMZA-213.patch
>
>
> The SystemConsumers code for updating a MessageChooser is currently wrapped inside the refresher's exponential backoff code. This means that the chooser will not be updated if the refresher is backing off on consumers, even if unprocessedMessages has messages for streams in neededByChooser.
> This bug is described in some detail [here|http://mail-archives.apache.org/mod_mbox/incubator-samza-dev/201403.mbox/%3CCAAAp5iHX7rQF6_48Jy5qXPZo_6QpG4kktWkkQoum6KtDHgJ_dQ%40mail.gmail.com%3E]
> It seems like the best fix is to move the update code outside of the call() block, and call it independently of refresh.maybeCall.



--
This message was sent by Atlassian JIRA
(v6.2#6252)