You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2017/02/19 19:26:10 UTC
Review Request 56825: Taxonomy test failure fixes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56825/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1570
https://issues.apache.org/jira/browse/ATLAS-1570
Repository: atlas
Description
-------
Introduction of the StateTransactionCleanupFilter caused a side-effect that led to test failures
Diffs
-----
webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 45df9c7c
Diff: https://reviews.apache.org/r/56825/diff/
Testing
-------
mvn clean install executes successfully with some regular IT failures
Thanks,
Apoorv Naik
Re: Review Request 56825: Taxonomy test failure fixes
Posted by Jeff Hagelberg <jn...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56825/#review166106
-----------------------------------------------------------
Fix it, then Ship it!
webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java
<https://reviews.apache.org/r/56825/#comment237991>
Minor comment - now the transactionInitialized variable is unused and can be removed.
- Jeff Hagelberg
On Feb. 19, 2017, 7:26 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56825/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2017, 7:26 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1570
> https://issues.apache.org/jira/browse/ATLAS-1570
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Introduction of the StateTransactionCleanupFilter caused a side-effect that led to test failures
>
>
> Diffs
> -----
>
> webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 45df9c7c
>
> Diff: https://reviews.apache.org/r/56825/diff/
>
>
> Testing
> -------
>
> mvn clean install executes successfully with some regular IT failures
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 56825: Taxonomy test failure fixes
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56825/#review166042
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Feb. 19, 2017, 7:26 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56825/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2017, 7:26 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1570
> https://issues.apache.org/jira/browse/ATLAS-1570
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Introduction of the StateTransactionCleanupFilter caused a side-effect that led to test failures
>
>
> Diffs
> -----
>
> webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 45df9c7c
>
> Diff: https://reviews.apache.org/r/56825/diff/
>
>
> Testing
> -------
>
> mvn clean install executes successfully with some regular IT failures
>
>
> Thanks,
>
> Apoorv Naik
>
>