You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2015/04/08 03:13:13 UTC
[GitHub] tajo pull request: TAJO-1530: Display warn message when the query ...
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/tajo/pull/525
TAJO-1530: Display warn message when the query kill button is clicked in Web UI
You can test clicking kill button confirmation during the following command.
```
tsql -c 'create table t(a int)'
tsql -c 'insert into t select 1'
tsql -c 'select a from t union select sleep(10) from t'
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/tajo TAJO-1530
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/525.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #525
----
commit 226cd2e5da3c1f4bd710afe3b9c868d05c8c4100
Author: Dongjoon Hyun <do...@apache.org>
Date: 2015-04-08T01:10:10Z
TAJO-1530: Display warn message when the query kill button is clicked in WEB UI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1530: Display warn message when the query ...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/tajo/pull/525#issuecomment-92145198
Hi, @babokim . Could you review your issue? The change is just trivial Javascript code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1530: Display warn message when the query ...
Posted by babokim <gi...@git.apache.org>.
Github user babokim commented on the pull request:
https://github.com/apache/tajo/pull/525#issuecomment-92780957
This patch looks good to me. Here is my +1.
The Travis CI failed but it may be caused by TAJO-1526. This issue is trivial and not related any test case. All tests passed on my laptop. So I'll commit soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1530: Display warn message when the query ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/525
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1530: Display warn message when the query ...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/tajo/pull/525#issuecomment-93183910
Thank you, @babokim ! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---