You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@polaris.apache.org by Dmitri Bourlatchkov <di...@apache.org> on 2026/07/20 19:41:59 UTC

[DISCUSS] JDBC location overlap query fix (PR #5003)

Hi All,

This is just a call for a broader review of PR [5003].

IMHO, the fix is worth merging.

However, since it touches a fundamental aspect of JDBC persistence,
additional reviews would be beneficial. Please take a look.

[5003] https://github.com/apache/polaris/pull/5003

Thanks,
Dmitri.

Re: [DISCUSS] JDBC location overlap query fix (PR #5003)

Posted by Dmitri Bourlatchkov <di...@apache.org>.

Hi All,

PR #5003 has been merged.

Follow-up issue: https://github.com/apache/polaris/issues/5269

Cheers,
Dmitri.

On Fri, Aug 7, 2026 at 9:41 PM Dmitri Bourlatchkov <di...@apache.org> wrote:

> I propose merging this PR in its current state to improve correctness of
> the overlap check at the expense of doubling the number of SQL "where"
> conditions.
>
> As Alex suggested in the PR, let's consider
> removing ADD_TRAILING_SLASH_TO_LOCATION and providing upgrade instructions
> to rectify old locations stored in the database. After that we can reduce
> the number of SQL conditions in the overlap SELECT back to its old number.
>
> WDYT?
>
> Thanks,
> Dmitri.
>

Re: [DISCUSS] JDBC location overlap query fix (PR #5003)

Posted by Dmitri Bourlatchkov <di...@apache.org>.

I propose merging this PR in its current state to improve correctness of
the overlap check at the expense of doubling the number of SQL "where"
conditions.

As Alex suggested in the PR, let's consider
removing ADD_TRAILING_SLASH_TO_LOCATION and providing upgrade instructions
to rectify old locations stored in the database. After that we can reduce
the number of SQL conditions in the overlap SELECT back to its old number.

WDYT?

Thanks,
Dmitri.

Re: [DISCUSS] JDBC location overlap query fix (PR #5003)

Posted by Dmitri Bourlatchkov <di...@apache.org>.

Calling for more reviewers of this PR, please and thank you!

Cheers,
Dmitri.

On 2026/07/20 19:41:59 Dmitri Bourlatchkov wrote:
> Hi All,
> 
> This is just a call for a broader review of PR [5003].
> 
> IMHO, the fix is worth merging.
> 
> However, since it touches a fundamental aspect of JDBC persistence,
> additional reviews would be beneficial. Please take a look.
> 
> [5003] https://github.com/apache/polaris/pull/5003
> 
> Thanks,
> Dmitri.
>

Re: [DISCUSS] JDBC location overlap query fix (PR #5003)

Posted by Yufei Gu <fl...@gmail.com>.

Thanks for the notification. Will take a look soon.

Yufei

On Mon, Jul 20, 2026 at 12:42 PM Dmitri Bourlatchkov <di...@apache.org> wrote:
>
> Hi All,
>
> This is just a call for a broader review of PR [5003].
>
> IMHO, the fix is worth merging.
>
> However, since it touches a fundamental aspect of JDBC persistence,
> additional reviews would be beneficial. Please take a look.
>
> [5003] https://github.com/apache/polaris/pull/5003
>
> Thanks,
> Dmitri.